From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F224C433B4 for ; Wed, 31 Mar 2021 15:06:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F75561008 for ; Wed, 31 Mar 2021 15:06:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F75561008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRcQ7-0004fn-LY for qemu-devel@archiver.kernel.org; Wed, 31 Mar 2021 11:06:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRcOD-0003So-28; Wed, 31 Mar 2021 11:04:13 -0400 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]:38416) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRcOA-00024F-LI; Wed, 31 Mar 2021 11:04:12 -0400 Received: by mail-io1-xd36.google.com with SMTP id e8so20435568iok.5; Wed, 31 Mar 2021 08:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9p+g8WUPALCJeA1iNezXA04eJTFY0ED/yaX5BNzMwCg=; b=AWFgT9QwIDjEy3DTCx8UsRi08NU/OPL3Ywa7dUdO+9tuKg7QRdQTkC6FXmnPYcp69L Jgg8ygr8Hfv1mQm2KR9FnG4crtcE8nxpfzBgqp8AhCVuoyTZTCmR+ILdu8MqCuB2DjcE kLrKJ6AT+JGTb/hZMNW5ySigE8R4xp1WvxvYBMrbGhbNT7qoCHLEAGPANzGn6crTqAmC +TgMmOX7t39RdhW6eZYAg8XVwL3eZZwgatE3A0WIxXckbTG363M+umt1KFFWzO9Pn6MV BD8gP8yaBvORch1H3j1zZDlgAtdXnlBRHW0XovyrtQx2RURM1gJHyA+UMZPER/+2p7Qx xB3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9p+g8WUPALCJeA1iNezXA04eJTFY0ED/yaX5BNzMwCg=; b=IbqK5OhBtppF23nhRasY2zZMK4Wo1hdtB/jKL9BZIIo8N9kHmR/PYS8w2TzY53kAkk NMGihCV61JB4ZSmhACiXLFG+k9aG8nMOr0+JhY/cEQVTp70iLc7VaN/UgJoXsEds+mdH 8a+rKcIgNl6zy/u6qrnpTSwzKwRO3Pv3HxXQOLfVIGwdLOvFiKYWHhYPXLmOshPX2Z1D ze41PvQmmbH1Y4NUgsuHwS6EZVhJ3MoymIX1pGBVJtyCNOr61NziwUQVYZvJFzpiKRy+ 2IOB3jV0Npdj/dSoyVc2RlllGafElKVQhih9q8s4cAN10Imyn16T6Mgn44rDYLMPk1bB gusg== X-Gm-Message-State: AOAM531ncW3dy6dYcQbPF9u8sZ89alS4HGp0Wamzat+3zbWXMTBawsS7 XUp5pozgQBrBT4nck8XyUJ7mjb/X8R+iZIJDlJ0= X-Google-Smtp-Source: ABdhPJwAHcYQhGCrba4cmaTadxX8aULhzyBk5BjtcPjNXfSH7ndiBcfDi6V4qqXs/ayITQqXupiQo05n+pnkcq53S7M= X-Received: by 2002:a6b:d60c:: with SMTP id w12mr2608286ioa.105.1617203048921; Wed, 31 Mar 2021 08:04:08 -0700 (PDT) MIME-Version: 1.0 References: <20210331103612.654261-1-bmeng.cn@gmail.com> In-Reply-To: <20210331103612.654261-1-bmeng.cn@gmail.com> From: Alistair Francis Date: Wed, 31 Mar 2021 11:02:00 -0400 Message-ID: Subject: Re: [PATCH] hw/riscv: sifive_e: Add 'const' to sifive_e_memmap[] To: Bin Meng Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d36; envelope-from=alistair23@gmail.com; helo=mail-io1-xd36.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Emmanuel Blot , Alistair Francis , "qemu-devel@nongnu.org Developers" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Mar 31, 2021 at 6:36 AM Bin Meng wrote: > > This was accidentally dropped before. Add it back. > > Reported-by: Emmanuel Blot > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > hw/riscv/sifive_e.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c > index f939bcf9ea..82096b3e5a 100644 > --- a/hw/riscv/sifive_e.c > +++ b/hw/riscv/sifive_e.c > @@ -50,7 +50,7 @@ > #include "sysemu/sysemu.h" > #include "exec/address-spaces.h" > > -static MemMapEntry sifive_e_memmap[] = { > +static const MemMapEntry sifive_e_memmap[] = { > [SIFIVE_E_DEV_DEBUG] = { 0x0, 0x1000 }, > [SIFIVE_E_DEV_MROM] = { 0x1000, 0x2000 }, > [SIFIVE_E_DEV_OTP] = { 0x20000, 0x2000 }, > -- > 2.25.1 > >