From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44872C433ED for ; Tue, 27 Apr 2021 06:11:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C68DB610FA for ; Tue, 27 Apr 2021 06:11:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C68DB610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbGwp-0008Ls-PB for qemu-devel@archiver.kernel.org; Tue, 27 Apr 2021 02:11:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbGrl-0003i5-Ef; Tue, 27 Apr 2021 02:06:37 -0400 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]:39891) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbGrh-0001Ie-DD; Tue, 27 Apr 2021 02:06:37 -0400 Received: by mail-io1-xd2a.google.com with SMTP id k25so15487359iob.6; Mon, 26 Apr 2021 23:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZLnmJnX3w5rKg+FvO/If//Pj/7BbAmGH2Xbsbzl5iCs=; b=BbU0TFG2xxdEt/suQvC9LydpXfq4pkRXBqqINxlDfoZXXgDUvu8qYtJfaXHOO8XAeA poq6tTeXib4lAl8SBpX5razjQx1kxQ9lCfFF6KobQ5tVWyX4dTNwHRykudRFJNqPnuKx CeTyNr3Ngip+gfuiLolHUdMIynZqtVg66giFBFd02NHjHFmSj7590ENQo3IAYajm5EG1 WeLUxq5PqIIiMDcy1ohxbBXq38tnOV/pgRaUjM1knFJkfMEKH/iM6szQEhNnyAV96DPv JsjyC8kbfklYya7sRXGp0q+0x/ZS1kShXYkGkol6DTjI9FmEH5oD0fUXd4jfZ2kD2N9D Yang== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZLnmJnX3w5rKg+FvO/If//Pj/7BbAmGH2Xbsbzl5iCs=; b=jxlbDp1ooPBhMenDplj/zQTzX6dlIKBnGMmAHsaWSqIqNzZZPurIWejpr5HUQFCBu7 tqoxUkhIsmGo5rtJ/wJ1xGbDMiS11d3W6GQcqPrPlOyD6s1KhQnclGanbJXVPuzv4pKE d7xiy8mCu2CLbTYikqQ3tvoPkABpMEut89SlBQ39988BXUH5vI3bPGNt4A5qHSHMYXhd ldWY2JBEAuUpwhuwOiCToQGO3XP/CdOLfliGT0lVv+Ikv6kUf/+GelL9TPVo4WaMXg8+ XfrhK5SGm7/7SAoMLAgsp6oXK4u1rApWVY64CDk//C5rZ0CRUqRJ0/TQOOw/gLPJ4Gfh ToAA== X-Gm-Message-State: AOAM532wJDAKKeW9j9x6GxuEzKjZpaJ920/G1YAczuJbL9P8C8iZccSn tA94paAN9+Yr7fpKrRoW31z5C4zjm+H8GyW1IyY= X-Google-Smtp-Source: ABdhPJwBVAtV+ODDp68Ph+EzQPKv/Va6Nr7PxWbleXT77vpFFN6rwHUupeLyt8rtRJpz4hkjF6Rb6KWLdhEjRtNZ1uk= X-Received: by 2002:a05:6638:41:: with SMTP id a1mr20582703jap.8.1619503590385; Mon, 26 Apr 2021 23:06:30 -0700 (PDT) MIME-Version: 1.0 References: <20210421041400.22243-1-frank.chang@sifive.com> <20210421041400.22243-7-frank.chang@sifive.com> In-Reply-To: <20210421041400.22243-7-frank.chang@sifive.com> From: Alistair Francis Date: Tue, 27 Apr 2021 16:06:04 +1000 Message-ID: Subject: Re: [PATCH v5 06/17] target/riscv: rvb: min/max instructions To: Frank Chang Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d2a; envelope-from=alistair23@gmail.com; helo=mail-io1-xd2a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Sagar Karandikar , Bastian Koppelmann , Richard Henderson , "qemu-devel@nongnu.org Developers" , Alistair Francis , Palmer Dabbelt , Kito Cheng Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Apr 21, 2021 at 2:19 PM wrote: > > From: Kito Cheng > > Signed-off-by: Kito Cheng > Reviewed-by: Richard Henderson > Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn32.decode | 4 ++++ > target/riscv/insn_trans/trans_rvb.c.inc | 24 ++++++++++++++++++++++++ > 2 files changed, 28 insertions(+) > > diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode > index 7f32b8c6d15..d64326fd864 100644 > --- a/target/riscv/insn32.decode > +++ b/target/riscv/insn32.decode > @@ -605,3 +605,7 @@ xnor 0100000 .......... 100 ..... 0110011 @r > pack 0000100 .......... 100 ..... 0110011 @r > packu 0100100 .......... 100 ..... 0110011 @r > packh 0000100 .......... 111 ..... 0110011 @r > +min 0000101 .......... 100 ..... 0110011 @r > +minu 0000101 .......... 101 ..... 0110011 @r > +max 0000101 .......... 110 ..... 0110011 @r > +maxu 0000101 .......... 111 ..... 0110011 @r > diff --git a/target/riscv/insn_trans/trans_rvb.c.inc b/target/riscv/insn_trans/trans_rvb.c.inc > index 2d24dafac09..2aa4515fe31 100644 > --- a/target/riscv/insn_trans/trans_rvb.c.inc > +++ b/target/riscv/insn_trans/trans_rvb.c.inc > @@ -71,6 +71,30 @@ static bool trans_packh(DisasContext *ctx, arg_packh *a) > return gen_arith(ctx, a, gen_packh); > } > > +static bool trans_min(DisasContext *ctx, arg_min *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + return gen_arith(ctx, a, tcg_gen_smin_tl); > +} > + > +static bool trans_max(DisasContext *ctx, arg_max *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + return gen_arith(ctx, a, tcg_gen_smax_tl); > +} > + > +static bool trans_minu(DisasContext *ctx, arg_minu *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + return gen_arith(ctx, a, tcg_gen_umin_tl); > +} > + > +static bool trans_maxu(DisasContext *ctx, arg_maxu *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + return gen_arith(ctx, a, tcg_gen_umax_tl); > +} > + > /* RV64-only instructions */ > #ifdef TARGET_RISCV64 > > -- > 2.17.1 > >