From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F33DAC433DB for ; Thu, 14 Jan 2021 20:24:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6579A23A05 for ; Thu, 14 Jan 2021 20:24:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6579A23A05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l09AE-000549-Eo for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 15:24:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l097t-0003gT-Tx; Thu, 14 Jan 2021 15:21:50 -0500 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]:36205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l097p-0005st-Qg; Thu, 14 Jan 2021 15:21:49 -0500 Received: by mail-io1-xd36.google.com with SMTP id u26so13840687iof.3; Thu, 14 Jan 2021 12:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YaNE/paPh8P8JAilnJJhopKtZL3pGsaUN3JTvq/VNM8=; b=d6BzTin1vm3lVOD2b9CmfMoW+an/hfwu/KxzqXt5T45qCa7z8wVMa9BA7g+33qarQb p1beSR7wKfSZifwgJRYLS2t/v9gnj3i42vayaG9HDGdOzyu3xwKOO1so71FpTqM/IN84 wV4BuZHcDRkCoiB+XWDXfXQxl0y955+FZ5BQG8/3QdM+7sAJrAehpwEjDY3Vt56IOv2B Aj9+lt8ZxooKlDJf7BwUP/gpKC0B5ieVbLffXg+PSz54hTLRFcu6banEnRssBRtd/yJS 7KMf1PZ/kg6SxOAIoekBkIZKaXxo8IufHNg7IjcaS3TNDQyA6zI9FLPAWrA8whu2brmk uubA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YaNE/paPh8P8JAilnJJhopKtZL3pGsaUN3JTvq/VNM8=; b=R0k1ykohdAQXIFRLeWM/KszfJJE8U0/z3GwdEMMAnD1hu3AZzE7YQXo6ocaURXriQ1 68P/OoT5mssQYLtqaYlXCa1V9a8NR4ZDfIdlnl/ALq1+5To1kig8uIySEDzXSFPwgWqs NERRk6JOvS649RPRqtNkWYyF9TtmH0RacsNB5K8SS7YZ5dUftA5/8Q9e1i9g8xEk/DiD hEORJ9izGc0ZpjsbI+1kS5CxoNan58Mh07t5sI790wswr/I6ExIi50cbx2JoyeYbHuRu cUaGNt67/VQrvrJ3UE9iHEd4wOl4oeHA0jy6CGceVXifSZ8rYmuAEEkiOl7DwKgP3CuI azAA== X-Gm-Message-State: AOAM532tHTrh5K0i3wHgbVK7mi2JWHhqVaCkIwTfhh4s7mfswC52LRLv dFw7EQyIeaGOTgzWzW7zbmfjTqvMJkPow97PbhT0UlTewYU= X-Google-Smtp-Source: ABdhPJygQ9RC50bXbgIJrSUpkdBU81xfXa/FOqIh7NIR+YccQhmYjyw02aElbGeRgz4HL1PKz7+UH5932/1+D2XGFE4= X-Received: by 2002:a05:6e02:194f:: with SMTP id x15mr8345818ilu.177.1610655704268; Thu, 14 Jan 2021 12:21:44 -0800 (PST) MIME-Version: 1.0 References: <20210109143637.29645-1-bmeng.cn@gmail.com> In-Reply-To: <20210109143637.29645-1-bmeng.cn@gmail.com> From: Alistair Francis Date: Thu, 14 Jan 2021 12:21:18 -0800 Message-ID: Subject: Re: [PATCH] hw/riscv: sifive_u: Use SIFIVE_U_CPU for mc->default_cpu_type To: Bin Meng Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d36; envelope-from=alistair23@gmail.com; helo=mail-io1-xd36.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Bin Meng , Alistair Francis , "qemu-devel@nongnu.org Developers" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Jan 9, 2021 at 6:37 AM Bin Meng wrote: > > From: Bin Meng > > SIFIVE_U_CPU is conditionally set to SIFIVE_U34 or SIFIVE_U54, hence > there is no need to use #idef to set the mc->default_cpu_type. > > Signed-off-by: Bin Meng Reviewed-by: Alistair Francis Alistair > --- > > hw/riscv/sifive_u.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c > index f5c400dd44..e083510e0e 100644 > --- a/hw/riscv/sifive_u.c > +++ b/hw/riscv/sifive_u.c > @@ -628,11 +628,7 @@ static void sifive_u_machine_class_init(ObjectClass *oc, void *data) > mc->init = sifive_u_machine_init; > mc->max_cpus = SIFIVE_U_MANAGEMENT_CPU_COUNT + SIFIVE_U_COMPUTE_CPU_COUNT; > mc->min_cpus = SIFIVE_U_MANAGEMENT_CPU_COUNT + 1; > -#if defined(TARGET_RISCV32) > - mc->default_cpu_type = TYPE_RISCV_CPU_SIFIVE_U34; > -#elif defined(TARGET_RISCV64) > - mc->default_cpu_type = TYPE_RISCV_CPU_SIFIVE_U54; > -#endif > + mc->default_cpu_type = SIFIVE_U_CPU; > mc->default_cpus = mc->min_cpus; > > object_class_property_add_bool(oc, "start-in-flash", > -- > 2.25.1 > >