From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9B9C433E0 for ; Fri, 12 Feb 2021 21:37:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF34C64E36 for ; Fri, 12 Feb 2021 21:37:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF34C64E36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAg7c-0006XZ-0k for qemu-devel@archiver.kernel.org; Fri, 12 Feb 2021 16:37:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAg60-0005va-IO; Fri, 12 Feb 2021 16:35:27 -0500 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]:40208) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAg5u-00043q-Mk; Fri, 12 Feb 2021 16:35:24 -0500 Received: by mail-il1-x12b.google.com with SMTP id e7so510179ile.7; Fri, 12 Feb 2021 13:35:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OXTkF8AuHLlIcGIgjz1lGhBGF2z21hAgGEilNB7USdY=; b=CH7ISPrfA0SAVwucQS4dIGDyzTIO9WE+RTjf285+5oxgx0W5TI8N+g1un0dcn5bdhf QYNoCUnGFGhvZqVEzTSSbXHtTWOUh/ZepmAPu5crdJVPpz9TmUm9eFleG4wL6LiyWsnP hjsIoUev+qhp3Ni0CKMYxGlskndkpnbz2HULYKaguv9aUWDnMfbLh/01XkteSPoHRFNq 6Mes94eMKGxFvYRQA2ZZw/NPEwkVFU8whkwXY02NNDtwFp+zAZU8/Pz6EYK1bJwwJfFG aEeaoKt/O3ro7ATSNXWoXLfh29+oW24h8OWbmSSucfQMdmoCMYQ36Jyi13ZpnWuiCHfX MzzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OXTkF8AuHLlIcGIgjz1lGhBGF2z21hAgGEilNB7USdY=; b=Cemx+OWKtZ2SE4aUps281lnpvFlRFPtRL+xpuG+lc/eu/ecEG9ep9t/XHffNdYJwea flxXY6twxbyrdBbmGyJR6ibrqQxgYjZ0BMfOB2jYSUsuGdSFL1ifYluhxUcgC5hRPGuJ Hy6A8OEXd/XbgfesYl218SasZePsBuFi9JrQszjYAxNgtxdP2gSTqq8II1XrfxoQri0a +tKPQFf6AXaCUsx++tLOiTqHT3QJp+SfFJx/PM067lQBKlOApZX/nX385+TJGwGgyqJM 78SbxWLNqWjrqj78D6mLX+1R9I1W6Id8IODebH818Jl8bI/SfnD9G6E+r5clyvIUZbCu H2+w== X-Gm-Message-State: AOAM530iBawU/mvcIFYi2L23iGKUgdMXFLA31augM+1U4rArbMMXAKvh glCCutvmbwqCSIkc8X0gkOVYFIC9TlvrfCRR4G4= X-Google-Smtp-Source: ABdhPJxPcVAlCc2AiH4MZMYvoh2k4yEf72LIpXaMPFsKwEHUVnQo/KYxabt8P8+nh9LRK/DOwP+NDvUjLcdELuwXKz4= X-Received: by 2002:a05:6e02:218f:: with SMTP id j15mr3908449ila.40.1613165717196; Fri, 12 Feb 2021 13:35:17 -0800 (PST) MIME-Version: 1.0 References: <1613031446-22154-1-git-send-email-sai.pavan.boddu@xilinx.com> <1613031446-22154-4-git-send-email-sai.pavan.boddu@xilinx.com> In-Reply-To: <1613031446-22154-4-git-send-email-sai.pavan.boddu@xilinx.com> From: Alistair Francis Date: Fri, 12 Feb 2021 13:34:36 -0800 Message-ID: Subject: Re: [RFC PATCH 03/15] sd: emmc: Dont not update CARD_CAPACITY for eMMC cards To: Sai Pavan Boddu Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::12b; envelope-from=alistair23@gmail.com; helo=mail-il1-x12b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Thomas Huth , Vladimir Sementsov-Ogievskiy , Vincent Palatin , "Edgar E. Iglesias" , Qemu-block , "qemu-devel@nongnu.org Developers" , Markus Armbruster , Max Reitz , Sai Pavan Boddu , Luc Michel , Alistair Francis , Joel Stanley , Stefan Hajnoczi , Paolo Bonzini , "Dr. David Alan Gilbert" , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Feb 11, 2021 at 12:22 AM Sai Pavan Boddu wrote: > > OCR.CARD_CAPACITY field is only valid for sd cards, So skip it for eMMC. > > Signed-off-by: Sai Pavan Boddu > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/sd/sd.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/sd/sd.c b/hw/sd/sd.c > index a75fa1c..57fff89 100644 > --- a/hw/sd/sd.c > +++ b/hw/sd/sd.c > @@ -308,7 +308,8 @@ static void sd_ocr_powerup(void *opaque) > /* card power-up OK */ > sd->ocr = FIELD_DP32(sd->ocr, OCR, CARD_POWER_UP, 1); > > - if (sd->size > SDSC_MAX_CAPACITY) { > + /* eMMC supports only Byte mode */ > + if (!sd->emmc && sd->size > SDSC_MAX_CAPACITY) { > sd->ocr = FIELD_DP32(sd->ocr, OCR, CARD_CAPACITY, 1); > } > } > -- > 2.7.4 > >