qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 1/1] hw/riscv: Enalbe VIRTIO_VGA for RISC-V virt machine
@ 2021-04-02 12:42 Alistair Francis
  2021-04-06  8:41 ` Bin Meng
  0 siblings, 1 reply; 3+ messages in thread
From: Alistair Francis @ 2021-04-02 12:42 UTC (permalink / raw)
  To: qemu-devel, qemu-riscv; +Cc: alistair.francis, bmeng.cn, palmer, alistair23

imply VIRTIO_VGA for the virt machine, this fixes the following error
when specifying `-vga virtio` as a command line argument:

qemu-system-riscv64: Virtio VGA not available

Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
 hw/riscv/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
index 1de18cdcf1..9dc1e7c244 100644
--- a/hw/riscv/Kconfig
+++ b/hw/riscv/Kconfig
@@ -22,6 +22,7 @@ config OPENTITAN
 config RISCV_VIRT
     bool
     imply PCI_DEVICES
+    imply VIRTIO_VGA
     imply TEST_DEVICES
     select GOLDFISH_RTC
     select MSI_NONBROKEN
-- 
2.31.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] hw/riscv: Enalbe VIRTIO_VGA for RISC-V virt machine
  2021-04-02 12:42 [PATCH v1 1/1] hw/riscv: Enalbe VIRTIO_VGA for RISC-V virt machine Alistair Francis
@ 2021-04-06  8:41 ` Bin Meng
  2021-04-07 14:26   ` Alistair Francis
  0 siblings, 1 reply; 3+ messages in thread
From: Bin Meng @ 2021-04-06  8:41 UTC (permalink / raw)
  To: Alistair Francis
  Cc: Palmer Dabbelt, open list:RISC-V,
	qemu-devel@nongnu.org Developers, Alistair Francis

On Fri, Apr 2, 2021 at 8:44 PM Alistair Francis
<alistair.francis@wdc.com> wrote:
>

typo in the commit title: Enalbe -> Enable

> imply VIRTIO_VGA for the virt machine, this fixes the following error
> when specifying `-vga virtio` as a command line argument:
>
> qemu-system-riscv64: Virtio VGA not available
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
>  hw/riscv/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Otherwise,
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1 1/1] hw/riscv: Enalbe VIRTIO_VGA for RISC-V virt machine
  2021-04-06  8:41 ` Bin Meng
@ 2021-04-07 14:26   ` Alistair Francis
  0 siblings, 0 replies; 3+ messages in thread
From: Alistair Francis @ 2021-04-07 14:26 UTC (permalink / raw)
  To: Bin Meng
  Cc: open list:RISC-V, Palmer Dabbelt, Alistair Francis,
	qemu-devel@nongnu.org Developers

On Tue, Apr 6, 2021 at 4:41 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Fri, Apr 2, 2021 at 8:44 PM Alistair Francis
> <alistair.francis@wdc.com> wrote:
> >
>
> typo in the commit title: Enalbe -> Enable

Good catch, fixed.

>
> > imply VIRTIO_VGA for the virt machine, this fixes the following error
> > when specifying `-vga virtio` as a command line argument:
> >
> > qemu-system-riscv64: Virtio VGA not available
> >
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> >  hw/riscv/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> Otherwise,
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Thanks!

Applied to riscv-to-apply.next

Alistair


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-07 14:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02 12:42 [PATCH v1 1/1] hw/riscv: Enalbe VIRTIO_VGA for RISC-V virt machine Alistair Francis
2021-04-06  8:41 ` Bin Meng
2021-04-07 14:26   ` Alistair Francis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).