From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F2BC4332B for ; Wed, 18 Mar 2020 23:54:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FB952076C for ; Wed, 18 Mar 2020 23:54:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sEps0ns9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FB952076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEiVx-00067S-7e for qemu-devel@archiver.kernel.org; Wed, 18 Mar 2020 19:54:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49785) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEiVN-0005gH-Ts for qemu-devel@nongnu.org; Wed, 18 Mar 2020 19:53:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEiVM-0001Hd-HB for qemu-devel@nongnu.org; Wed, 18 Mar 2020 19:53:45 -0400 Received: from mail-vs1-xe42.google.com ([2607:f8b0:4864:20::e42]:46002) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEiVM-0001Ej-Ci; Wed, 18 Mar 2020 19:53:44 -0400 Received: by mail-vs1-xe42.google.com with SMTP id x82so392940vsc.12; Wed, 18 Mar 2020 16:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SqF3DZicOvED+tNSF5bdDI6KNFhLMtWMW7Q27EbHtxU=; b=sEps0ns9Yj3mijwzA8cnwn9FaLTS0iCff23h7EFuC6hQQp44dO+ZphR50cPn6WEQOs s23JOqjjHQ0Uwd9BfA2pokwNzcNuyERHOvH5ykmLLoOfkiOPeBGaMPP+pLj4p/FqRGIF VMesIR5Z9iErNjw/UnfC1sfZdhF5+EXzTmuyO0ONsGBOMXna6+p++17qRxNdkSI/zSVU VttYbNWFzcLuqgHhVl1PdJWWTdwT0Mw6GMikBnzeNnQ/LOvr/bHyGuTm4EsBaGc6cjaA 6PPsQVfPeHjEJXFml0/Z84YNSCw4gMuhTy+EdmFelFaErsMnkUJzOEiD8bLO7iuPhYCr wOvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SqF3DZicOvED+tNSF5bdDI6KNFhLMtWMW7Q27EbHtxU=; b=PZpD9CMVA6QrbExt3DuiI3zB/5Y9OPLen2FIeLUzGNvd8bbkXS6dvmPQR9fV8y0Bfo hppceVY6PyMQfb59Jxkz6oWLeC/crgTGWHG6ChPJRAh6hatjX9tuXlSbyilkfQZsN23l 7m3vLxuh9yVXCT85CNKTnTAO4jyi+EZJMVG+FTSgzj0Cnb2MB/CtmOiylkDcfcirDU83 uQP9GFUSYVSqSvec5Atc2Q4T2EyQAIqBPhx5ZO0ReqDZCV1uWylrsFNLaUjpBtZPxhoD Oc+P7a+57dCoxluCIUd1C1y0V5THFBga4tEnES6Zl/KxL5gs13Ogg2iBeii5dQiFk4G7 1yLQ== X-Gm-Message-State: ANhLgQ20HG+5kPXdsAGSCQPYyMEKX9rpb4AUhKh8b30pVUmNLWmEUZeM Uy9fWyeeJ2WQF/Ns4Tud+BLnE0dPTvS7k/Er5T8= X-Google-Smtp-Source: ADFU+vt4H2flXeRiFiTaU9usR1e7O+P93YjEvzuvWpcAX7ZPLAH31ubvR/P8feciOeaOycnZx306vutBe+Atbwyn4MI= X-Received: by 2002:a67:26c2:: with SMTP id m185mr171131vsm.180.1584575623369; Wed, 18 Mar 2020 16:53:43 -0700 (PDT) MIME-Version: 1.0 References: <20200317150653.9008-1-zhiwei_liu@c-sky.com> <20200317150653.9008-6-zhiwei_liu@c-sky.com> In-Reply-To: <20200317150653.9008-6-zhiwei_liu@c-sky.com> From: Alistair Francis Date: Wed, 18 Mar 2020 16:45:46 -0700 Message-ID: Subject: Re: [PATCH v6 05/61] target/riscv: add an internals.h header To: LIU Zhiwei Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::e42 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guoren@linux.alibaba.com, "open list:RISC-V" , Richard Henderson , "qemu-devel@nongnu.org Developers" , wxy194768@alibaba-inc.com, Chih-Min Chao , wenmeng_zhang@c-sky.com, Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Mar 17, 2020 at 8:17 AM LIU Zhiwei wrote: > > The internals.h keeps things that are not relevant to the actual architecture, > only to the implementation, separate. > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/internals.h | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 target/riscv/internals.h > > diff --git a/target/riscv/internals.h b/target/riscv/internals.h > new file mode 100644 > index 0000000000..cabea18e1d > --- /dev/null > +++ b/target/riscv/internals.h > @@ -0,0 +1,24 @@ > +/* > + * QEMU RISC-V CPU -- internal functions and types > + * > + * Copyright (c) 2020 C-SKY Limited. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2 or later, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program. If not, see . > + */ > + > +#ifndef RISCV_CPU_INTERNALS_H > +#define RISCV_CPU_INTERNALS_H > + > +#include "hw/registerfields.h" > + > +#endif > -- > 2.23.0 >