From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emSDn-0001iI-NO for qemu-devel@nongnu.org; Thu, 15 Feb 2018 17:41:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emSDm-0004y1-KO for qemu-devel@nongnu.org; Thu, 15 Feb 2018 17:41:43 -0500 Received: from mail-lf0-x235.google.com ([2a00:1450:4010:c07::235]:44345) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emSDl-0004xS-UX for qemu-devel@nongnu.org; Thu, 15 Feb 2018 17:41:42 -0500 Received: by mail-lf0-x235.google.com with SMTP id c188so1687787lfc.11 for ; Thu, 15 Feb 2018 14:41:41 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: From: Alistair Francis Date: Thu, 15 Feb 2018 14:41:09 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 3/6] bcm2836: Use the Cortex-A7 instead of Cortex-A15 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Peter Maydell , Alistair Francis , "qemu-devel@nongnu.org Developers" , Eduardo Habkost , Marcel Apfelbaum , Igor Mammedov On Thu, Feb 15, 2018 at 5:23 AM, Philippe Mathieu-Daud=C3=A9 wrote: > Hi Peter, > > On 02/01/2018 09:42 PM, Alistair Francis wrote: >> The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use >> the correct CPU. >> https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/Q= A7_rev3.4.pdf > > Can you add these lines with reference to the commits? > > When the BCM2836 was introduced (bad5623690b) the Cortex-A7 was not > available, so the very similar Cortex-A15 was used. > > Since dcf578ed8ce we can model the correct core. > > Thanks! Added! I'm not sure when I'll send the next version out though. Alistair > > Phil. > >> Signed-off-by: Alistair Francis >> Reviewed-by: Philippe Mathieu-Daud=C3=A9 >> Reviewed-by: Igor Mammedov >> --- >> V3: >> - Use ARM_CPU_TYPE_NAME() macro >> V2: >> - Fix the BCM2836 CPU >> >> hw/arm/bcm2836.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/hw/arm/bcm2836.c b/hw/arm/bcm2836.c >> index 8c43291112..c477772484 100644 >> --- a/hw/arm/bcm2836.c >> +++ b/hw/arm/bcm2836.c >> @@ -30,7 +30,7 @@ static void bcm2836_init(Object *obj) >> >> for (n =3D 0; n < BCM2836_NCPUS; n++) { >> object_initialize(&s->cpus[n], sizeof(s->cpus[n]), >> - "cortex-a15-" TYPE_ARM_CPU); >> + ARM_CPU_TYPE_NAME("cortex-a7")); >> object_property_add_child(obj, "cpu[*]", OBJECT(&s->cpus[n]), >> &error_abort); >> } >>