From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A47C433DB for ; Thu, 7 Jan 2021 17:24:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62F38233CE for ; Thu, 7 Jan 2021 17:24:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62F38233CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxZ16-0004ls-FT for qemu-devel@archiver.kernel.org; Thu, 07 Jan 2021 12:24:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxYyX-0001IK-8q; Thu, 07 Jan 2021 12:21:29 -0500 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]:39023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxYyT-0004hn-E4; Thu, 07 Jan 2021 12:21:29 -0500 Received: by mail-il1-x133.google.com with SMTP id q1so7450747ilt.6; Thu, 07 Jan 2021 09:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lj1dIjgJAB4CfFTM3uOm4Tfj6WYesgRX8Abi0tAnS2w=; b=KV7ro4rwsMzBU8VxM0KQUyF2p0HFSiycqS2oB94qqHfdUSEeolTw3vkMfvmdoCOYzL viKWMnv5p/NLbA9s17JJKOwt4fiJ82/nImIDU7jtoLYQDhFTmkhoWzx4gjL7T0wheK4R jxzN6GDVyo0BiylY0uTx5t+pkJ74krl8VWcvDAIwEUg4kxxu5knY4l0/2tm03KCA1ZuP QzItA97CHzs6CRTShh77QiAUFnFRu0AC4w9PgJE80A0qrpWIjSm+mM54+UC8PWUuCAxN 7SGPHoMVqixhL4hhDdCi5MGr++Gc4AyPUjsPAWtWGB7LM/TvPz4/1JTbROFF4cJgvhXh 7oKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lj1dIjgJAB4CfFTM3uOm4Tfj6WYesgRX8Abi0tAnS2w=; b=F3T2HAq2Cc5I4IbmbQpjryUrgJTVuE6HB+0y8RKh6abRyNF+jQ8oCb4DP1P2lHp9/V Vx7FvgrtmVG8+Ju+Th6sK/F8d1to+FLZmjDNxwS/WEtsfztqzLveN0ib2/FRHvpdLZ2u xzjhu/+oqzInwPysi+kL9seEihJrBYO0zAy0VAbW96xdAFSQBBuZy+8YQQS9evgWa5w1 wSZ24wKOU/QCFyljnkxEWINlOk4ReU3xZkqwrohFbUpL1MpbyvFb/+EnGppddjlJ5nDa VJ2Gkc0aNK6WpNVGrVfpKqzkhI2EXKyM6aaaHaZD5fS0l3Cear43VSVfIXxqm6JPdJ3E FElQ== X-Gm-Message-State: AOAM532KviUhi3SnwRCY0BZPN9VQ7pazvL1GEo96xRFvo+txcd66c3bQ NydxAOJr3C60zLUqRctOqp9j+IVuaWp/Mx2bF7M= X-Google-Smtp-Source: ABdhPJyz1SBh5eouQDThMckXGYaFsqKvLsXvE192EYdAKi3MEeXYagQV4R7K88r8IyQ0iuCrBYQ8D3G3yRGn8nUbV/M= X-Received: by 2002:a92:c942:: with SMTP id i2mr9866817ilq.227.1610040083255; Thu, 07 Jan 2021 09:21:23 -0800 (PST) MIME-Version: 1.0 References: <20201218022653.654-1-jiangyifei@huawei.com> <20201218022653.654-2-jiangyifei@huawei.com> In-Reply-To: <20201218022653.654-2-jiangyifei@huawei.com> From: Alistair Francis Date: Thu, 7 Jan 2021 09:20:57 -0800 Message-ID: Subject: Re: [PATCH v2 1/1] target-riscv: support QMP dump-guest-memory To: Yifei Jiang Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::133; envelope-from=alistair23@gmail.com; helo=mail-il1-x133.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Zhanghailiang , Sagar Karandikar , Bastian Koppelmann , "Zhangxiaofeng \(F\)" , "qemu-devel@nongnu.org Developers" , "limingwang \(A\)" , Alistair Francis , Palmer Dabbelt , fanliang@huawei.com, "Wubin \(H\)" , "dengkai \(A\)" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Dec 17, 2020 at 6:29 PM Yifei Jiang wrote: > > Add the support needed for creating prstatus elf notes. Now elf notes > only contains user_regs. This allows us to use QMP dump-guest-memory. > > Signed-off-by: Yifei Jiang > Signed-off-by: Mingwang Li Reviewed-by: Alistair Francis Alistair > --- > target/riscv/arch_dump.c | 189 +++++++++++++++++++++++++++++++++++++++ > target/riscv/cpu.c | 2 + > target/riscv/cpu.h | 4 + > target/riscv/cpu_bits.h | 1 + > target/riscv/meson.build | 1 + > 5 files changed, 197 insertions(+) > create mode 100644 target/riscv/arch_dump.c > > diff --git a/target/riscv/arch_dump.c b/target/riscv/arch_dump.c > new file mode 100644 > index 0000000000..b89ddf18c7 > --- /dev/null > +++ b/target/riscv/arch_dump.c > @@ -0,0 +1,189 @@ > +/* Support for writing ELF notes for RISC-V architectures > + * > + * Copyright (C) 2020 Huawei Technologies Co., Ltd > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2 or later, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program. If not, see . > + */ > + > +#include "qemu/osdep.h" > +#include "cpu.h" > +#include "elf.h" > +#include "sysemu/dump.h" > + > +/* struct user_regs_struct from arch/riscv/include/uapi/asm/ptrace.h */ > +struct riscv_user_regs { > + target_ulong pc; > + target_ulong regs[31]; > +} QEMU_PACKED; > + > +/* struct elf_prstatus from include/uapi/linux/elfcore.h */ > +struct riscv64_elf_prstatus { > + char pad1[32]; /* 32 == offsetof(struct elf_prstatus, pr_pid) */ > + uint32_t pr_pid; > + char pad2[76]; /* 76 == offsetof(struct elf_prstatus, pr_reg) - > + offsetof(struct elf_prstatus, pr_ppid) */ > + struct riscv_user_regs pr_reg; > + char pad3[8]; > +} QEMU_PACKED; > + > +struct riscv64_note { > + Elf64_Nhdr hdr; > + char name[8]; /* align_up(sizeof("CORE"), 4) */ > + struct riscv64_elf_prstatus prstatus; > +} QEMU_PACKED; > + > +#define RISCV64_NOTE_HEADER_SIZE offsetof(struct riscv64_note, prstatus) > +#define RISCV64_PRSTATUS_NOTE_SIZE \ > + (RISCV64_NOTE_HEADER_SIZE + sizeof(struct riscv64_elf_prstatus)) > + > +static void riscv64_note_init(struct riscv64_note *note, DumpState *s, > + const char *name, Elf64_Word namesz, > + Elf64_Word type, Elf64_Word descsz) > +{ > + memset(note, 0, sizeof(*note)); > + > + note->hdr.n_namesz = cpu_to_dump32(s, namesz); > + note->hdr.n_descsz = cpu_to_dump32(s, descsz); > + note->hdr.n_type = cpu_to_dump32(s, type); > + > + memcpy(note->name, name, namesz); > +} > + > +int riscv_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState *cs, > + int cpuid, void *opaque) > +{ > + struct riscv64_note note; > + RISCVCPU *cpu = RISCV_CPU(cs); > + CPURISCVState *env = &cpu->env; > + DumpState *s = opaque; > + int ret, i = 0; > + const char name[] = "CORE"; > + > + riscv64_note_init(¬e, s, name, sizeof(name), > + NT_PRSTATUS, sizeof(note.prstatus)); > + > + note.prstatus.pr_pid = cpu_to_dump32(s, cpuid); > + > + note.prstatus.pr_reg.pc = cpu_to_dump64(s, env->pc); > + > + for (i = 0; i < 31; i++) { > + note.prstatus.pr_reg.regs[i] = cpu_to_dump64(s, env->gpr[i + 1]); > + } > + > + ret = f(¬e, RISCV64_PRSTATUS_NOTE_SIZE, s); > + if (ret < 0) { > + return -1; > + } > + > + return ret; > +} > + > +struct riscv32_elf_prstatus { > + char pad1[24]; /* 24 == offsetof(struct elf_prstatus, pr_pid) */ > + uint32_t pr_pid; > + char pad2[44]; /* 44 == offsetof(struct elf_prstatus, pr_reg) - > + offsetof(struct elf_prstatus, pr_ppid) */ > + struct riscv_user_regs pr_reg; > + char pad3[4]; > +} QEMU_PACKED; > + > +struct riscv32_note { > + Elf32_Nhdr hdr; > + char name[8]; /* align_up(sizeof("CORE"), 4) */ > + struct riscv32_elf_prstatus prstatus; > +} QEMU_PACKED; > + > +#define RISCV32_NOTE_HEADER_SIZE offsetof(struct riscv32_note, prstatus) > +#define RISCV32_PRSTATUS_NOTE_SIZE \ > + (RISCV32_NOTE_HEADER_SIZE + sizeof(struct riscv32_elf_prstatus)) > + > +static void riscv32_note_init(struct riscv32_note *note, DumpState *s, > + const char *name, Elf32_Word namesz, > + Elf32_Word type, Elf32_Word descsz) > +{ > + memset(note, 0, sizeof(*note)); > + > + note->hdr.n_namesz = cpu_to_dump32(s, namesz); > + note->hdr.n_descsz = cpu_to_dump32(s, descsz); > + note->hdr.n_type = cpu_to_dump32(s, type); > + > + memcpy(note->name, name, namesz); > +} > + > +int riscv_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs, > + int cpuid, void *opaque) > +{ > + struct riscv32_note note; > + RISCVCPU *cpu = RISCV_CPU(cs); > + CPURISCVState *env = &cpu->env; > + DumpState *s = opaque; > + int ret, i; > + const char name[] = "CORE"; > + > + riscv32_note_init(¬e, s, name, sizeof(name), > + NT_PRSTATUS, sizeof(note.prstatus)); > + > + note.prstatus.pr_pid = cpu_to_dump32(s, cpuid); > + > + note.prstatus.pr_reg.pc = cpu_to_dump32(s, env->pc); > + > + for (i = 0; i < 31; i++) { > + note.prstatus.pr_reg.regs[i] = cpu_to_dump32(s, env->gpr[i + 1]); > + } > + > + ret = f(¬e, RISCV32_PRSTATUS_NOTE_SIZE, s); > + if (ret < 0) { > + return -1; > + } > + > + return ret; > +} > + > +int cpu_get_dump_info(ArchDumpInfo *info, > + const GuestPhysBlockList *guest_phys_blocks) > +{ > + RISCVCPU *cpu; > + CPURISCVState *env; > + > + if (first_cpu == NULL) { > + return -1; > + } > + cpu = RISCV_CPU(first_cpu); > + env = &cpu->env; > + > + info->d_machine = EM_RISCV; > + > +#if defined(TARGET_RISCV64) > + info->d_class = ELFCLASS64; > +#else > + info->d_class = ELFCLASS32; > +#endif > + > + info->d_endian = (env->mstatus & MSTATUS_UBE) != 0 > + ? ELFDATA2MSB : ELFDATA2LSB; > + > + return 0; > +} > + > +ssize_t cpu_get_note_size(int class, int machine, int nr_cpus) > +{ > + size_t note_size; > + > + if (class == ELFCLASS64) { > + note_size = RISCV64_PRSTATUS_NOTE_SIZE; > + } else { > + note_size = RISCV32_PRSTATUS_NOTE_SIZE; > + } > + > + return note_size * nr_cpus; > +} > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index 6a0264fc6b..69999af813 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -560,6 +560,8 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data) > cc->get_phys_page_debug = riscv_cpu_get_phys_page_debug; > /* For now, mark unmigratable: */ > cc->vmsd = &vmstate_riscv_cpu; > + cc->write_elf64_note = riscv_cpu_write_elf64_note; > + cc->write_elf32_note = riscv_cpu_write_elf32_note; > #endif > #ifdef CONFIG_TCG > cc->tcg_initialize = riscv_translate_init; > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h > index c0a326c843..4a340b0c73 100644 > --- a/target/riscv/cpu.h > +++ b/target/riscv/cpu.h > @@ -315,6 +315,10 @@ extern const char * const riscv_intr_names[]; > > const char *riscv_cpu_get_trap_name(target_ulong cause, bool async); > void riscv_cpu_do_interrupt(CPUState *cpu); > +int riscv_cpu_write_elf64_note(WriteCoreDumpFunction f, CPUState *cs, > + int cpuid, void *opaque); > +int riscv_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs, > + int cpuid, void *opaque); > int riscv_cpu_gdb_read_register(CPUState *cpu, GByteArray *buf, int reg); > int riscv_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg); > bool riscv_cpu_exec_interrupt(CPUState *cs, int interrupt_request); > diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h > index 24b24c69c5..d7259561e7 100644 > --- a/target/riscv/cpu_bits.h > +++ b/target/riscv/cpu_bits.h > @@ -368,6 +368,7 @@ > #define MSTATUS_MIE 0x00000008 > #define MSTATUS_UPIE 0x00000010 > #define MSTATUS_SPIE 0x00000020 > +#define MSTATUS_UBE 0x00000040 > #define MSTATUS_MPIE 0x00000080 > #define MSTATUS_SPP 0x00000100 > #define MSTATUS_MPP 0x00001800 > diff --git a/target/riscv/meson.build b/target/riscv/meson.build > index 14a5c62dac..88ab850682 100644 > --- a/target/riscv/meson.build > +++ b/target/riscv/meson.build > @@ -26,6 +26,7 @@ riscv_ss.add(files( > > riscv_softmmu_ss = ss.source_set() > riscv_softmmu_ss.add(files( > + 'arch_dump.c', > 'pmp.c', > 'monitor.c', > 'machine.c' > -- > 2.19.1 > >