From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F172BC76188 for ; Wed, 5 Apr 2023 05:16:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjvUa-0003AI-Ja; Wed, 05 Apr 2023 01:15:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjvUY-00039z-Pb; Wed, 05 Apr 2023 01:15:30 -0400 Received: from mail-vs1-xe2f.google.com ([2607:f8b0:4864:20::e2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjvUW-0002lL-Vg; Wed, 05 Apr 2023 01:15:30 -0400 Received: by mail-vs1-xe2f.google.com with SMTP id h15so30482477vsh.0; Tue, 04 Apr 2023 22:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680671727; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OiyPmmoUmBvB/CFlACpV8CWflUBnE/CrsSRu0K4QrJQ=; b=ZLGF5auUjCLwnLwtrlU6T8ypiNpZWCTbDFG18wOh9Sn1h1ftVCubDg9u0i7prU1zum lgVOcGuyUhQrhkGfa/r5WIyg8x6lr9gnYS/n+d5ApmLKbKkdXfSWRRWdtKjlWwJuWPSe GtuwsEtOFBxSvbTkjHjJLKcS+5oTm9Bqm6aOplkKxkWdkecYEuUOiRWCr+Ir4YDjgXwg HayGI1sSNz5wGh8cRf9PiMNQQsguGTkvgq3rZ89Q4OekXb+Id90k2ska98w4uiWthFtM gdCQ2sZvW+of4jsnWpAeVGBLxbJvY31eXNYwhAV6GmL8sUh401bNncE5ciQJoObTpREU r98A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680671727; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OiyPmmoUmBvB/CFlACpV8CWflUBnE/CrsSRu0K4QrJQ=; b=5X3rkSNjkoVG7nvCmmqEb6nF5pDV+Y7CsY3ByCRHJpJOXRaSXMk+nBr4I7ncMYF7SV yJFVl3+MOGxAT1FugDkT6k7fGsCcn8g7xtwAPOJndJCedU27ARKw1Pdt5q9ZZ+LoX6bs +OjOM4ETulCv+NGGhKbiheb1Gg/ltlRezqDKJ3JrCNP6plQpiwQQiEv+bgjTWZNFqwsa 5qphU2a4NYISnqBzZxgibzquq8i3I8cG3wdU/RCHP5wuYi8sTR5oKMmWT5lPv1VtLsmo kgpnt5EsG8pY9b8MwE6CQWeyEf1I41/gnYjAwFikM+/7lz8Z2PE93O/gLBkJhIz9OrZb EW8g== X-Gm-Message-State: AAQBX9dKYUwXqiBQP0iGZdS4c8Ky8doc1o1gFcPpKA38EFbJfNiALRBK A88TL6x9v7hZYxINqQn0gvv6i+xzEdH1GDOSfow= X-Google-Smtp-Source: AKy350ZRnmvoHB7zk2xCNCxrYzznHDNUOayrIxVPUiuAW79cdqHJIXI7qvHX3oLwamwH1T/KiE9cRJ/lVF9ZwqKqA3g= X-Received: by 2002:a67:c890:0:b0:425:8e57:7bfd with SMTP id v16-20020a67c890000000b004258e577bfdmr3648703vsk.3.1680671727518; Tue, 04 Apr 2023 22:15:27 -0700 (PDT) MIME-Version: 1.0 References: <20230325145348.1208-1-zhiwei_liu@linux.alibaba.com> In-Reply-To: <20230325145348.1208-1-zhiwei_liu@linux.alibaba.com> From: Alistair Francis Date: Wed, 5 Apr 2023 15:15:01 +1000 Message-ID: Subject: Re: [PATCH 1/1] target/riscv: Convert env->virt to a bool env->virt_enabled To: LIU Zhiwei Cc: qemu-devel@nongnu.org, Alistair.Francis@wdc.com, palmer@dabbelt.com, bin.meng@windriver.com, liweiwei@iscas.ac.cn, dbarboza@ventanamicro.com, qemu-riscv@nongnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::e2f; envelope-from=alistair23@gmail.com; helo=mail-vs1-xe2f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sun, Mar 26, 2023 at 12:55=E2=80=AFAM LIU Zhiwei wrote: > > Currently we only use the env->virt to encode the virtual mode enabled > status. Let's make it a bool type. > > Signed-off-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 2 +- > target/riscv/cpu_bits.h | 3 --- > target/riscv/cpu_helper.c | 6 +++--- > target/riscv/machine.c | 6 +++--- > target/riscv/translate.c | 4 ++-- > 5 files changed, 9 insertions(+), 12 deletions(-) > > diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h > index 638e47c75a..3c8041c5a4 100644 > --- a/target/riscv/cpu.h > +++ b/target/riscv/cpu.h > @@ -183,7 +183,7 @@ struct CPUArchState { > #ifndef CONFIG_USER_ONLY > target_ulong priv; > /* This contains QEMU specific information about the virt state. */ > - target_ulong virt; > + bool virt_enabled; > target_ulong geilen; > uint64_t resetvec; > > diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h > index fca7ef0cef..45ddb00aa5 100644 > --- a/target/riscv/cpu_bits.h > +++ b/target/riscv/cpu_bits.h > @@ -607,9 +607,6 @@ typedef enum { > #define PRV_H 2 /* Reserved */ > #define PRV_M 3 > > -/* Virtulisation Register Fields */ > -#define VIRT_ONOFF 1 > - > /* RV32 satp CSR field masks */ > #define SATP32_MODE 0x80000000 > #define SATP32_ASID 0x7fc00000 > diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c > index f88c503cf4..56f4ff9ccc 100644 > --- a/target/riscv/cpu_helper.c > +++ b/target/riscv/cpu_helper.c > @@ -564,7 +564,7 @@ bool riscv_cpu_virt_enabled(CPURISCVState *env) > return false; > } > > - return get_field(env->virt, VIRT_ONOFF); > + return env->virt_enabled; > } > > void riscv_cpu_set_virt_enabled(CPURISCVState *env, bool enable) > @@ -574,11 +574,11 @@ void riscv_cpu_set_virt_enabled(CPURISCVState *env,= bool enable) > } > > /* Flush the TLB on all virt mode changes. */ > - if (get_field(env->virt, VIRT_ONOFF) !=3D enable) { > + if (env->virt_enabled !=3D enable) { > tlb_flush(env_cpu(env)); > } > > - env->virt =3D set_field(env->virt, VIRT_ONOFF, enable); > + env->virt_enabled =3D enable; > > if (enable) { > /* > diff --git a/target/riscv/machine.c b/target/riscv/machine.c > index 9c455931d8..0fb3ddda06 100644 > --- a/target/riscv/machine.c > +++ b/target/riscv/machine.c > @@ -331,8 +331,8 @@ static const VMStateDescription vmstate_pmu_ctr_state= =3D { > > const VMStateDescription vmstate_riscv_cpu =3D { > .name =3D "cpu", > - .version_id =3D 7, > - .minimum_version_id =3D 7, > + .version_id =3D 8, > + .minimum_version_id =3D 8, > .post_load =3D riscv_cpu_post_load, > .fields =3D (VMStateField[]) { > VMSTATE_UINTTL_ARRAY(env.gpr, RISCVCPU, 32), > @@ -352,7 +352,7 @@ const VMStateDescription vmstate_riscv_cpu =3D { > VMSTATE_UINT32(env.misa_mxl_max, RISCVCPU), > VMSTATE_UINT32(env.misa_ext_mask, RISCVCPU), > VMSTATE_UINTTL(env.priv, RISCVCPU), > - VMSTATE_UINTTL(env.virt, RISCVCPU), > + VMSTATE_BOOL(env.virt_enabled, RISCVCPU), > VMSTATE_UINT64(env.resetvec, RISCVCPU), > VMSTATE_UINTTL(env.mhartid, RISCVCPU), > VMSTATE_UINT64(env.mstatus, RISCVCPU), > diff --git a/target/riscv/translate.c b/target/riscv/translate.c > index 0ee8ee147d..c3adf30b54 100644 > --- a/target/riscv/translate.c > +++ b/target/riscv/translate.c > @@ -1255,8 +1255,8 @@ static void riscv_tr_disas_log(const DisasContextBa= se *dcbase, > > fprintf(logfile, "IN: %s\n", lookup_symbol(dcbase->pc_first)); > #ifndef CONFIG_USER_ONLY > - fprintf(logfile, "Priv: "TARGET_FMT_ld"; Virt: "TARGET_FMT_ld"\n", > - env->priv, env->virt); > + fprintf(logfile, "Priv: "TARGET_FMT_ld"; Virt: %d\n", > + env->priv, env->virt_enabled); > #endif > target_disas(logfile, cpu, dcbase->pc_first, dcbase->tb->size); > } > -- > 2.17.1 > >