From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85EDAC432C0 for ; Sun, 1 Dec 2019 19:06:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 529AC20716 for ; Sun, 1 Dec 2019 19:06:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MXB1FgTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 529AC20716 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibUYS-0007bK-Bg for qemu-devel@archiver.kernel.org; Sun, 01 Dec 2019 14:06:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32878) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibUXd-0006ua-JU for qemu-devel@nongnu.org; Sun, 01 Dec 2019 14:05:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibUXc-0006MP-7x for qemu-devel@nongnu.org; Sun, 01 Dec 2019 14:05:57 -0500 Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]:36606) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibUXc-0006Lz-0U for qemu-devel@nongnu.org; Sun, 01 Dec 2019 14:05:56 -0500 Received: by mail-ot1-x32d.google.com with SMTP id i4so2208992otr.3 for ; Sun, 01 Dec 2019 11:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TfmpNXxNvPwjtOK/DaubXvcgr95XTIaAEhlOC2uFdkk=; b=MXB1FgTkyzjBvhV660KsAvDgqVvJqWZ0+n40rGSVBBRQe/q1xHf+FwpymNDJvoxxag YtHUfFjpho5kWdYSNUR+djdxxQp+0ogJlY7ZBTk2cG5uixC87FWZ5yvmSexZno7VJ2gI RE+luUek5F8txN8e26RiWFF23+XGiyiV8yupjK44ERE9FRxawEDow8rVC3H6c/PXDIBb +sx8oE5FZxz3F1V+QBNJXLyq60Y3iMc7E6kSI00mjOgwGECrlhPI1Rt/FG/QXd7Yvurj QDD551e9pqq2lt3yVYI2o5EV9q/ZdbpxvymuHaWxdgonJ2DDUULIeWcKw0qKVbyl8ri8 Auow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TfmpNXxNvPwjtOK/DaubXvcgr95XTIaAEhlOC2uFdkk=; b=dnlBpR2l5D3YfwEkGQGxOxyouZOd2aSj3vHTPop9VhNxzRAnjI/Q9nEDeFBOilXzLb Si2RuhitRSfA8qoclWSjkhwY9XLcHbLmOZo4zQbH5BvB+EY+eQB4Fh0yYIMipH4dHmx6 a9oEVYb3mQUGwdd/iJ39wsk5Qx6/fTnZDxuuk7ruhMGH13SXgV4UDtKSR5RErK4rcKTE p+zXoYFsJliuuoEKhjB+lAgZvPZcmygaIu7K7CGjCqIkXEwsFqfj2SLJrV2rUAc8+8RA 1QSKPQtfAT8XXTZxhwB1rrHCPoaCGLW6eim1BaLZbrNkvn0iDmYh+WVdwILpmVcGc+De FfnA== X-Gm-Message-State: APjAAAWcIkGXCGycBDQCurj2B5IP/cca3Nmi6F8i6jG09ijmW9Bh6IIk fescBgfT3F5nAeRTHrt2Ac0vq/WY21X/bz7cgLg= X-Google-Smtp-Source: APXvYqwgNdd5BoVCR9XWX2UYq9rJ2MqHBvZ/yrDedJzhQmoIP3ve73etONF/5V2/zjwAU6t4QH6b1fpfk7AiptObOQo= X-Received: by 2002:a9d:3d05:: with SMTP id a5mr19950094otc.295.1575227155168; Sun, 01 Dec 2019 11:05:55 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:6830:1391:0:0:0:0 with HTTP; Sun, 1 Dec 2019 11:05:54 -0800 (PST) In-Reply-To: References: <20191120152442.26657-1-marcandre.lureau@redhat.com> From: Aleksandar Markovic Date: Sun, 1 Dec 2019 20:05:54 +0100 Message-ID: Subject: Re: [PATCH v6 00/37] Clean-ups: qom-ify serial and remove QDEV_PROP_PTR To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Content-Type: multipart/alternative; boundary="00000000000006437d0598a92797" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::32d X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , QEMU Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000006437d0598a92797 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sunday, December 1, 2019, Marc-Andr=C3=A9 Lureau wrote: > Hi Aleksandar > > On Sun, Dec 1, 2019 at 4:15 PM Aleksandar Markovic > wrote: > > > > > > > > On Sunday, December 1, 2019, Marc-Andr=C3=A9 Lureau < > marcandre.lureau@gmail.com> wrote: > > > >> > >> - "RFC: mips/cps: fix setting saar property" > >> > >> Perhaps I should have used FIX instead of RFC, because this should > >> actually be a real fix. However I could use someone help to exercise > >> the code path. > >> > > > > Marc-Andr=C3=A9, hi. > > > > There is a work in progress on fixing this. Can we in MIPS submit the > fix independently, since it involves some additional pieces of code that > are really deeply mips-specific? We acknowledge the bug, and want to > develop the real solution. Can you simply skip this RFC patch in your > series, since the issues will be handled separately in our patch, hopeful= ly > soon after the merge window is open? > > > > For all other mips parts of your series, you have my "reviewed-by"s , i= n > case I forgot to send them explicitely. > > > > This is a one-liner, and it is required to achieve the goal of the > series, to remove PROP_PTR. > > If you prefer, I can instead comment the line with a FIXME, since it > is apparently broken anyway? > > If you manage to get your fix merged earlier, then this patch can be > dropped. Else, is it a problem for the later fixes? > > OK, Marc-Andr=C3=A9, Please go ahead with this patch, so that the goal of the series is achieved, and we will later submitt a wider patch that will address the root cause. Just remove RFC from subject, everything else looks fine to me. You can add my "reviewed-by". Yours, Aleksandar > thanks > > > -- > Marc-Andr=C3=A9 Lureau > --00000000000006437d0598a92797 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Sunday, December 1, 2019, Marc-Andr=C3=A9 Lureau <marcandre.lureau@gmail.com> wrote= :
Hi Aleksandar

On Sun, Dec 1, 2019 at 4:15 PM Aleksandar Markovic
<aleksandar.m.mail@gmail.= com> wrote:
>
>
>
> On Sunday, December 1, 2019, Marc-Andr=C3=A9 Lureau <marcandre.lureau@gmail.com> wrote: >
>>
>> - "RFC: mips/cps: fix setting saar property"
>>
>> Perhaps I should have used FIX instead of RFC, because this should=
>> actually be a real fix. However I could use someone help to exerci= se
>> the code path.
>>
>
> Marc-Andr=C3=A9, hi.
>
> There is a work in progress on fixing this. Can we in MIPS submit the = fix independently, since it involves some additional pieces of code that ar= e really deeply mips-specific? We acknowledge the bug, and want to develop = the real solution. Can you simply skip this RFC patch in your series, since= the issues will be handled separately in our patch, hopefully soon after t= he merge window is open?
>
> For all other mips parts of your series, you have my "reviewed-by= "s , in case I forgot to send them explicitely.
>

This is a one-liner, and it is required to achieve the goal of the
series, to remove PROP_PTR.

If you prefer, I can instead comment the line with a FIXME, since it
is apparently broken anyway?

If you manage to get your fix merged earlier, then this patch can be
dropped. Else, is it a problem for the later fixes?


OK, Marc-Andr=C3=A9,

Please go ahead with this patch, so that the goal of the series is = achieved, and we will later submitt a wider patch that will address the roo= t cause. Just remove RFC from subject, everything else looks fine to me. Yo= u can add my "reviewed-by".

Yours, Aleks= andar


=C2=A0
thanks


--
Marc-Andr=C3=A9 Lureau
--00000000000006437d0598a92797--