From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: Libo Zhou <zhlb29@foxmail.com>,
arikalo@wavecomp.com, qemu-devel@nongnu.org,
amarkovic@wavecomp.com
Subject: Re: [Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373
Date: Wed, 11 Sep 2019 16:20:53 +0200 [thread overview]
Message-ID: <CAL1e-=hS=qed_Kn-Qq1wpL4FL2bU7Gm7n3OfHkoh+xiMx6dxug@mail.gmail.com> (raw)
In-Reply-To: <1568207966-25202-1-git-send-email-aleksandar.markovic@rt-rk.com>
11.09.2019. 15.21, "Aleksandar Markovic" <aleksandar.markovic@rt-rk.com> је
написао/ла:
>
> From: Libo Zhou <zhlb29@foxmail.com>
>
> Multiple report from users were received regarding failures
> of "packet g" comminucation with gdb. Revert this commit until
> a better solution is developed.
>
> Suggested-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> Signed-off-by: Libo Zhou <zhlb29@foxmail.com>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> target/mips/gdbstub.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/mips/gdbstub.c b/target/mips/gdbstub.c
> index ebcc98b..bbb2544 100644
> --- a/target/mips/gdbstub.c
> +++ b/target/mips/gdbstub.c
> @@ -38,7 +38,7 @@ int mips_cpu_gdb_read_register(CPUState *cs, uint8_t
*mem_buf, int n)
> return gdb_get_regl(mem_buf, (int32_t)env->active_fpu.fcr0);
> default:
> if (env->CP0_Status & (1 << CP0St_FR)) {
> - return gdb_get_reg64(mem_buf,
> + return gdb_get_regl(mem_buf,
> env->active_fpu.fpr[n - 38].d);
> } else {
> return gdb_get_regl(mem_buf,
> @@ -99,7 +99,6 @@ int mips_cpu_gdb_write_register(CPUState *cs, uint8_t
*mem_buf, int n)
> break;
> default:
> if (env->CP0_Status & (1 << CP0St_FR)) {
> - uint64_t tmp = ldq_p(mem_buf);
> env->active_fpu.fpr[n - 38].d = tmp;
> } else {
> env->active_fpu.fpr[n - 38].w[FP_ENDIAN_IDX] = tmp;
> --
> 2.7.4
>
>
prev parent reply other threads:[~2019-09-11 14:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 13:19 [Qemu-devel] [PATCH] target/mips: gdbstub: Revert commit 8e0b373 Aleksandar Markovic
2019-09-11 14:20 ` Aleksandar Markovic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1e-=hS=qed_Kn-Qq1wpL4FL2bU7Gm7n3OfHkoh+xiMx6dxug@mail.gmail.com' \
--to=aleksandar.m.mail@gmail.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=qemu-devel@nongnu.org \
--cc=zhlb29@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).