From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9BB9C432C0 for ; Wed, 20 Nov 2019 20:44:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8078520726 for ; Wed, 20 Nov 2019 20:44:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JYafPBcl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8078520726 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXWqQ-0003UR-NT for qemu-devel@archiver.kernel.org; Wed, 20 Nov 2019 15:44:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32844) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXWpk-00034R-N1 for qemu-devel@nongnu.org; Wed, 20 Nov 2019 15:44:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXWpj-0004cd-K1 for qemu-devel@nongnu.org; Wed, 20 Nov 2019 15:44:16 -0500 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:45197) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXWpj-0004bG-As for qemu-devel@nongnu.org; Wed, 20 Nov 2019 15:44:15 -0500 Received: by mail-oi1-x243.google.com with SMTP id 14so1021710oir.12 for ; Wed, 20 Nov 2019 12:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IrGzEhAVokXnY9mIl3c/73d3PZaToiauaqRJgmslU10=; b=JYafPBclM/iF+0ngyf4kctWg+n4qXMDU57nG+BLhUC42ap5eCznM3B8cX7SxVsOgj3 Df7gaaciXQOwEnqOePx0Ls90gQUH0EamCZkAYR6jULqBGbivOXvXeL/s3KPkZ1cDiYVK Ppyi/ru7Tkq1EYRrS9zKruSaqOTzBMbHqnPpg4hQqOiTVTwuCXH741GXuNUjapgJ+Kd2 QeT93Xj2N40QFVCGkTz0Vkf6OgYdQ5a/br/3+Ikt+Rct2gEBZRKWuHJGnthhojqV6mQn UGe6BWKgdFaI1QUYpj6jw9n4eTO1tokGHuwTZ0YfperJD3KmsTuMh1T4T8pSGfxgjMf5 A0wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IrGzEhAVokXnY9mIl3c/73d3PZaToiauaqRJgmslU10=; b=cvkLDGc/++yP1BbF9o2FZKjklH/r396arJk+bjUq3Ul6nSc+NiGYSy0vnsJdKARPUk PJDd+vb4OHaGZNKsAk4EQkDY+YZ/yJZ0SiS2VDxATbaT4WSswtm8ji85xfbdUqNxErPH yHNJwmraFvjX3iu8MHXKYRPV5qQLeBYzrlFbuogwDDbSBeF3RosVTKfPnMLeYUbEpjK9 WKfhzAo21owiF8MJgc/m0r5jQ4YwaF4u/NSJo1KgGEG4LNvdvVCLpPJaKLynGf5gzGFj WqVhhlQjAyjhbMaqn7NeooM5sb0R01d0P3/3hqThnbIUBNQFBQsvJG2UuDjl+9lOGAvL gTXw== X-Gm-Message-State: APjAAAU0n1BZ3ENVL+LDRp6JiftIgWdNIrRI7qWn44QM/gRPhjBV1qCn J9qCK5E/0Ab4w2BsWbseRYuY/W3nLus/RPf1h6o= X-Google-Smtp-Source: APXvYqxbL4TLuBpjJUT8hN7z3BpYAxbsTucD81xtsOSEvHx13VdMt4BVmH/buiGR4hbjduBNJC+l/yGGQuZwJ657ZXI= X-Received: by 2002:aca:670b:: with SMTP id z11mr4303911oix.79.1574282654378; Wed, 20 Nov 2019 12:44:14 -0800 (PST) MIME-Version: 1.0 References: <20191119190405.GA23854@ls3530.fritz.box> In-Reply-To: <20191119190405.GA23854@ls3530.fritz.box> From: Aleksandar Markovic Date: Wed, 20 Nov 2019 21:44:03 +0100 Message-ID: Subject: Re: [PATCH] linux-user/strace: Improve output of various syscalls To: Helge Deller Content-Type: text/plain; charset="UTF-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::243 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" > @@ -26,7 +26,7 @@ > { TARGET_NR_afs_syscall, "afs_syscall" , NULL, NULL, NULL }, > #endif > #ifdef TARGET_NR_alarm > -{ TARGET_NR_alarm, "alarm" , NULL, NULL, NULL }, > +{ TARGET_NR_alarm, "alarm" , "%s(%d)", NULL, NULL }, > #endif Man page says: unsigned int alarm(unsigned int seconds) The sole argument is unsigned int - therefore "%d" should be "%u", shouldn't it? -------------------------------------------------- This is not a part of your changes, but appeared in your patch diff: > #ifdef TARGET_NR_epoll_create > { TARGET_NR_epoll_create, "epoll_create" , NULL, NULL, NULL }, >From man pages: int epoll_create(int size); So, this also belongs to the category "has only int-type parameter,' and "%s(%d)" should be used, no? --------------------------------------------------- > #ifdef TARGET_NR_setresgid > -{ TARGET_NR_setresgid, "setresgid" , NULL, NULL, NULL }, > +{ TARGET_NR_setresgid, "setresgid" , "%s(%u,%u,%u)", NULL, NULL }, > #endif > #ifdef TARGET_NR_setresgid32 > { TARGET_NR_setresgid32, "setresgid32" , NULL, NULL, NULL }, > #endif Why are you here correcting setresgid(), but leaving setresgid32() intact, even though they have the same argument type pattern? -------------------------------------------------- I have these objections, however, in general, I salute the patch, and your efforts to improve QEMU linux-user strace, it is a quite useful debug tool, and thanks for doing this! :) Yours, Aleksandar