Re: [PATCH v2 07/30] qapi/block-core.json: Use literal block for ascii art

[Aleksandar Markovic <aleksandar.m.mail@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1959 bytes --]

6:59 PM Čet, 13.02.2020. Peter Maydell <peter.maydell@linaro.org> је
написао/ла:
>
> The ascii-art graph

Just out of couriousity, are unicode characters allowed in rst files?

The boxes could've been rendered in a much more beautifull way using "lines
and corners" group of unicode characters.

Aleksandar

> in the BlockLatencyHistogramInfo documentation
> doesn't render correctly, because the whitespace is collapsed.
>
> Use the '|' format that emits a literal 'example' block so the graph
> is displayed correctly.
>
> Strictly the texinfo generated is still wrong because each line
> goes into its own @example environment, but it renders better
> than what we had before.
>
> Fixing this rendering is a necessary prerequisite for the rST
> generator, which otherwise complains about the inconsistent
> indentation in the ascii-art graph.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> v1->v2: tweaked commit message, made graph still line up
> with preceding paragraph text
> ---
>  qapi/block-core.json | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ef94a296868..db9ca688d49 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -550,13 +550,13 @@
>  #        For the example above, @bins may be something like [3, 1, 5, 2],
>  #        and corresponding histogram looks like:
>  #
> -#        5|           *
> -#        4|           *
> -#        3| *         *
> -#        2| *         *    *
> -#        1| *    *    *    *
> -#         +------------------
> -#             10   50   100
> +# |      5|           *
> +# |      4|           *
> +# |      3| *         *
> +# |      2| *         *    *
> +# |      1| *    *    *    *
> +# |       +------------------
> +# |           10   50   100
>  #
>  # Since: 4.0
>  ##
> --
> 2.20.1
>
>

[-- Attachment #2: Type: text/html, Size: 2709 bytes --]