From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean')
Date: Sat, 13 Jun 2020 18:28:55 +0200 [thread overview]
Message-ID: <CAL1e-=ijjbTG19NHnsDrcJdb7kajBdcndMT8JXymqC6UViiitQ@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA_+V7SNsxPSgsd04s8f7PnP3qdyXMp6NvS2inHjE08pJw@mail.gmail.com>
On Tue, Oct 8, 2019 at 2:41 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 8 Oct 2019 at 13:37, Thomas Huth <thuth@redhat.com> wrote:
> >
> > On 08/10/2019 14.18, Aleksandar Markovic wrote:
> > > If I remember well, QAPI-related c files are generated while doing
> > > 'make'. If that is true, these files should be deleted by 'make clean',
> > > shouldn't they?
> >
> > I think that's a philosophical question. Should "make clean" delete all
> > files that have been generated by a Makefile (i.e. not by "configure"),
> > or rather mainly the binary files?
>
> https://www.gnu.org/software/automake/manual/html_node/Clean.html
>
> The autoconf manual suggests some heuristics:
> - If make built it, and it is commonly something that one would want
> to rebuild (for instance, a .o file), then mostlyclean should delete it.
> - Otherwise, if make built it, then clean should delete it.
> - If configure built it, then distclean should delete it.
> - If the maintainer built it (for instance, a .info file), then
> maintainer-clean should delete it. However maintainer-clean should
> not delete anything that needs to exist in order to run
> './configure && make'.
>
Thomas, can we reincarnate this patch? It needs only fairly simple
corrections, as said by Peter above. It would be nice to have at least
one release of QEMU with clean clean and distclean.
Yours,
Aleksandar
> Not all of that applies for QEMU, but it seems like a reasonable
> set of ideas.
>
> thanks
> -- PMM
next prev parent reply other threads:[~2020-06-13 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 8:28 [PATCH v2] Makefile: Remove generated files when doing 'distclean' (and 'clean') Thomas Huth
2019-10-08 12:18 ` Aleksandar Markovic
2019-10-08 12:35 ` Thomas Huth
2019-10-08 12:41 ` Peter Maydell
2019-10-08 16:04 ` Paolo Bonzini
2020-06-13 16:28 ` Aleksandar Markovic [this message]
2020-06-15 5:17 ` Thomas Huth
2020-06-15 7:13 ` Paolo Bonzini
2020-06-15 7:46 ` Thomas Huth
2020-06-15 19:46 ` Markus Armbruster
2019-10-08 12:41 ` Daniel P. Berrangé
2019-10-08 13:34 ` Thomas Huth
2019-10-08 18:19 ` Markus Armbruster
2019-10-22 20:35 ` Aleksandar Markovic
2019-10-23 7:09 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1e-=ijjbTG19NHnsDrcJdb7kajBdcndMT8JXymqC6UViiitQ@mail.gmail.com' \
--to=aleksandar.m.mail@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).