From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EE44C43603 for ; Fri, 6 Dec 2019 19:48:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 479AB2173E for ; Fri, 6 Dec 2019 19:48:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A9ViOK57" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 479AB2173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idJaA-0006bM-6X for qemu-devel@archiver.kernel.org; Fri, 06 Dec 2019 14:48:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37392) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idJXP-0004sT-UA for qemu-devel@nongnu.org; Fri, 06 Dec 2019 14:45:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idJXM-000486-Pa for qemu-devel@nongnu.org; Fri, 06 Dec 2019 14:45:15 -0500 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:43497) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idJXM-00043F-EV for qemu-devel@nongnu.org; Fri, 06 Dec 2019 14:45:12 -0500 Received: by mail-oi1-x244.google.com with SMTP id x14so815086oic.10 for ; Fri, 06 Dec 2019 11:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=QSaNj2Lhi/Pf6b/lhRBaRaqnfm0JhCGnT3WsksvDWUM=; b=A9ViOK57oK1faRr4Qku07tWDGoLSytgv/84N7n7qNJ6ZPnkp7OmIdnjmYeTAMkKc+7 7hT9PFTIuWKyYz+yu69RpzONgOM4VaEYXUiX4lgG3ABGl8ME11aFpHLTeKXX2Sh2vsTP mV5DJ8/jbLnesgXODOV9v+uoT/WK36u+rrvudNUn9WubtfzLof5HHNam8x5m8F3dDqtP 3DmIcqrIbtgGJrrzCTWbFgZ0OTaYFosXixAwEGd6nr7QQCRtpCUdZkm8LhpLk5U3g6HW aqsO5H8RPLml7HJ1PlbRT+9tm7eSV6slxfeWCxAQHo0Bo/ZH2jDZUEBlrT3dbhQxKGys zZsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=QSaNj2Lhi/Pf6b/lhRBaRaqnfm0JhCGnT3WsksvDWUM=; b=uZWLG8qVsXmYYR50j1shuiz291VJtKat7fimwewwDl0q1tzQPAYILcyHjeid7YtgJn e8KtUj/Vx1oSP+t0ycwzuGdu+dqfAvsAvSwZjb8gIGwDsj9lvLZ++hF9v+NDaYUhwVWG n1H7ChVx6T7Weo25cE4+4QmSOWs5yX6m057PFDgLRGSWQEhRkjYWt2MPZzh7asDjT4DM 2NJcprAVGOYbPJWXHfLWGWpgiZvM3MeoDw2tgEEY9bjbkK/RKeJp/A0KiXW6oajcKDGa tbJg1RS1wlaK0vwLxbXeUnfji8ZjGqsWp3n166xnv/kGxXN8CdRqa6qEzRezUZWFufpd J1KQ== X-Gm-Message-State: APjAAAWqRgzX2ahTBn9me+Ouzq703asmW8Hr9eQ2MsQsUrKyh0YOD4xq f1o9tzjWiB4ReJkTauplzuVC5QGJHvbvoywKwL8= X-Google-Smtp-Source: APXvYqwp5UbX43ZCC8BJC9SmnG4htplYJmnZv3d7cgAw7PIOs8pMtYH8li7jUx6N90c2PwMD67SbxQ+ElBh9UOF76JU= X-Received: by 2002:a05:6808:64e:: with SMTP id z14mr12934230oih.79.1575661511356; Fri, 06 Dec 2019 11:45:11 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a9d:d21:0:0:0:0:0 with HTTP; Fri, 6 Dec 2019 11:45:10 -0800 (PST) In-Reply-To: <64460769-1e63-ab16-c58f-79f5f848f3ff@redhat.com> References: <1566216496-17375-1-git-send-email-aleksandar.markovic@rt-rk.com> <1566216496-17375-16-git-send-email-aleksandar.markovic@rt-rk.com> <64460769-1e63-ab16-c58f-79f5f848f3ff@redhat.com> From: Aleksandar Markovic Date: Fri, 6 Dec 2019 20:45:10 +0100 Message-ID: Subject: Re: [Qemu-devel] [PATCH v8 15/37] target/mips: Style improvements in mips_malta.c To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000abb3e605990e4858" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::244 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Markovic , Aleksandar Rikalo , qemu-devel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000abb3e605990e4858 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Friday, December 6, 2019, Philippe Mathieu-Daud=C3=A9 wrote: > Hi Aleksandar, > > On 8/19/19 4:47 PM, Aleksandar Rikalo wrote: > >> From: Aleksandar Markovic >> > Sent: Monday, August 19, 2019 2:07 PM >> > To: qemu-devel@nongnu.org >> > Cc: philmd@redhat.com ; Aleksandar Markovic < >> amarkovic@wavecomp.com>; Aleksandar Rikalo >> > Subject: [EXTERNAL][PATCH v8 15/37] target/mips: Style improvements i= n >> mips_malta.c >> > >> > From: Aleksandar Markovic >> > >> > Fixes mostly errors and warnings reported by 'checkpatch.pl -f'. >> > >> > Signed-off-by: Aleksandar Markovic >> > --- >> > hw/mips/mips_malta.c | 216 ++++++++++++++++++++++++++++++ >> --------------------- >> > 1 file changed, 128 insertions(+), 88 deletions(-) >> > >> > diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c >> > [...]> > @@ -347,7 +362,8 @@ static uint64_t malta_fpga_read(void *opaqu= e, > >> hwaddr addr, >> > >> > /* SWITCH Register */ >> > case 0x00200: >> > - val =3D 0x00000000; /* All switches closed */ >> > + /* ori a3, a3, low(ram_low_size) */ >> > > I'm not sure what happened here, this change is incorrect. > > You are right, a strange case of a stray comment. Do you want to send a patch-correction? So that I can select it for the first mips queue... Thanks for spotting it! Aleksandar > + val =3D 0x00000000; >> > break; >> > >> > /* STATUS Register */ >> > @@ -386,10 +402,11 @@ static uint64_t malta_fpga_read(void *opaque, >> hwaddr addr, >> > /* GPINP Register */ >> > case 0x00a08: >> > /* IN =3D OUT until a real I2C control is implemented */ >> > - if (s->i2csel) >> > + if (s->i2csel) { >> > val =3D s->i2cout; >> > - else >> > + } else { >> > val =3D 0x00; >> > + } >> > break; >> > >> > [...] > >> >> Reviewed-by: Aleksandar Rikalo >> >> > > --000000000000abb3e605990e4858 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Friday, December 6, 2019, Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com> wrote:
Hi Aleksandar,

On 8/19/19 4:47 PM, Aleksandar Rikalo wrote:
From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
=C2=A0> Sent: Monday, August 19, 2019 2:07 PM
=C2=A0> To: q= emu-devel@nongnu.org <qemu-devel@nongnu.org>
=C2=A0> Cc: philm= d@redhat.com <philmd@redhat.com>; Aleksandar Markovic <amarkovic@wavecomp.com>; Aleksa= ndar Rikalo <a= rikalo@wavecomp.com>
=C2=A0> Subject: [EXTERNAL][PATCH v8 15/37] target/mips: Style improveme= nts in mips_malta.c
=C2=A0>
=C2=A0> From: Aleksandar Markovic <amarkovic@wavecomp.com>
=C2=A0>
=C2=A0> Fixes mostly errors and warnings reported by 'checkpatch.pl -f'.
=C2=A0>
=C2=A0> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
=C2=A0> ---
=C2=A0>=C2=A0 hw/mips/mips_malta.c | 216 ++++++++++++++++++++++++++++++<= wbr>---------------------
=C2=A0>=C2=A0 1 file changed, 128 insertions(+), 88 deletions(-)
=C2=A0>
=C2=A0> diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c
[...]>=C2=A0 > @@ -347,7 +362,8 @@ static uint64_t malta_fpga_read(vo= id *opaque,
hwaddr addr,
=C2=A0>
=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* SWITCH Register */
=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case 0x00200:
=C2=A0> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 val =3D 0x00000000;= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 /* All switches closed */
=C2=A0> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* ori a3, a3, low(r= am_low_size) */

I'm not sure what happened here, this change is incorrect.


You are right, a strange case of a str= ay comment.

Do you want to send a patch-correction= ? So that I can select it for the first mips queue...

<= div>Thanks for spotting it!
Aleksandar

=C2=A0> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 val =3D 0x00000000;<= br> =C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break;
=C2=A0>
=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* STATUS Register */
=C2=A0> @@ -386,10 +402,11 @@ static uint64_t malta_fpga_read(void *opaq= ue, hwaddr addr,
=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* GPINP Register */
=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case 0x00a08:
=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* IN =3D = OUT until a real I2C control is implemented */
=C2=A0> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (s->i2csel) =C2=A0> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (s->i2csel) {<= br> =C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 val =3D s->i2cout;
=C2=A0> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 else
=C2=A0> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } else {
=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 val =3D 0x00;
=C2=A0> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break;
=C2=A0>
[...]

Reviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>



--000000000000abb3e605990e4858--