Re: [PATCH 2/5] mips: malta: Renovate coding style

[Aleksandar Markovic <aleksandar.m.mail@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]

On Monday, November 25, 2019, Filip Bozuta <Filip.Bozuta@rt-rk.com> wrote:

> The script checkpatch.pl located in scripts folder was
> used to detect all errors and warrnings in files:
>     hw/mips/mips_malta.c
>     hw/mips/gt64xxx_pci.c
>     tests/acceptance/linux_ssh_mips_malta.py
>
> All these mips malta machine files were edited and
> all the errors and warrings generated by the checkpatch.pl
> script were corrected and then the script was
> ran again to make sure there are no more errors and warnings.
>
> Signed-off-by: Filip Bozuta <Filip.Bozuta@rt-rk.com>
> ---
>  hw/mips/mips_malta.c                     | 139
> ++++++++++++++++---------------
>  tests/acceptance/linux_ssh_mips_malta.py |   6 +-
>  2 files changed, 75 insertions(+), 70 deletions(-)
>
>
Very good cleanup!

Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>

I think this snippet is good, but I am just in case cc-ing Cleber and
Eduardo to check if it is in accordance with any applicable guidelines of
our test framework:


> diff --git a/tests/acceptance/linux_ssh_mips_malta.py
> b/tests/acceptance/linux_ssh_mips_malta.py
> index fc13f9e..44e1118 100644
> --- a/tests/acceptance/linux_ssh_mips_malta.py
> +++ b/tests/acceptance/linux_ssh_mips_malta.py
> @@ -99,10 +99,12 @@ class LinuxSSH(Test):
>      def ssh_command(self, command, is_root=True):
>          self.ssh_logger.info(command)
>          result = self.ssh_session.cmd(command)
> -        stdout_lines = [line.rstrip() for line in
> result.stdout_text.splitlines()]
> +        stdout_lines = [line.rstrip() for line
> +        in result.stdout_text.splitlines()]
>          for line in stdout_lines:
>              self.ssh_logger.info(line)
> -        stderr_lines = [line.rstrip() for line in
> result.stderr_text.splitlines()]
> +        stderr_lines = [line.rstrip() for line
> +        in result.stderr_text.splitlines()]
>          for line in stderr_lines:
>              self.ssh_logger.warning(line)
>          return stdout_lines, stderr_lines
> --
> 2.7.4
>
>
>

[-- Attachment #2: Type: text/html, Size: 3393 bytes --]