From: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: "Lukáš Doktor" <ldoktor@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
"Cleber Rosa" <crosa@redhat.com>,
luoyonggang@gmail.com, "Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH 1/1] scripts/performance: Add dissect.py script
Date: Wed, 1 Jul 2020 15:48:48 +0200 [thread overview]
Message-ID: <CALTWKrV-ho8VXA3dGFXYeiHeQzvN4bzrgbdJ3Woe9SuS4Fg1=A@mail.gmail.com> (raw)
In-Reply-To: <06a0026e-f7cc-9a15-bc0e-d6c6c4846caf@redhat.com>
On Wed, Jul 1, 2020 at 3:41 PM Eric Blake <eblake@redhat.com> wrote:
>
> On 7/1/20 8:04 AM, Ahmed Karaman wrote:
> > Python script that dissects QEMU execution into three main phases:
> > code generation, JIT execution and helpers execution.
> >
> > Syntax:
> > dissect.py [-h] -- <qemu executable> [<qemu executable options>] \
> > <target executable> [<target executable options>]
> >
> > [-h] - Print the script arguments help message.
> >
> > Example of usage:
> > dissect.py -- qemu-arm coulomb_double-arm
>
> Given the example usage...
>
> >
> > Example output:
> > Total Instructions: 4,702,865,362
> >
> > Code Generation: 115,819,309 2.463%
> > JIT Execution: 1,081,980,528 23.007%
> > Helpers: 3,505,065,525 74.530%
> >
> > Signed-off-by: Ahmed Karaman <ahmedkhaledkaraman@gmail.com>
> > ---
> > scripts/performance/dissect.py | 165 +++++++++++++++++++++++++++++++++
> > 1 file changed, 165 insertions(+)
> > create mode 100644 scripts/performance/dissect.py
> >
> > diff --git a/scripts/performance/dissect.py b/scripts/performance/dissect.py
> > new file mode 100644
>
> ...this should have the executable bit set.
Thanks Mr. Eric, I don't know why I always forget doing this before
sending the patch. Will do it in V2.
>
>
> > +def get_JIT_line(callgrind_data):
> > + """
> > + Search for the first instance of the JIT call in
> > + the callgrind_annoutate output when ran using --tree=caller
>
> annotate
Thanks.
>
> > + This is equivalent to the self number of instructions of JIT.
> > +
> > + Parameters:
> > + callgrind_data (list): callgrind_annotate output
> > +
> > + Returns:
> > + (int): Line number
> > + """
> > + line = -1
> > + for i in range(len(callgrind_data)):
> > + if callgrind_data[i].strip('\n') and \
> > + callgrind_data[i].split()[-1] == "[???]":
> > + line = i
> > + break
> > + if line == -1:
> > + sys.exit("Couldn't locate the JIT call ... Exiting!")
>
> We tend to avoid ! at the end of error messages (it can come across as
> shouting at the user).
Yeah right, Will remove the exclamations.
>
> > + return line
> > +
> > +
> > +def main():
> > + # Parse the command line arguments
> > + parser = argparse.ArgumentParser(
> > + usage='dissect.py [-h] -- '
> > + '<qemu executable> [<qemu executable options>] '
> > + '<target executable> [<target executable options>]')
> > +
> > + parser.add_argument('command', type=str, nargs='+', help=argparse.SUPPRESS)
> > +
> > + args = parser.parse_args()
> > +
> > + # Extract the needed variables from the args
> > + command = args.command
> > +
> > + # Insure that valgrind is installed
> > + check_valgrind = subprocess.run(
> > + ["which", "valgrind"], stdout=subprocess.DEVNULL)
> > + if check_valgrind.returncode:
> > + sys.exit("Please install valgrind before running the script!")
>
> and again
Noted.
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
>
Thanks for your feedback Mr. Eric.
Best regards,
Ahmed Karaman
prev parent reply other threads:[~2020-07-01 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 13:04 [PATCH 0/1] Add Script for Dissecting QEMU Execution Ahmed Karaman
2020-07-01 13:04 ` [PATCH 1/1] scripts/performance: Add dissect.py script Ahmed Karaman
2020-07-01 13:40 ` Eric Blake
2020-07-01 13:48 ` Ahmed Karaman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALTWKrV-ho8VXA3dGFXYeiHeQzvN4bzrgbdJ3Woe9SuS4Fg1=A@mail.gmail.com' \
--to=ahmedkhaledkaraman@gmail.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=ldoktor@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).