From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B870C433E0 for ; Mon, 1 Mar 2021 16:28:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7201564F82 for ; Mon, 1 Mar 2021 16:28:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7201564F82 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGlOt-0000qQ-Cx for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 11:28:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGlNr-0008Ki-Iq for qemu-devel@nongnu.org; Mon, 01 Mar 2021 11:26:59 -0500 Received: from rev.ng ([5.9.113.41]:57409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGlNp-0008O1-KN for qemu-devel@nongnu.org; Mon, 01 Mar 2021 11:26:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=16gKclkrkkCnijO3zyRk899JnPYPqMyKvxbOyfLBaTE=; b=cifcHoB3/5CoHM098X2EzRekFQ aoH4kCSKVdRq0Umbl+l15CfMfjiiCjmlpTp227oICIqAvaRFzhL7EtG2CvCMDqJxUiUPlvvTKxpwG VI6og7oRicqzDjeJ/zBHwNjWQHO0+nSNwFAAZn+hsR7oyHkQ4GiM3BZal+ErmFqGx4b8=; Received: by mail-vs1-f49.google.com with SMTP id k12so3037587vso.13 for ; Mon, 01 Mar 2021 08:26:48 -0800 (PST) X-Gm-Message-State: AOAM532yAM/k2akaYNLvphm7CwF3MpA0WRosAwqovPoqJwm1sGMLGb84 /PXRiUHpvLsWkLK45yeyL/obUuxYwhe9XufWFA== X-Google-Smtp-Source: ABdhPJwmaGMc1A9jNTx2DGKBjJmtafZ5ZzpBQ2jR+FxPP75v8PwxEQP51bBJaCwkHEx/OCrbFf362+bONte2IjZh10c= X-Received: by 2002:a05:6102:c10:: with SMTP id x16mr3775150vss.54.1614616002815; Mon, 01 Mar 2021 08:26:42 -0800 (PST) MIME-Version: 1.0 References: <20210225151856.3284701-1-ale.qemu@rev.ng> <20210225151856.3284701-7-ale.qemu@rev.ng> In-Reply-To: Date: Mon, 1 Mar 2021 17:26:31 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 06/10] target/hexagon: prepare input for the idef-parser To: Richard Henderson Cc: Alessandro Di Federico , qemu-devel@nongnu.org, Taylor Simpson , Brian Cain , nizzo@rev.ng, philmd@redhat.com, Alessandro Di Federico Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=5.9.113.41; envelope-from=babush@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: Paolo Montesel From: Paolo Montesel via > > +/* Copy rules */ > > +#define fLSBOLD(VAL) (fGETBIT(0, VAL)) > > +#define fSATH(VAL) fSATN(16, VAL) > > +#define fSATUH(VAL) fSATUN(16, VAL) > > +#define fVSATH(VAL) fVSATN(16, VAL) > > +#define fVSATUH(VAL) fVSATUN(16, VAL) > > +#define fSATUB(VAL) fSATUN(8, VAL) > > +#define fSATB(VAL) fSATN(8, VAL) > > +#define fVSATUB(VAL) fVSATUN(8, VAL) > > +#define fVSATB(VAL) fVSATN(8, VAL) > > +#define fCALL(A) fWRITE_LR(fREAD_NPC()); fWRITE_NPC(A); > > +#define fCALLR(A) fWRITE_LR(fREAD_NPC()); fWRITE_NPC(A); > > +#define fCAST2_8s(A) fSXTN(16, 64, A) > > +#define fCAST2_8u(A) fZXTN(16, 64, A) > > +#define fCAST8S_16S(A) (fSXTN(64, 128, A)) > > +#define fCAST16S_8S(A) (fSXTN(128, 64, A)) > > +#define fVSATW(A) fVSATN(32, fCAST8_8s(A)) > > +#define fSATW(A) fSATN(32, fCAST8_8s(A)) > > +#define fVSAT(A) fVSATN(32, A) > > +#define fSAT(A) fSATN(32, A) > > + > > +/* Ease parsing */ > > +#define f8BITSOF(VAL) ((VAL) ? 0xff : 0x00) > > +#define fREAD_GP() (Constant_extended ? (0) : GP) > > +#define fCLIP(DST, SRC, U) (DST = fMIN((1 << U) - 1, fMAX(SRC, -(1 << U)))) > > I guess this is what's in the manual, but my reading of this expression is > "saturate", not "clip". How does it differ from > > fSATN(U, SRC) > > ? Their semantics are different. E.g.: - fCLIP(dst, 0x80, 8) => dst = 0x80 - fSATN(8, 0x80) => 0x7F Take a look at `target/hexagon/macros.h` to see their slow (macro/helper-based) implementation, which is basically our reference. As for the naming, it's not up to us. Paolo