From: Marlies Ruck <marlies.ruck@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Riku Voipio" <riku.voipio@iki.fi>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1
Date: Wed, 3 Jul 2019 14:11:01 -0700 [thread overview]
Message-ID: <CALw29ZZS+CzCDNCR4DLZb4j=3KX4dzxKk3JdUZGUXUeJn0hW0w@mail.gmail.com> (raw)
In-Reply-To: <CALw29Za+za-Pncr5esvnaNU8C3dx6Jws+jSbJAPJ0fSc50NotA@mail.gmail.com>
Hi,
Just wanted to follow up to see what your thoughts are. Is it preferable
if I submit a PR to the Go runtime first? That would mitigate concerns
about Go breaking on QEMU with this patch.
Thanks,
Marli
On Mon, Jul 1, 2019 at 3:04 PM Marlies Ruck <marlies.ruck@gmail.com> wrote:
> Hi All,
>
> You are correct, this would break Go binaries. I was planning on
> submitting a PR to the Go runtime if my patch was accepted to QEMU. The Go
> PR would ignore the failure to register a handler for SIGRTMAX - 1, just as
> it currently ignores the failure on SIGRTMAX (
> https://github.com/golang/go/blob/master/src/runtime/os_linux.go#L443).
> Does this seem reasonable to you? My local set up has these patches to
> QEMU and Go and it allows me to run both Go guest programs, and guest
> programs that use SIGRTMIN + 1.
>
> Also, thank you Peter and Phil for your patience as this is my first time
> contributing to QEMU. If you decide to use this patch, I'm happy to resend
> the patch via `git send email`.
>
> Thanks!
> Marli
>
>
>
> On Mon, Jul 1, 2019 at 2:08 AM Peter Maydell <peter.maydell@linaro.org>
> wrote:
>
>> On Sat, 29 Jun 2019 at 11:53, Philippe Mathieu-Daudé <philmd@redhat.com>
>> wrote:
>> >
>> > Hi Marlies,
>> >
>> > On 6/29/19 1:26 AM, Marlies Ruck wrote:
>> > > Hi,
>> > >
>> > > I just wanted to follow up since I sent this patch a week ago to make
>> sure
>> > > it was a received. An ack would be appreciated.
>> >
>> > You did not Cc'ed the maintainer, so he likely missed it.
>> > See:
>> >
>> https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer
>> >
>> > $ ./scripts/get_maintainer.pl -f linux-user/signal.c
>> > Riku Voipio <riku.voipio@iki.fi> (maintainer:Linux user)
>> > Laurent Vivier <laurent@vivier.eu> (reviewer:Linux user)
>> >
>> > BTW you should also look at the next paragraph in this wiki page:
>> >
>> https://wiki.qemu.org/Contribute/SubmitAPatch#Do_not_send_as_an_attachment
>> >
>> > Since you credit Peter Maydell, it would be kind to Cc him too.
>>
>> I have a strong suspicion that if we applied this patch it would
>> break running a pile of Go binaries that currently work, which means
>> it's something we need to be cautious about. (The Go runtime special
>> cases the fact that when it tries to register some signals they don't
>> work, but will abort on startup I think if it can't register a handler
>> for SIGRTMAX-1, which will be the case after this patch.)
>>
>> thanks
>> -- PMM
>>
>
next prev parent reply other threads:[~2019-07-03 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 22:58 [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1 Marlies Ruck
2019-06-28 23:26 ` Marlies Ruck
2019-06-29 10:53 ` Philippe Mathieu-Daudé
2019-07-01 9:08 ` Peter Maydell
2019-07-01 22:04 ` Marlies Ruck
2019-07-03 21:11 ` Marlies Ruck [this message]
2019-08-19 21:46 Josh Kunz via Qemu-devel
2019-08-21 9:28 ` Laurent Vivier
2019-08-26 21:10 ` Josh Kunz via Qemu-devel
2019-08-27 8:08 ` Peter Maydell
2019-08-28 8:51 ` Laurent Vivier
2019-08-28 17:31 ` [Qemu-devel] [EXTERNAL]Re: " Aleksandar Markovic
2019-12-07 13:05 ` [Qemu-devel] " Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALw29ZZS+CzCDNCR4DLZb4j=3KX4dzxKk3JdUZGUXUeJn0hW0w@mail.gmail.com' \
--to=marlies.ruck@gmail.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).