From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879D4C5B578 for ; Tue, 2 Jul 2019 02:43:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5193A21473 for ; Tue, 2 Jul 2019 02:43:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B1kpZY8S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5193A21473 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi8Wn-0006PI-O0 for qemu-devel@archiver.kernel.org; Mon, 01 Jul 2019 22:28:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56756) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hi4QG-0007H8-ID for qemu-devel@nongnu.org; Mon, 01 Jul 2019 18:05:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hi4QF-0001Ti-0T for qemu-devel@nongnu.org; Mon, 01 Jul 2019 18:05:16 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:35374) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hi4QE-0001PH-Id for qemu-devel@nongnu.org; Mon, 01 Jul 2019 18:05:14 -0400 Received: by mail-io1-f65.google.com with SMTP id m24so32450260ioo.2 for ; Mon, 01 Jul 2019 15:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fQmdud04grl8ZB7fn919dxOx0uv0A1cHE1YWXWElWDk=; b=B1kpZY8ScS2F+aLHsRMFbl0+wXzKKcxUju96avFSb6x42YdFTqA9y6GOr9402Wmbge +eZtARyMiVcOOq+CgQyWBfhWWC0wkOEbYgcw/tDRUbFXXbU7N3wr/x+EP5X+dOtv+Tan V8DrZHmQKBrdjwCQVZZlzcBqgm9ojE0jfN8WYvw8m4Og5oHqfomuo98bNOt3GfB6gJFc J/3WrfwMx/PhmydL/TUuiMbwYZb/eyM4sT+jHa/eepRL15iCodOGZ2icb6tFf3AQ4JH+ kNaWj+6DE6dMKSBTlnDOlBsWfK8hrJg3ig2p6k3htXssM4yEah42Nf7rsy3Zvfb4fEwi dkAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fQmdud04grl8ZB7fn919dxOx0uv0A1cHE1YWXWElWDk=; b=srL8NWdCLqqUbwBlfSVqjJsTz5SVqpSAI+YCulw7ZTaxUkGY+uGonsEyp7KHxjxda9 oxAWxqI2+O/SOf+7TQfq06Ip/keFMAUWUMVR53+vahDyNjQInFLdLslDI0/cumAN1oSR QonLvp55BPCixziK7WEvpJha5AB7tt/5MP+xMMFA6J3lcpV0+lsoys496ySlQuUTsrn4 5WwjVED6yqjwKTT0akNVRKVZLPw0tUjnLnypfFdvBLiChAUSp3/3QSwY6HrXWqXLPYTL O3qJI+1w5V0vZttpSQkRCF+rcyLbS9iI0wgnD5trQoZBwYe52bOhbDTuacmebxF8KDsE 8ymA== X-Gm-Message-State: APjAAAVKM1vZoYFY/gof1ySyBzL54t7IV91xGOfG6xZnl2NIewYJ14Eb oJO9mr74/xDkDjcjHjboxmGng7T9VxSYmQk8uCM= X-Google-Smtp-Source: APXvYqzKZMNrIZ88M+IPY74oZXJ+KgBukl1fZz2b9WNNWb8j31ve0i53RnjN9S/FGllx0eNE0r8DeH7il8NO1fU61MQ= X-Received: by 2002:a6b:4f14:: with SMTP id d20mr6766155iob.219.1562018651490; Mon, 01 Jul 2019 15:04:11 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Marlies Ruck Date: Mon, 1 Jul 2019 15:04:00 -0700 Message-ID: To: Peter Maydell X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.166.65 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 Subject: Re: [Qemu-devel] patch to swap SIGRTMIN + 1 and SIGRTMAX - 1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , QEMU Developers , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi All, You are correct, this would break Go binaries. I was planning on submitting a PR to the Go runtime if my patch was accepted to QEMU. The Go PR would ignore the failure to register a handler for SIGRTMAX - 1, just as it currently ignores the failure on SIGRTMAX ( https://github.com/golang/go/blob/master/src/runtime/os_linux.go#L443). Does this seem reasonable to you? My local set up has these patches to QEMU and Go and it allows me to run both Go guest programs, and guest programs that use SIGRTMIN + 1. Also, thank you Peter and Phil for your patience as this is my first time contributing to QEMU. If you decide to use this patch, I'm happy to resend the patch via `git send email`. Thanks! Marli On Mon, Jul 1, 2019 at 2:08 AM Peter Maydell wrote: > On Sat, 29 Jun 2019 at 11:53, Philippe Mathieu-Daud=C3=A9 > wrote: > > > > Hi Marlies, > > > > On 6/29/19 1:26 AM, Marlies Ruck wrote: > > > Hi, > > > > > > I just wanted to follow up since I sent this patch a week ago to make > sure > > > it was a received. An ack would be appreciated. > > > > You did not Cc'ed the maintainer, so he likely missed it. > > See: > > https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintaine= r > > > > $ ./scripts/get_maintainer.pl -f linux-user/signal.c > > Riku Voipio (maintainer:Linux user) > > Laurent Vivier (reviewer:Linux user) > > > > BTW you should also look at the next paragraph in this wiki page: > > > https://wiki.qemu.org/Contribute/SubmitAPatch#Do_not_send_as_an_attachmen= t > > > > Since you credit Peter Maydell, it would be kind to Cc him too. > > I have a strong suspicion that if we applied this patch it would > break running a pile of Go binaries that currently work, which means > it's something we need to be cautious about. (The Go runtime special > cases the fact that when it tries to register some signals they don't > work, but will abort on startup I think if it can't register a handler > for SIGRTMAX-1, which will be the case after this patch.) > > thanks > -- PMM >