From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
To: Bruce Rogers <brogers@suse.com>
Cc: David Hildenbrand <david@redhat.com>,
qemu-devel@nongnu.org, sgarzare@redhat.com
Subject: Re: [PATCH] virtio-mem: Correct format specifier mismatch for RISC-V
Date: Thu, 30 Jul 2020 16:13:22 +0200 [thread overview]
Message-ID: <CAM9Jb+iASQK49RqYJb3QhHsjUpU0oapx5dH37r4NnQV4HaCABg@mail.gmail.com> (raw)
In-Reply-To: <20200730130519.168475-1-brogers@suse.com>
> This likely affects other, less popular host architectures as well.
> Less common host architectures under linux get QEMU_VMALLOC_ALIGN (from
> which VIRTIO_MEM_MIN_BLOCK_SIZE is derived) define to a variable of
> type uintptr, which isn't compatible with the format specifier used to
> print a user message. Since this particular usage of the underlying data
> seems unique to this file, the simple fix is to just cast
> QEMU_VMALLOC_ALIGN to uint32_t, which corresponds to the format specifier
> used.
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> hw/virtio/virtio-mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
> index c12e9f79b0..7740fc613f 100644
> --- a/hw/virtio/virtio-mem.c
> +++ b/hw/virtio/virtio-mem.c
> @@ -36,7 +36,7 @@
> * Use QEMU_VMALLOC_ALIGN, so no THP will have to be split when unplugging
> * memory (e.g., 2MB on x86_64).
> */
> -#define VIRTIO_MEM_MIN_BLOCK_SIZE QEMU_VMALLOC_ALIGN
> +#define VIRTIO_MEM_MIN_BLOCK_SIZE ((uint32_t)QEMU_VMALLOC_ALIGN)
> /*
> * Size the usable region bigger than the requested size if possible. Esp.
> * Linux guests will only add (aligned) memory blocks in case they fully
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
prev parent reply other threads:[~2020-07-30 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 13:05 [PATCH] virtio-mem: Correct format specifier mismatch for RISC-V Bruce Rogers
2020-07-30 13:25 ` David Hildenbrand
2020-07-30 13:28 ` Stefano Garzarella
2020-07-30 14:13 ` Pankaj Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM9Jb+iASQK49RqYJb3QhHsjUpU0oapx5dH37r4NnQV4HaCABg@mail.gmail.com \
--to=pankaj.gupta.linux@gmail.com \
--cc=brogers@suse.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).