From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FROM_LOCAL_NOVOWEL,HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1BE3C433B4 for ; Thu, 15 Apr 2021 20:17:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6687661153 for ; Thu, 15 Apr 2021 20:17:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6687661153 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX8QH-0003NQ-Dx for qemu-devel@archiver.kernel.org; Thu, 15 Apr 2021 16:17:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX8O6-0002Ie-RG; Thu, 15 Apr 2021 16:14:55 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]:47026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lX8O5-0003Qn-J3; Thu, 15 Apr 2021 16:14:54 -0400 Received: by mail-ed1-x532.google.com with SMTP id h10so29568339edt.13; Thu, 15 Apr 2021 13:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gHSKxicn0yIf4UXUNNoWmFc1Z55Pc6GeXuNztixQvQA=; b=imhv0pinl9jhNPKi6m3CC14XYtZ75rdBaZAA8R0s3hZKBeVmhMv36nmZoE0jSL1Lsi 0c23vj3JEkGMgHIfnK8e4mVTdj2Bm1ex7JsrXRPUEHyG55/rL3pcCo3ioYlzqgveQf2D oihmvXeVtx2HeeFFID19JxozR7HYLGPWdqLWvX8zKONFtSQ8ys8SjQ0l1KBtDJFPGJoy mnUxMzXbvwJEOZIHIN0HfV8yo/LiCEPDRF5n2G988JN0aHvSJAVtpO4j0CjBaX+RJKv+ B0uB6vIdWWgWM2kyOlM4xmSGtH5OrE0I5Z5EgkYOjyGxmY/j11BlRGb0YbnMWTsMNbGb AV5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gHSKxicn0yIf4UXUNNoWmFc1Z55Pc6GeXuNztixQvQA=; b=H5YUJHMrIWaPi2uxtsAD15pGuk2hJpaIwNuge29Rz93sSWgRrmLnFCKeXcLIxLSfnU T5/0d2UiL9EHYStF1ccePXtTY9bXWQWfus8Ys/9MqZfZQ4L6n5ldTExVnr27eYjIERc8 ai2m8ek2/tHffxaFyvU635FTTQzLU2lc+XUdvdc+C6H+jlkJWE4J2I86ApIGDrTduHu1 s12Qx2pZHPiRGbzc0IaLun1+QuP1GkR3sz+L76eePjZGAG17qlhzApplNdeBlKuga2W6 IiscDW1deEaKNaUw02q5IWrm029nLPeifvvhc0wVhx2TcqRgkqwwNZuMWgO7mrUiuS9B p2Yw== X-Gm-Message-State: AOAM533PPKuy3Qqgn5+4kw6eN4HawjBb59W8jDVY9lNyNKHki5CwuLiq NxUGpmxqPKT+6pT6ulaWKchvUG05Ir4IGLjR+no= X-Google-Smtp-Source: ABdhPJxrAszC3CQf1ZqTWEFBLgieJBJN9+15L4TCB/y0/M4iPpgxkD83deHV2nza8fcZCJnFPRjSdbrS7P+9dPv8+78= X-Received: by 2002:a05:6402:2552:: with SMTP id l18mr6251193edb.71.1618517691084; Thu, 15 Apr 2021 13:14:51 -0700 (PDT) MIME-Version: 1.0 References: <20210415130305.28640-1-iii@linux.ibm.com> <20210415130305.28640-4-iii@linux.ibm.com> In-Reply-To: <20210415130305.28640-4-iii@linux.ibm.com> From: Max Filippov Date: Thu, 15 Apr 2021 13:14:39 -0700 Message-ID: Subject: Re: [PATCH v4 3/4] target/xtensa: Make sure that tb->size != 0 To: Ilya Leoshkevich Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=jcmvbkbc@gmail.com; helo=mail-ed1-x532.google.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_LOCAL_NOVOWEL=0.5, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Thomas Huth , David Hildenbrand , Cornelia Huck , Richard Henderson , qemu-devel , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-arm , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Apr 15, 2021 at 6:03 AM Ilya Leoshkevich wrote: > > tb_gen_code() assumes that tb->size must never be zero, otherwise it > may produce spurious exceptions. For xtensa this may happen when > decoding an unknown instruction, when handling a write into the > CCOUNT or CCOMPARE special register and when single-stepping the first > instruction of an exception handler. > > Fix by pretending that the size of the respective translation block is > 1 in all these cases. > > Signed-off-by: Ilya Leoshkevich > --- > target/xtensa/translate.c | 3 +++ > 1 file changed, 3 insertions(+) Tested-by: Max Filippov Acked-by: Max Filippov -- Thanks. -- Max