From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler
Date: Tue, 8 Oct 2019 19:23:56 +0400 [thread overview]
Message-ID: <CAMxuvawO28bNsjygDB5FsT_SDTrcbmh5v-NJKJ7SbViB9P2aYw@mail.gmail.com> (raw)
In-Reply-To: <20191008143455.8524-1-philmd@redhat.com>
On Tue, Oct 8, 2019 at 6:35 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> The VM coreinfo device does not sit on a bus, so it won't be
> reset automatically. This is why it calls qemu_register_reset().
>
> Add a comment about it, so we don't convert its reset handler
> to a DeviceReset method.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/misc/vmcoreinfo.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/misc/vmcoreinfo.c b/hw/misc/vmcoreinfo.c
> index 326a3ce8f4..a9d718fc23 100644
> --- a/hw/misc/vmcoreinfo.c
> +++ b/hw/misc/vmcoreinfo.c
> @@ -61,6 +61,10 @@ static void vmcoreinfo_realize(DeviceState *dev, Error **errp)
> NULL, fw_cfg_vmci_write, s,
> &s->vmcoreinfo, sizeof(s->vmcoreinfo), false);
>
> + /*
> + * This device requires to register a global reset because it is
> + * not plugged to a bus (which, as its QOM parent, would reset it).
> + */
> qemu_register_reset(vmcoreinfo_reset, dev);
> vmcoreinfo_state = s;
> }
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-10-08 15:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 14:25 [PATCH v2 0/8] hw: Convert various reset() handler to DeviceReset Philippe Mathieu-Daudé
2019-10-08 14:25 ` [PATCH v2 1/8] hw/acpi/piix4: Convert reset " Philippe Mathieu-Daudé
2019-10-09 0:58 ` Li Qiang
2019-10-09 19:17 ` Michael S. Tsirkin
2019-10-08 14:25 ` [PATCH v2 2/8] hw/isa/piix4: " Philippe Mathieu-Daudé
2019-10-09 1:02 ` Li Qiang
2019-10-08 14:25 ` [PATCH v2 3/8] hw/ide/piix: " Philippe Mathieu-Daudé
2019-10-09 1:08 ` Li Qiang
2019-10-09 19:50 ` Philippe Mathieu-Daudé
2019-10-08 14:25 ` [PATCH v2 4/8] hw/ide/sii3112: " Philippe Mathieu-Daudé
2019-10-10 1:08 ` Li Qiang
2019-10-08 14:25 ` [PATCH v2 5/8] hw/ide/via82c: " Philippe Mathieu-Daudé
2019-10-10 1:10 ` Li Qiang
2019-10-08 14:25 ` [PATCH v2 6/8] hw/isa/vt82c686: " Philippe Mathieu-Daudé
2019-10-10 1:12 ` Li Qiang
2019-10-08 14:25 ` [PATCH v2 7/8] hw/input/lm832x: " Philippe Mathieu-Daudé
2019-10-10 1:14 ` Li Qiang
2019-10-08 14:34 ` [PATCH v2 8/8] hw/misc/vmcoreinfo: Add comment about reset handler Philippe Mathieu-Daudé
2019-10-08 15:23 ` Marc-André Lureau [this message]
2019-10-10 1:18 ` Li Qiang
2019-10-09 2:28 ` [PATCH v2 0/8] hw: Convert various reset() handler to DeviceReset Li Qiang
2019-10-09 19:54 ` Philippe Mathieu-Daudé
2019-10-10 1:05 ` Li Qiang
2019-10-10 13:08 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMxuvawO28bNsjygDB5FsT_SDTrcbmh5v-NJKJ7SbViB9P2aYw@mail.gmail.com \
--to=marcandre.lureau@redhat.com \
--cc=ehabkost@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).