From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"P. Berrange, Daniel" <berrange@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 1/2] qemu-options: define -spice only #ifdef CONFIG_SPICE
Date: Thu, 18 Nov 2021 18:14:40 +0400 [thread overview]
Message-ID: <CAMxuvazADhGLKeN2aV=RM6wtWEVp4Xw2NuGPzog4ht4YsZ_XTg@mail.gmail.com> (raw)
In-Reply-To: <87czmxwu8s.fsf@dusky.pond.sub.org>
Hi
On Thu, Nov 18, 2021 at 3:58 PM Markus Armbruster <armbru@redhat.com> wrote:
>
> marcandre.lureau@redhat.com writes:
>
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Fixes:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1982600
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > softmmu/vl.c | 2 ++
> > qemu-options.hx | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/softmmu/vl.c b/softmmu/vl.c
> > index 1159a64bce4e..385465fbeb6d 100644
> > --- a/softmmu/vl.c
> > +++ b/softmmu/vl.c
> > @@ -3538,6 +3538,7 @@ void qemu_init(int argc, char **argv, char **envp)
> > case QEMU_OPTION_readconfig:
> > qemu_read_config_file(optarg, qemu_parse_config_group, &error_fatal);
> > break;
> > +#ifdef CONFIG_SPICE
> > case QEMU_OPTION_spice:
> > olist = qemu_find_opts_err("spice", NULL);
> > if (!olist) {
> error_report("spice support is disabled");
> exit(1);
> }
>
> Is this error still reachable?
I wonder if module loading failed, it's non fatal and will report this error.
>
> > @@ -3550,6 +3551,7 @@ void qemu_init(int argc, char **argv, char **envp)
> > }
> > display_remote++;
> > break;
> > +#endif
> > case QEMU_OPTION_writeconfig:
> > {
> > FILE *fp;
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 7749f59300b5..323913945a5d 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -2017,6 +2017,7 @@ SRST
> > Enable SDL.
> > ERST
> >
> > +#ifdef CONFIG_SPICE
> > DEF("spice", HAS_ARG, QEMU_OPTION_spice,
> > "-spice [port=port][,tls-port=secured-port][,x509-dir=<dir>]\n"
> > " [,x509-key-file=<file>][,x509-key-password=<file>]\n"
> > @@ -2038,6 +2039,7 @@ DEF("spice", HAS_ARG, QEMU_OPTION_spice,
> > " enable spice\n"
> > " at least one of {port, tls-port} is mandatory\n",
> > QEMU_ARCH_ALL)
> > +#endif
> > SRST
> > ``-spice option[,option[,...]]``
> > Enable the spice remote desktop protocol. Valid options are
>
next prev parent reply other threads:[~2021-11-18 14:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 8:03 [PATCH v2 0/2] qemu-options: define -spice only #ifdef CONFIG_SPICE marcandre.lureau
2021-11-15 8:03 ` [PATCH v2 1/2] " marcandre.lureau
2021-11-18 11:58 ` Markus Armbruster
2021-11-18 14:14 ` Marc-André Lureau [this message]
2021-11-15 8:03 ` [PATCH v2 2/2] vl: typo fix in a comment marcandre.lureau
2021-11-15 10:00 ` [PATCH v2 0/2] qemu-options: define -spice only #ifdef CONFIG_SPICE Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMxuvazADhGLKeN2aV=RM6wtWEVp4Xw2NuGPzog4ht4YsZ_XTg@mail.gmail.com' \
--to=marcandre.lureau@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).