From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18873C433DB for ; Sat, 2 Jan 2021 14:26:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8295522482 for ; Sat, 2 Jan 2021 14:26:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8295522482 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvhrJ-0003GA-C2 for qemu-devel@archiver.kernel.org; Sat, 02 Jan 2021 09:26:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvhHe-0008HA-GT for qemu-devel@nongnu.org; Sat, 02 Jan 2021 08:49:30 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:41016) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvhHb-0002kK-Pp for qemu-devel@nongnu.org; Sat, 02 Jan 2021 08:49:30 -0500 Received: by mail-ed1-x534.google.com with SMTP id i24so22196768edj.8 for ; Sat, 02 Jan 2021 05:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MXYsc3V9gdGdBav4QnbscS2SJSHtSd4TDJY0y3f2tfc=; b=ZvuxcmAZTKWnkDaKqQQseGe2AJumUaFKvVP0ERiBMwvvL3gUhfZmc+g/A02OwHC31s BJDpOpekQXEZLFZAGgQwZYT9PjdZr3uW1IhZK+iKp3183r2d01mE7XPM8OmeNQV/sQhZ re2451OTMv9EzTzLL2wXPJgi6PJjiMqiqvACHGlD15GtJD0ofDlh08h8mQvOCZSS3zYY WwuzPwm/g6A8Kuubwm8PD9dWQ5VOqbab0p+jfuMfrVAJV2ceMs4utq30WmlbdtA2TQV2 IYbUfWGNM4E4CU8CevlJVr4RxhbtNDAoXqUapKgYWgA2cKmILYCuEsL3RxQi72VUZj7S qWNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MXYsc3V9gdGdBav4QnbscS2SJSHtSd4TDJY0y3f2tfc=; b=AG2cSmBkzMkdz8lsgnhKp4JrIGHiXrJi9r9dsMiUtTNQPd0yiUsyVDFre6BbJ9bXHj glin3JdUYf47j11Oy29Rjm1wJUaAlGiRxXOaq0/ERVaIDjHwk0fTtzOuCVDfhC89fXEE AcB1U/RN5Xgf4GmzM+OXLntkGekhSyIiN02mquUyQBCKCE5HtF3tpdCUiyKbAwIp7knc j0+lmzUKx3PH73F+XWAd495NEW9SCL9tRjZcW9kcu0halfi+p0utt8DGxXKCBoRz9n2/ t1OzpK8wgIB3WFFjE0Hp7XqoZKpVYE9qa+YaBy0EBKZVFV38aIvvbQ+DM7/4Er4e1Zuu KCYA== X-Gm-Message-State: AOAM5327MAg1WO5z6aro++HjtUEN9Yq2eCNLRwqCabF7rXRPzj/JSa/s BmJDEwoiDtz9A1RR+SYkNBR49KaGP0rPNZ80h3r+eg== X-Google-Smtp-Source: ABdhPJyGKnwTN8YFjGj1Qo16OvsmVtDez0ihFTHRXkYLqTCI5mW+119HBeyndwnn7IaVygfGbWiLjRtFR9qCuMNR0zY= X-Received: by 2002:a50:fe0e:: with SMTP id f14mr64414601edt.159.1609595366226; Sat, 02 Jan 2021 05:49:26 -0800 (PST) MIME-Version: 1.0 References: <20201231113010.27108-1-bmeng.cn@gmail.com> <20201231113010.27108-4-bmeng.cn@gmail.com> In-Reply-To: <20201231113010.27108-4-bmeng.cn@gmail.com> From: Pragnesh Patel Date: Sat, 2 Jan 2021 19:19:13 +0530 Message-ID: Subject: Re: [PATCH 03/22] hw/sd: ssi-sd: Fix incorrect card response sequence To: Bin Meng Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=pragnesh.patel@sifive.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 02 Jan 2021 09:24:39 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:RISC-V" , Qemu-block , Bin Meng , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , "qemu-devel@nongnu.org Developers" , Alistair Francis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Dec 31, 2020 at 5:04 PM Bin Meng wrote: > > From: Bin Meng > > Per the "Physical Layer Specification Version 8.00" chapter 7.5.1, > "Command/Response", there is a minimum 8 clock cycles (Ncr) before > the card response shows up on the data out line. However current > implementation jumps directly to the sending response state after > all 6 bytes command is received, which is a spec violation. > > Add a new state PREP_RESP in the ssi-sd state machine to handle it. > > Fixes: 775616c3ae8c ("Partial SD card SPI mode support") > Signed-off-by: Bin Meng > --- > > hw/sd/ssi-sd.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Pragnesh Patel Tested-by: Pragnesh Patel