From: Warner Losh <imp@bsdimp.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: "Kyle Evans" <kevans@freebsd.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Mikaël Urankar" <mikael.urankar@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v2 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE
Date: Fri, 24 Sep 2021 09:07:40 -0600 [thread overview]
Message-ID: <CANCZdfoZTc=2B+-QauyByt-i-8LY6DDx9Ybwzi-BSq0JFvbC2g@mail.gmail.com> (raw)
In-Reply-To: <261b4ee5-07d0-ac11-21a6-a5e1c4865fe1@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On Fri, Sep 24, 2021 at 5:59 AM Richard Henderson <
richard.henderson@linaro.org> wrote:
> On 9/21/21 9:56 PM, Warner Losh wrote:
> > From: Mikaël Urankar <mikael.urankar@gmail.com>
> >
> > Simmilar to the equivalent linux-user: commit fb7e378cf9c, which added
> > checking to pread's return value.
> >
> > Signed-off-by: Mikaël Urankar <mikael.urankar@gmail.com>
> > Signed-off-by: Warner Losh <imp@bsdimp.com>
> > ---
> > bsd-user/mmap.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> > - pread(fd, g2h_untagged(start), end - start, offset);
> > + if (pread(fd, g2h_untagged(start), end - start, offset) == -1)
> > + return -1;
>
> If it's not too annoying wrt rebasing other cleanups, please add the
> braces now.
>
You bet.
>
> r~
>
[-- Attachment #2: Type: text/html, Size: 1735 bytes --]
next prev parent reply other threads:[~2021-09-24 15:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 4:56 [PATCH v2 0/9] bsd-user mmap fixes Warner Losh
2021-09-22 4:56 ` [PATCH v2 1/9] bsd-user/mmap.c: Always zero MAP_ANONYMOUS memory in mmap_frag() Warner Losh
2021-09-23 17:35 ` Richard Henderson
2021-09-22 4:56 ` [PATCH v2 2/9] bsd-user/mmap.c: check pread's return value to fix warnings with _FORTIFY_SOURCE Warner Losh
2021-09-23 17:36 ` Richard Henderson
2021-09-24 15:07 ` Warner Losh [this message]
2021-09-25 10:54 ` Philippe Mathieu-Daudé
2021-09-22 4:56 ` [PATCH v2 3/9] bsd-user/mmap.c: MAP_ symbols are defined, so no need for ifdefs Warner Losh
2021-09-23 17:37 ` Richard Henderson
2021-09-22 4:56 ` [PATCH v2 4/9] bsd-user/mmap.c: mmap return ENOMEM on overflow Warner Losh
2021-09-23 17:38 ` Richard Henderson
2021-09-25 10:55 ` Philippe Mathieu-Daudé
2021-09-22 4:56 ` [PATCH v2 5/9] bsd-user/mmap.c: mmap prefer MAP_ANON for BSD Warner Losh
2021-09-23 17:38 ` Richard Henderson
2021-09-22 4:56 ` [PATCH v2 6/9] bsd-user/mmap.c: line wrap change Warner Losh
2021-09-23 17:41 ` Richard Henderson
2021-09-26 16:46 ` Warner Losh
2021-09-22 4:56 ` [PATCH v2 7/9] bsd-user/mmap.c: Don't mmap fd == -1 independently from MAP_ANON flag Warner Losh
2021-09-23 17:43 ` Richard Henderson
2021-09-26 17:08 ` Warner Losh
2021-09-26 19:07 ` Guy Yur
2021-09-27 0:17 ` Warner Losh
2021-09-22 4:56 ` [PATCH v2 8/9] bsd-user/mmap.c: Implement MAP_EXCL, required by jemalloc in head Warner Losh
2021-09-23 17:52 ` Richard Henderson
2021-09-26 18:38 ` Warner Losh
2021-09-22 4:56 ` [PATCH v2 9/9] bsd-user/mmap.c: assert that target_mprotect cannot fail Warner Losh
2021-09-23 17:53 ` Richard Henderson
2021-09-25 10:58 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANCZdfoZTc=2B+-QauyByt-i-8LY6DDx9Ybwzi-BSq0JFvbC2g@mail.gmail.com' \
--to=imp@bsdimp.com \
--cc=f4bug@amsat.org \
--cc=kevans@freebsd.org \
--cc=mikael.urankar@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).