From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F33C433EF for ; Fri, 5 Nov 2021 17:13:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90EB361108 for ; Fri, 5 Nov 2021 17:13:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 90EB361108 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bsdimp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mj2mB-00032d-My for qemu-devel@archiver.kernel.org; Fri, 05 Nov 2021 13:13:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mj2i3-0004AY-G5 for qemu-devel@nongnu.org; Fri, 05 Nov 2021 13:09:00 -0400 Received: from mail-ua1-x92a.google.com ([2607:f8b0:4864:20::92a]:37696) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mj2i1-0002uF-F0 for qemu-devel@nongnu.org; Fri, 05 Nov 2021 13:08:59 -0400 Received: by mail-ua1-x92a.google.com with SMTP id l43so18327417uad.4 for ; Fri, 05 Nov 2021 10:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kbQHhaYp8FTpqPysPfme9O/tCiPncSFKKQH3ADep+Iw=; b=3+o9tCT6Ah+Q2bXL+HPpmfYGzQPYch2iWfWvKRz9FBiY/UznoIr7OlOoVWGYuqUgZg gsB2vn+oSqAzc3avNXYGZGXj1uj9mfTKUDvD6pKVNd6bBEKJd2Oxs+oyyMc806K0PaSH 7NFNbyfXXEyC+eh/Vd+pkxoekzQoRDncp8oQDi3sUu5tVBfIpagUyZmavuaIMTghPIfK 0RyIP99h2D3a8Ji8vD27oNGhuO/XeTswugtfVTsvQjW3FeWoOVQ2P8YGYQnNVZo+SZi3 c0pL381Q4mrKv0qrN+uhCrLgwBRGVvrMeuthWM+8aHk7wfpgTDSAeAKOrNvmBXGH1HLL QR8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kbQHhaYp8FTpqPysPfme9O/tCiPncSFKKQH3ADep+Iw=; b=mN2quhUUHesMPI3pjw8Ea1dvTspRH5HelQXMOW69lrzPNJuoc57xQDqnb9rtclN97N 3fnj0A5Ut56AbUulIF21xd+iKLGzU/sXMERYCUbabEMKVYFDoPOIbTHiruB3w3px79dU ccOyL3zRzI8Sba+V/WSgDjDw8NqvjzVrE152CC4zpksDNKPqqNO5T73J6qpb8iXUGlDc mW2Jc3qqBdkxN+NIWfnBGn8igjYh7RauZ8wqUrXJgMUp7iO2YJFYNLwn9yM1BlziGu5j qpMrZYWeUnT0tgJZ7xIlycxDUAkQtidtM40Pheb95g0yMUUrZExLixfKOh4FZQpHO5MI 94og== X-Gm-Message-State: AOAM533JwiqDZgsQZIfapM/lo5j1a39S1EdcfJo7sBuZvb8/IuBIKO9P 2TPmYFS09mZh4CNWVYynI6K04YfLDNVpvFuwNs4r4w== X-Google-Smtp-Source: ABdhPJxxSdKuU8qi2hr2iuTNB9q9p2n7SoJgg2vHIqy7qo4d9JsxBozxZx413woAl86Cjr06Po+fwGeSmLPSp4DXBKg= X-Received: by 2002:a67:ab48:: with SMTP id k8mr74222338vsh.30.1636132136300; Fri, 05 Nov 2021 10:08:56 -0700 (PDT) MIME-Version: 1.0 References: <20211105031917.87837-1-imp@bsdimp.com> <20211105031917.87837-12-imp@bsdimp.com> In-Reply-To: From: Warner Losh Date: Fri, 5 Nov 2021 11:08:45 -0600 Message-ID: Subject: Re: [PATCH v4 11/36] bsd-user/x86_64: Move functions into signal.c To: Richard Henderson Content-Type: multipart/alternative; boundary="000000000000ca452105d00db274" Received-SPF: none client-ip=2607:f8b0:4864:20::92a; envelope-from=wlosh@bsdimp.com; helo=mail-ua1-x92a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Kyle Evans , Michael Tokarev , Laurent Vivier , QEMU Developers , Philippe Mathieu-Daude Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000ca452105d00db274 Content-Type: text/plain; charset="UTF-8" On Fri, Nov 5, 2021 at 10:25 AM Richard Henderson < richard.henderson@linaro.org> wrote: > On 11/4/21 11:18 PM, Warner Losh wrote: > > Move the current inline functions into sigal.c. This will increate the > > flexibility of implementation in the future. > > > > Signed-off-by: Warner Losh > > --- > > bsd-user/x86_64/signal.c | 56 +++++++++++++++++++++++++++- > > bsd-user/x86_64/target_arch_signal.h | 43 ++++----------------- > > 2 files changed, 63 insertions(+), 36 deletions(-) > > Reviewed-by: Richard Henderson > > > > +abi_long set_sigtramp_args(CPUX86State *env, int sig, > > + struct target_sigframe *frame, > > + abi_ulong frame_addr, > > + struct target_sigaction *ka); > > +abi_long get_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int > flags); > > +abi_long set_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int > srflag); > > +abi_long get_ucontext_sigreturn(CPUX86State *regs, abi_ulong target_sf, > > + abi_ulong *target_uc); > > with of course the same comment as for i386. > of course... :) Warner --000000000000ca452105d00db274 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Nov 5, 2021 at 10:25 AM Richa= rd Henderson <richard.he= nderson@linaro.org> wrote:
On 11/4/21 11:18 PM, Warner Losh wrote:
> Move the current inline functions into sigal.c. This will increate the=
> flexibility of implementation in the future.
>
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
>=C2=A0 =C2=A0bsd-user/x86_64/signal.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0| 56 +++++++++++++++++++++++++++-
>=C2=A0 =C2=A0bsd-user/x86_64/target_arch_signal.h | 43 ++++------------= -----
>=C2=A0 =C2=A02 files changed, 63 insertions(+), 36 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


> +abi_long set_sigtramp_args(CPUX86State *env, int sig,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0struct target_sigframe *frame,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0abi_ulong frame_addr,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0struct target_sigaction *ka);
> +abi_long get_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int = flags);
> +abi_long set_mcontext(CPUX86State *regs, target_mcontext_t *mcp, int = srflag);
> +abi_long get_ucontext_sigreturn(CPUX86State *regs, abi_ulong target_s= f,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 abi_ulong *target_uc);

with of course the same comment as for i386.

of course... :)

Warner
--000000000000ca452105d00db274--