qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Warner Losh <imp@bsdimp.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Laurent Vivier <laurent@vivier.eu>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Philippe Mathieu-Daude <f4bug@amsat.org>
Subject: Re: [RFC v2 1/6] linux-user: Add host_signal_set_pc to set pc in mcontext
Date: Wed, 10 Nov 2021 15:46:56 -0700	[thread overview]
Message-ID: <CANCZdfqhA7h_eTsJKNB5DTaAOQrkkQigq7OC4SbeSo7tYtDmEQ@mail.gmail.com> (raw)
In-Reply-To: <32bfbe52-fd12-5997-5697-0267a16415a0@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

On Wed, Nov 10, 2021 at 9:42 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 11/10/21 5:31 PM, Warner Losh wrote:
> > +static inline void host_signal_set_pc(ucontext_t *uc, uintptr_t pc)
> > +{
> > +#ifdef __arch64__
> > +    uc->uc_mcontext.mc_gregs[MC_PC] = pc;
> > +#else
> > +    &uc->uc_mcontext.gregs[REG_PC] = pc;
>
> Stray & here.  Not that I have a sparc32 host on which to compile this...
>

Will fix... Same.  It's left over from the pointer versions and resend.

Warner

[-- Attachment #2: Type: text/html, Size: 930 bytes --]

  reply	other threads:[~2021-11-10 22:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 16:31 [RFC v2 0/6] linux-user: simplify safe signal handling Warner Losh
2021-11-10 16:31 ` [RFC v2 1/6] linux-user: Add host_signal_set_pc to set pc in mcontext Warner Losh
2021-11-10 16:42   ` Richard Henderson
2021-11-10 22:46     ` Warner Losh [this message]
2021-11-10 16:31 ` [RFC v2 2/6] linux-user/signal.c: Create a common rewind_if_in_safe_syscall Warner Losh
2021-11-10 16:31 ` [RFC v2 3/6] linux-user/safe-syscall.inc.S: Move to common-user Warner Losh
2021-11-10 16:43   ` Richard Henderson
2021-11-10 16:31 ` [RFC v2 4/6] common-user: Adjust system call return on FreeBSD Warner Losh
2021-11-10 16:59   ` Richard Henderson
2021-11-10 22:53     ` Warner Losh
2021-11-10 16:31 ` [RFC v2 5/6] common-user/host/mips: create, though mips hosts likely don't work reliably Warner Losh
2021-11-10 17:00   ` Richard Henderson
2021-11-10 22:58     ` Warner Losh
2021-11-10 16:31 ` [RFC v2 6/6] *-user: move safe-syscall.* to common-user Warner Losh
2021-11-10 17:04   ` Richard Henderson
2021-11-10 23:02     ` Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANCZdfqhA7h_eTsJKNB5DTaAOQrkkQigq7OC4SbeSo7tYtDmEQ@mail.gmail.com \
    --to=imp@bsdimp.com \
    --cc=f4bug@amsat.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).