On Mon, Nov 8, 2021 at 12:37 AM Philippe Mathieu-Daudé wrote: > On 11/7/21 01:39, Warner Losh wrote: > > > > > > On Sat, Nov 6, 2021, 5:39 AM Philippe Mathieu-Daudé > > wrote: > > > > cpu_loop() never exits, so mark it with QEMU_NORETURN. > > > > Reviewed-by: Richard Henderson > > > > Reviewed-By: Warner Losh > > > Reviewed-by: Bin Meng >> > > Signed-off-by: Philippe Mathieu-Daudé > > > > --- > > v2: > > - rebased > > - restricted to linux-user > > > > Supersedes: <20210905000429.1097336-1-f4bug@amsat.org > > > > > > > > > Reviewed-by: Warner Losh > > > > > bsd-user likely needs similar treatment, no? > > IIUC this thread, not yet (I didn't want to get into your refactor): > > https://lore.kernel.org/qemu-devel/CAFEAcA-f=n6XHp5Cj7=tH8NWO1GLA50i34=5GyaHrZELyr0bjw@mail.gmail.com/ I'll add it to my TODO items. I hope to get a small collection of those in this month before the release after I land the arm bits. Warner