From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48291)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelio.remonda@tallertechnologies.com>)
	id 1aRjfj-0006ow-HL
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:55:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelio.remonda@tallertechnologies.com>)
	id 1aRjfh-0007zE-IV
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:55:51 -0500
Received: from mail-vk0-x22c.google.com ([2607:f8b0:400c:c05::22c]:32947)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelio.remonda@tallertechnologies.com>)
	id 1aRjfh-0007zA-Af
	for qemu-devel@nongnu.org; Fri, 05 Feb 2016 11:55:49 -0500
Received: by mail-vk0-x22c.google.com with SMTP id e64so60664936vkg.0
	for <qemu-devel@nongnu.org>; Fri, 05 Feb 2016 08:55:49 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA8ZJjDnFCYMG0aidhAb4obfbBTYy5oJ60e0pQqfBCoG=w@mail.gmail.com>
References: <CANLssst0zPbWbH1KDgK__d1kW3B=TSJknKrFAXUXKKuKR3-ubg@mail.gmail.com>
	<CAFEAcA8dZOGsEZ3smegTeiAZgGBMpkXZDymZwfScGJvBifFEFg@mail.gmail.com>
	<CANLsssumQX9muKaKdArYDV=ex_=tTGexS=jJd_OA_uh+KQvDdQ@mail.gmail.com>
	<CANLssssdY6UFZozNtajrjuZpH4vWRMSCp4BDNuSXjGVfATsY4w@mail.gmail.com>
	<CAFEAcA8ZJjDnFCYMG0aidhAb4obfbBTYy5oJ60e0pQqfBCoG=w@mail.gmail.com>
Date: Fri, 5 Feb 2016 13:55:48 -0300
Message-ID: <CANLsssu=cgfRON=sNn=dc1TtNNMoreMi1Gs3thn+-MwQnCyAhg@mail.gmail.com>
From: Aurelio Remonda <aurelio.remonda@tallertechnologies.com>
Content-Type: multipart/alternative; boundary=001a1145542e173f4e052b08b982
Subject: Re: [Qemu-devel] Memory on stellaris board
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

--001a1145542e173f4e052b08b982
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

El 5 feb. 2016 1:24 PM, "Peter Maydell" <peter.maydell@linaro.org> escribi=
=C3=B3:

> On 5 February 2016 at 16:09, Aurelio Remonda
> <aurelio.remonda@tallertechnologies.com> wrote:
> > Hello, im working on this feature right now.
> > i have a working patch but maybe I can make some changes to make it loo=
k
> better:
> > for example in some point i check ram_size like this:
> > if (ram_size =3D=3D 0x8000000)
> > Maybe if i make ram_addr_t default_ram_size global (is a local
> > variable of set_memory_options function)
> > i can use it instead of hardcoded 0x8000000.
>
> No, don't do that.
>
> Why do you care about whether the ram size is the default or not?
>
> thanks
> -- PMM
>

Im making something like this:

    if (ram_size =3D=3D 0x8000000)  /* default value, means whitout -m flag=
 */
   {
    sram_size =3D ((board->dc0 >> 18) + * 1024;
    }
  else if (ram_size >=3D UINT_MAX) /* more than 4GB */
  sram_size =3D UINT_MAX;
  else
  sram_size =3D ram_size

So in case someone does not use the -m flag i want to be sure the ram is

calculated like it was before.

If the flag is indeed used you have a limit given by the size of sram_size
(32 bits)

in that case if you try using the -m option with a size greater than 4GB
you will always get a

4GB (4294967296 to be precise).

--001a1145542e173f4e052b08b982
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">El 5 feb. 2016 1:24 PM, &quot;Peter Maydell&quot; &lt;<a h=
ref=3D"mailto:peter.maydell@linaro.org" target=3D"_blank">peter.maydell@lin=
aro.org</a>&gt; escribi=C3=B3:<br type=3D"attribution"><div class=3D"gmail_=
quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;=
border-left:1px solid rgb(204,204,204);padding-left:1ex">On 5 February 2016=
 at 16:09, Aurelio Remonda<br>
&lt;<a href=3D"mailto:aurelio.remonda@tallertechnologies.com" target=3D"_bl=
ank">aurelio.remonda@tallertechnologies.com</a>&gt; wrote:<br>
&gt; Hello, im working on this feature right now.<br>
&gt; i have a working patch but maybe I can make some changes to make it lo=
ok better:<br>
&gt; for example in some point i check ram_size like this:<br>
&gt; if (ram_size =3D=3D 0x8000000)<br>
&gt; Maybe if i make ram_addr_t default_ram_size global (is a local<br>
&gt; variable of set_memory_options function)<br>
&gt; i can use it instead of hardcoded 0x8000000.<br>
<br>
No, don&#39;t do that.<br>
<br>
Why do you care about whether the ram size is the default or not?<br>
<br>
thanks<br>
-- PMM<br></blockquote><div><br><p dir=3D"ltr">Im making something like thi=
s:</p>
<p dir=3D"ltr">=C2=A0 =C2=A0 if (ram_size =3D=3D 0x8000000)=C2=A0 /* defaul=
t value, means whitout -m flag */<br>
=C2=A0=C2=A0 {<br>
=C2=A0 =C2=A0 sram_size =3D ((board-&gt;dc0 &gt;&gt; 18) + * 1024;<br>
=C2=A0 =C2=A0 }<br>
 =C2=A0 else if (ram_size &gt;=3D UINT_MAX) /* more than 4GB */<br>
=C2=A0 sram_size =3D UINT_MAX;<br>
=C2=A0 else<br>
 =C2=A0 sram_size =3D ram_size</p>
<p dir=3D"ltr">So in case someone does not use the -m flag i want to be sur=
e the ram is <br></p><p>calculated like it was before.</p><p>If the flag is=
 indeed used you have a limit given by the size of sram_size (32 bits)</p><=
p>in that case if you try using the -m option with a size <span class=3D"">=
greater</span> than 4GB you will always get a</p><p>4GB (4294967296 to be p=
recise). <br></p></div></div>
</div>

--001a1145542e173f4e052b08b982--