qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Connor Kuehl" <ckuehl@redhat.com>
To: "Carlos Venegas" <jose.carlos.venegas.munoz@intel.com>,
	<virtio-fs@redhat.com>
Cc: qemu-devel@nongnu.org, vgoyal@redhat.com
Subject: Re: [Virtio-fs] [PATCH 2/2] virtiofsd: Add help for -o xattr-mapping
Date: Wed, 14 Apr 2021 16:44:26 -0500	[thread overview]
Message-ID: <CANRX0ORJA43.22ADKWIJW7DI0@redhat> (raw)
In-Reply-To: <20210414201207.3612432-3-jose.carlos.venegas.munoz@intel.com>

On Wed Apr 14, 2021 at 3:12 PM CDT, Carlos Venegas wrote:
> The option is not documented in help.
>
> Add small help about the option.
>
> Signed-off-by: Carlos Venegas <jose.carlos.venegas.munoz@intel.com>
> ---
> tools/virtiofsd/helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> index 28243b51b2..5e98ed702b 100644
> --- a/tools/virtiofsd/helper.c
> +++ b/tools/virtiofsd/helper.c
> @@ -172,6 +172,9 @@ void fuse_cmdline_help(void)
> " default: no_writeback\n"
> " -o xattr|no_xattr enable/disable xattr\n"
> " default: no_xattr\n"
> + " -o xattrmap=<mapping> Enable xattr mapping (enables xattr)\n"
> + " <mapping> is a string consists of a series of rules\n"
> + " e.g. -o xattrmap=:map::user.virtiofs.:\n"

This is a helpful note, but it doesn't tell the whole story. I think
it'd be helpful to add one last note to this option which is to
recommend reading the virtiofsd(1) man-page for more information on
xattrmap rules.

Connor



  reply	other threads:[~2021-04-14 21:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-14 20:12 [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used Carlos Venegas
2021-04-14 20:12 ` [PATCH 1/2] virtiofsd: Allow use "-o xattrmap" without "-o xattr" Carlos Venegas
2021-04-16 11:05   ` [Virtio-fs] " Greg Kurz
2021-04-19 18:55     ` Vivek Goyal
2021-05-06 10:00     ` Dr. David Alan Gilbert
2021-04-14 20:12 ` [PATCH 2/2] virtiofsd: Add help for -o xattr-mapping Carlos Venegas
2021-04-14 21:44   ` Connor Kuehl [this message]
2021-04-19 19:07     ` [Virtio-fs] " Vivek Goyal
2021-04-19 19:21       ` Connor Kuehl
2021-04-19 19:59         ` Vivek Goyal
2021-04-14 21:47 ` [PATCH 0/2] virtiofsd: Enable xattr if xattrmap is used Connor Kuehl
2021-05-06 15:52 ` Dr. David Alan Gilbert
2021-05-06 15:55   ` Venegas Munoz, Jose Carlos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANRX0ORJA43.22ADKWIJW7DI0@redhat \
    --to=ckuehl@redhat.com \
    --cc=jose.carlos.venegas.munoz@intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).