From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1304C433E6 for ; Wed, 23 Dec 2020 17:08:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61F43222BB for ; Wed, 23 Dec 2020 17:08:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61F43222BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ks7cj-0003Ju-Bk for qemu-devel@archiver.kernel.org; Wed, 23 Dec 2020 12:08:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ks701-00088U-Aa; Wed, 23 Dec 2020 11:28:29 -0500 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]:38810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ks6zz-0006FY-Pp; Wed, 23 Dec 2020 11:28:29 -0500 Received: by mail-ed1-x52d.google.com with SMTP id cw27so16751065edb.5; Wed, 23 Dec 2020 08:28:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=tp6cAhQ6bC+F9AdbGmF40NgniF1lEuyW8r53rI/N8IU=; b=V7A013Faw3pNvERhCEfeGSpUsjSwG6r5sKy9exZG9U4rY+peKhY63CG8OORdUm0r39 YgfzccKzzJFa33icLC1Gq9W80aTirOqj1yq9L7DiQUo/p2Vhfv8gRgVHTIdZwe9jBQQo mTqp0bRL/cJN893UB5XzXzuOIxNvDPOwFIRJSS3GTJXKe3TG63/LwcRcgKB7pxq5R8mc YCRk5Q+nm6moRX7nIWe6coDrLiLWS9N5uB3I/Y3+D6AqAvjXfMoUtmdooiLGCK6YHvWE nqqBMr+V5Ep6uk++D3fylLuIeI589RMUhCuFnvLVaiTg5ILg0MW7HJ/JzFDjk3f1+Gsa 1dEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=tp6cAhQ6bC+F9AdbGmF40NgniF1lEuyW8r53rI/N8IU=; b=GBC8nczr77xg4Hd3CdwsBnjlL7lFifNeqV2H8xJOueMSB5wdsbhC/Rq5QypZFeXyRZ EFf57P0romBwMneV8DvHEA1E/5Uc1KwmQdU6lS6zFngRH5F9PgkMbV7uV/f10nzZAfIx hR7jF3tCpJIQodPsfIjkPVIUnYzOhE6RH/2SB1Q3FaOqk1kJaEJExv8+3BlMm5OEP6K6 sZVvET/RgqzzDPPTnL3pJffB0cJGzbVPe/kAPt6a95D65lGO7hhA7VxlwdE3Kf3XhkmV mV8v3cj2B0gXaR5FGS4tIE2/SIzqRhO9XYRmlLV5YD9pVigGQXIrIMcdkh/TE/h87U2v HT2A== X-Gm-Message-State: AOAM533JXSHNckcLS2gB597x/AFm7uPpu1ualS1FtQNTa51W94plQsKp zsvqT73oXjaJipWt4qitFgTBwYCKShFfEolHBHlMKI0rtHV9OPLT X-Google-Smtp-Source: ABdhPJw22FaUFN/xLPF3zT5RxluO4CiPxt0zlMqkOK4CQXLs5dm+v8XKoyOPyFDUD8jLMpTu/SfKU5i2uOXwlk+4OeE= X-Received: by 2002:aa7:d5d2:: with SMTP id d18mr26168140eds.126.1608740904744; Wed, 23 Dec 2020 08:28:24 -0800 (PST) MIME-Version: 1.0 From: Sylvain Pelissier Date: Wed, 23 Dec 2020 17:28:13 +0100 Message-ID: Subject: [PATCH] gdb: riscv: Add target description To: qemu-devel@nongnu.org Content-Type: multipart/alternative; boundary="00000000000029bb1505b7242e5f" Received-SPF: pass client-ip=2a00:1450:4864:20::52d; envelope-from=sylvain.pelissier@gmail.com; helo=mail-ed1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 23 Dec 2020 12:06:55 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Palmer Dabbelt , Alistair Francis , qemu-riscv@nongnu.org, Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000029bb1505b7242e5f Content-Type: text/plain; charset="UTF-8" Target description is not currently implemented in RISC-V architecture. Thus GDB won't set it properly when attached. The patch implements the target description response. Signed-off-by: Sylvain Pelissier --- target/riscv/cpu.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 254cd83f8b..489d66038c 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -556,6 +556,15 @@ static Property riscv_cpu_properties[] = { DEFINE_PROP_END_OF_LIST(), }; +static gchar *riscv_gdb_arch_name(CPUState *cs) +{ + #ifdef TARGET_RISCV64 + return g_strdup("riscv:rv64"); + #else + return g_strdup("riscv:rv32"); + #endif +} + static void riscv_cpu_class_init(ObjectClass *c, void *data) { RISCVCPUClass *mcc = RISCV_CPU_CLASS(c); @@ -591,6 +600,7 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data) /* For now, mark unmigratable: */ cc->vmsd = &vmstate_riscv_cpu; #endif + cc->gdb_arch_name = riscv_gdb_arch_name; #ifdef CONFIG_TCG cc->tcg_initialize = riscv_translate_init; cc->tlb_fill = riscv_cpu_tlb_fill; -- 2.25.1 --00000000000029bb1505b7242e5f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Target description is not currently implemented in RI= SC-V architecture. Thus GDB won't set it properly when attached. The pa= tch implements the target description response.

Signed-off-by: Sylvain Pelissier <sylvain.pelissier@gmail.com>
---
=C2=A0target/riscv= /cpu.c | 10 ++++++++++
=C2=A01 file changed, 10 insertions(+)

dif= f --git a/target/riscv/cpu.c b/target/riscv/cpu.c
index 254cd83f8b..489d= 66038c 100644
--- a/target/riscv/cpu.c
+++ b/target/riscv/cpu.c
@@= -556,6 +556,15 @@ static Property riscv_cpu_properties[] =3D {
=C2=A0 = =C2=A0 =C2=A0DEFINE_PROP_END_OF_LIST(),
=C2=A0};
=C2=A0
+static gc= har *riscv_gdb_arch_name(CPUState *cs)
+{
+ =C2=A0 =C2=A0#ifdef TARGE= T_RISCV64
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0return g_strdup("riscv:rv64&= quot;);
+ =C2=A0 =C2=A0#else
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0return g_st= rdup("riscv:rv32");
+ =C2=A0 =C2=A0#endif
+}
+
=C2=A0= static void riscv_cpu_class_init(ObjectClass *c, void *data)
=C2=A0{
= =C2=A0 =C2=A0 =C2=A0RISCVCPUClass *mcc =3D RISCV_CPU_CLASS(c);
@@ -591,6= +600,7 @@ static void riscv_cpu_class_init(ObjectClass *c, void *data)
= =C2=A0 =C2=A0 =C2=A0/* For now, mark unmigratable: */
=C2=A0 =C2=A0 =C2= =A0cc->vmsd =3D &vmstate_riscv_cpu;
=C2=A0#endif
+ =C2=A0 =C2= =A0cc->gdb_arch_name =3D riscv_gdb_arch_name;
=C2=A0#ifdef CONFIG_TCG=
=C2=A0 =C2=A0 =C2=A0cc->tcg_initialize =3D riscv_translate_init;
= =C2=A0 =C2=A0 =C2=A0cc->tlb_fill =3D riscv_cpu_tlb_fill;
--
2.25.= 1

--00000000000029bb1505b7242e5f--