QEMU-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Laurent Vivier <laurent@vivier.eu>
Subject: Re: Build for qemu-sh4 broken since 2445971604c
Date: Sat, 15 Feb 2020 15:01:15 +0100
Message-ID: <CAP+75-V0yQz1H5c8YXZ=6WDXEmxYG1JbxZBDNPLPBzkQ1DPZnw@mail.gmail.com> (raw)
In-Reply-To: <1e7c2c17-1907-cc9d-2bad-071bdd09650e@redhat.com>

On Sat, Feb 15, 2020 at 2:53 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> Hi John,
>
> On 2/15/20 11:53 AM, John Paul Adrian Glaubitz wrote:
> > Hi!
> >
> > Currently trying to build qemu-sh4 in static configuration fails with:
> >
> > make[1]: Entering directory '/root/qemu/slirp'
> > make[1]: Nothing to be done for 'all'.
> > make[1]: Leaving directory '/root/qemu/slirp'
> >    CC      sh4-linux-user/tcg/tcg-op-gvec.o
> > /root/qemu/tcg/tcg-op-gvec.c:298:25: error: unknown type name ‘gen_helper_gvec_5_ptr’; did you mean ‘gen_helper_gvec_4_ptr’?
> >    298 |                         gen_helper_gvec_5_ptr *fn)
> >        |                         ^~~~~~~~~~~~~~~~~~~~~
> >        |                         gen_helper_gvec_4_ptr
> > make[1]: *** [/root/qemu/rules.mak:69: tcg/tcg-op-gvec.o] Error 1
> > make: *** [Makefile:497: sh4-linux-user/all] Error 2
>
> I believe your build directory is out of date and might have dangling
> old files.

FYI the CI job succeeds:
https://travis-ci.org/qemu/qemu/jobs/650567444#L3193

> > This seems to have been introduced with:
> >
> > commit 2445971604c1cfd3ec484457159f4ac300fb04d2
> > Author: Richard Henderson <richard.henderson@linaro.org>
> > Date:   Tue Feb 11 16:31:38 2020 -0800
> >
> >      tcg: Add tcg_gen_gvec_5_ptr
> >
> >      Extend the vector generator infrastructure to handle
> >      5 vector arguments.
> >
> >      Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >      Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> >      Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
> >      Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> If you look the content of this commit, the new type is properly declared:
>
> --- a/include/tcg/tcg-op-gvec.h
> +++ b/include/tcg/tcg-op-gvec.h
> @@ -83,6 +83,13 @@ void tcg_gen_gvec_4_ptr(uint32_t dofs, uint32_t aofs,
> uint32_t bofs,
>                           uint32_t maxsz, int32_t data,
>                           gen_helper_gvec_4_ptr *fn);
>
>                           uint32_t maxsz, int32_t data,
>                           gen_helper_gvec_4_ptr *fn);
>
> +typedef void gen_helper_gvec_5_ptr(TCGv_ptr, TCGv_ptr, TCGv_ptr, TCGv_ptr,
> +                                   TCGv_ptr, TCGv_ptr, TCGv_i32);
> +void tcg_gen_gvec_5_ptr(uint32_t dofs, uint32_t aofs, uint32_t bofs,
> +                        uint32_t cofs, uint32_t eofs, TCGv_ptr ptr,
> +                        uint32_t oprsz, uint32_t maxsz, int32_t data,
> +                        gen_helper_gvec_5_ptr *fn);
> +
>
> BTW what capstone configuration are you using?
> Is that --disable-capstone or another?

OK I understood, Debian provide capstone.a:
https://packages.debian.org/sid/sh4/libcapstone-dev/filelist

and our CI job on Travis is based on Ubuntu, so using --static works:
https://travis-ci.org/qemu/qemu/jobs/650567444

Fedora capstone-devel package only provide a shared library.



  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-15 10:53 John Paul Adrian Glaubitz
2020-02-15 13:53 ` Philippe Mathieu-Daudé
2020-02-15 14:01   ` Philippe Mathieu-Daudé [this message]
2020-02-15 14:12   ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP+75-V0yQz1H5c8YXZ=6WDXEmxYG1JbxZBDNPLPBzkQ1DPZnw@mail.gmail.com' \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

QEMU-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git
	git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \
		qemu-devel@nongnu.org
	public-inbox-index qemu-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git