From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21837C43603 for ; Sat, 14 Dec 2019 21:08:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD7D5214D8 for ; Sat, 14 Dec 2019 21:08:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CkInd3WL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD7D5214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igEeK-0000zJ-Vh for qemu-devel@archiver.kernel.org; Sat, 14 Dec 2019 16:08:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51179) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igEXR-0001rQ-QN for qemu-devel@nongnu.org; Sat, 14 Dec 2019 16:01:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igEXQ-0005Ug-4M for qemu-devel@nongnu.org; Sat, 14 Dec 2019 16:01:21 -0500 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]:35622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igEXP-0005Qs-Rr; Sat, 14 Dec 2019 16:01:20 -0500 Received: by mail-il1-x144.google.com with SMTP id g12so2391745ild.2; Sat, 14 Dec 2019 13:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sXWObjGl6OXDF8vN7Nqi0HgJ+038kWVON6shVGrmC1c=; b=CkInd3WLl4a51MtgtS6zQTWZ7yMlPbWRXrd3iJUTv5NfUuPuapCJ4p0fgebx77p6Yh L9c1mEhLw0aMf5ay7e7ukJghXAaiDmBoYW5XsAYiJoLQM3HimU/MxtkVVPyzP0ZFczHu wSaXXGvUeKjpfuua7BHoB8Q86l/E7AgqJ51SwAMlX7AkmDn7Xevsz6UohOWxtU+OMbVf kkesjzw3qYmczaLkLsqX2B6guPS1LRuRu0wHe35yZrFMUJ4vK2OfBOABj6FXxuZwFIgP 6+Bex16D0CGOnsiB9+BOp6wz6cnyywlRzg7o1eSdrXW8S0uslujVq+tfR1dVkpQSvzo/ zzqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sXWObjGl6OXDF8vN7Nqi0HgJ+038kWVON6shVGrmC1c=; b=CL7ZYI4i/uYP5DostDVPb44Vv1dziospi2Q/tM9DOoPB65GTfn5+mVpLIrHmQ/Pcwu HZzsHurXWXNpgbPfxmNUKCekHQbaJrKE2GaMLd/r7BcQz2m3kjSyDREHgcKzh+D5ndZe AyGh0z3Tn3REIDWYhR7hjw3MsyZvtYIgwxQoLAyjjMrlwNefAOObPIHKm6ykHA8TVfAM 8I6XUprMj7tUaLucrAoeBrv41we7XjDV8pXxyPxP1SBPpDFPIv3ZwvZuXBJoRaOIebT+ jZN3nGDJi8fTM1m3pFYhqpccMgUw9G19P/ibse1BBDzcXpvwILwyKbZub5une/wBy7NH m/Pw== X-Gm-Message-State: APjAAAW9v56kIoO1tnfumdUwytTqf3Y8RH/c8mESC5OuSrVFnvcyp8Be FfvQQgGlhkSUMP2dZTAy3/7BK6NohklDVfHbVpR6xQ== X-Google-Smtp-Source: APXvYqw8q1mlKhmAF2iTgALI0Y9x9CQqCZmXjzTNgOxbnywffKma10PDNXO+RgCD+gX/HQmLS5s/jZNYLfdCkxPPBXs= X-Received: by 2002:a92:d203:: with SMTP id y3mr5682158ily.28.1576355542949; Sat, 14 Dec 2019 12:32:22 -0800 (PST) MIME-Version: 1.0 References: <20191202210947.3603-1-nieklinnenbank@gmail.com> <20191202210947.3603-10-nieklinnenbank@gmail.com> <6bee15d7-7d80-0709-ac90-ef2052b39329@redhat.com> <457e0620-c11e-8e5a-df1c-93f95f52eda8@redhat.com> In-Reply-To: <457e0620-c11e-8e5a-df1c-93f95f52eda8@redhat.com> From: Niek Linnenbank Date: Sat, 14 Dec 2019 21:32:11 +0100 Message-ID: Subject: Re: [PATCH 09/10] arm: allwinner-h3: add SD/MMC host controller To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="0000000000002d63fc0599afe013" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::144 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Beniamino Galvani , Peter Maydell , qemu-arm , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000002d63fc0599afe013 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Dec 14, 2019 at 2:59 PM Philippe Mathieu-Daud=C3=A9 wrote: > On 12/13/19 10:00 PM, Niek Linnenbank wrote: > > On Fri, Dec 13, 2019 at 12:56 AM Philippe Mathieu-Daud=C3=A9 > > > wrote: > > > > Hi Niek, > > > > On 12/11/19 11:34 PM, Niek Linnenbank wrote: > > > Ping! > > > > > > Anyone would like to comment on this driver? > > > > > > I finished the rework on all previous comments in this series. > > > > > > Currently debugging the hflags error reported by Philippe. > > > After that, I'm ready to send out v2 of these patches. > > > > > > Regards, > > > Niek > > > > > > On Mon, Dec 2, 2019 at 10:10 PM Niek Linnenbank > > > > > >= > > > wrote: > > > > > > The Allwinner H3 System on Chip contains an integrated stora= ge > > > controller for Secure Digital (SD) and Multi Media Card (MMC= ) > > > interfaces. This commit adds support for the Allwinner H3 > > > SD/MMC storage controller with the following emulated > features: > > > > > > * DMA transfers > > > * Direct FIFO I/O > > > * Short/Long format command responses > > > * Auto-Stop command (CMD12) > > > * Insert & remove card detection > > > > > > Signed-off-by: Niek Linnenbank > > > > > >> > > > --- > > > hw/arm/allwinner-h3.c | 20 + > > > hw/arm/orangepi.c | 17 + > > > hw/sd/Makefile.objs | 1 + > > > hw/sd/allwinner-h3-sdhost.c | 791 > > ++++++++++++++++++++++++++++ > > > hw/sd/trace-events | 7 + > > > include/hw/arm/allwinner-h3.h | 2 + > > > include/hw/sd/allwinner-h3-sdhost.h | 73 +++ > > > 7 files changed, 911 insertions(+) > > > create mode 100644 hw/sd/allwinner-h3-sdhost.c > > > create mode 100644 include/hw/sd/allwinner-h3-sdhost.h > [...] > > Thanks again for all of your helpful comments Philippe! > > I've started to rework the patch. > > > > One question about adding tags in the commit message: should I > > already add 'Reviewed-by: ' when I re-send v2 of this patch? Or should > > that be added after you have seen the v2 changes? > > You shouldn't add the Reviewed-by tag until explicitly given by the > reviewer. If the changes are trivial, it is easy to conditionally give > the tag such "If ... is done: R-b", "With ... fixed: R-b". > OK, thanks for clarifying, I'll keep that in mind. > > Since this is your first contribution, I have been more careful. Also > since your patch is already of very good quality, I'v been a bit picky > regarding few details. > Sure, that makes sense indeed. And I very much appreciate your feedback Philippe, so please keep doing that, even about the small details ;-) > > Since there are too many comments, so I prefer to fully review the v2 of > this patch again. > > Yes, true indeed. Regards, Niek > Regards, > > Phil. > > --=20 Niek Linnenbank --0000000000002d63fc0599afe013 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, Dec 14, 2019 at 2:59 PM Phili= ppe Mathieu-Daud=C3=A9 <philmd@redh= at.com> wrote:
On 12/13/19 10:00 PM, Niek Linnenbank wrote:
> On Fri, Dec 13, 2019 at 12:56 AM Philippe Mathieu-Daud=C3=A9
> <philmd@redh= at.com <mailto:philmd@redhat.com>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0Hi Niek,
>
>=C2=A0 =C2=A0 =C2=A0On 12/11/19 11:34 PM, Niek Linnenbank wrote:
>=C2=A0 =C2=A0 =C2=A0 > Ping!
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Anyone would like to comment on this driver?<= br> >=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > I finished the rework on all previous comment= s in this series.
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Currently debugging the hflags error reported= by Philippe.
>=C2=A0 =C2=A0 =C2=A0 > After that, I'm ready to send out v2 of t= hese patches.
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > Regards,
>=C2=A0 =C2=A0 =C2=A0 > Niek
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 > On Mon, Dec 2, 2019 at 10:10 PM Niek Linnenba= nk
>=C2=A0 =C2=A0 =C2=A0 > <nieklinnenbank@gmail.com <mailto:nieklinnenbank@gmail.com>
>=C2=A0 =C2=A0 =C2=A0<mailto:nieklinnenbank@gmail.com <mailto:nieklinnenbank@gmail.com>>>
>=C2=A0 =C2=A0 =C2=A0wrote:
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0The Allwinner H3 System on= Chip contains an integrated storage
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0controller for Secure Digi= tal (SD) and Multi Media Card (MMC)
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0interfaces. This commit ad= ds support for the Allwinner H3
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0SD/MMC storage controller = with the following emulated features:
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0* DMA transfers
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0* Direct FIFO I/O >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0* Short/Long format= command responses
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0* Auto-Stop command= (CMD12)
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0* Insert & remo= ve card detection
>=C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Signed-off-by: Niek Linnen= bank <niek= linnenbank@gmail.com
>=C2=A0 =C2=A0 =C2=A0<mailto:nieklinnenbank@gmail.com>
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0<mailto:nieklinnenbank@gmail.com=
>=C2=A0 =C2=A0 =C2=A0<mailto:nieklinnenbank@gmail.com>>>
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0---
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0hw/arm/allwinner-h3= .c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 20 +
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0hw/arm/orangepi.c= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2= =A0 17 +
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0hw/sd/Makefile.objs= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2= =A01 +
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0hw/sd/allwinner-h3-= sdhost.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 791
>=C2=A0 =C2=A0 =C2=A0++++++++++++++++++++++++++++
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0hw/sd/trace-events= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2= =A07 +
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0include/hw/arm/allw= inner-h3.h=C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A02 +
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0include/hw/sd/allwi= nner-h3-sdhost.h |=C2=A0 73 +++
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A07 files changed, 91= 1 insertions(+)
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0create mode 100644 = hw/sd/allwinner-h3-sdhost.c
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0create mode 100644 = include/hw/sd/allwinner-h3-sdhost.h
[...]
> Thanks again for all of your helpful comments Philippe!
> I've started to rework the patch.
>
> One question about adding tags in the commit message: should I
> already add 'Reviewed-by: ' when I re-send v2 of this patch? O= r should
> that be added after you have seen the v2 changes?

You shouldn't add the Reviewed-by tag until explicitly given by the reviewer. If the changes are trivial, it is easy to conditionally give
the tag such "If ... is done: R-b", "With ... fixed: R-b&quo= t;.

OK, thanks for clarifying, I'll= keep that in mind.
=C2=A0

Since this is your first contribution, I have been more careful. Also
since your patch is already of very good quality, I'v been a bit picky =
regarding few details.
=C2=A0
Sure, that mak= es sense indeed. And I very much appreciate your feedback Philippe,
so please keep doing that, even about the small details ;-)
=C2=A0

Since there are too many comments, so I prefer to fully review the v2 of this patch again.

Yes, true indeed.

Regard= s,
Niek
=C2=A0
Regards,

Phil.



--
Niek Linnenbank

--0000000000002d63fc0599afe013--