From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 040C5C43603 for ; Wed, 4 Dec 2019 20:07:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C04E6205ED for ; Wed, 4 Dec 2019 20:07:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jlnALiCZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C04E6205ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icavO-0005hE-M0 for qemu-devel@archiver.kernel.org; Wed, 04 Dec 2019 15:07:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59315) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icafE-0003yV-9E for qemu-devel@nongnu.org; Wed, 04 Dec 2019 14:50:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icafD-00032G-2Y for qemu-devel@nongnu.org; Wed, 04 Dec 2019 14:50:20 -0500 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]:39711) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icafC-0002ys-PY; Wed, 04 Dec 2019 14:50:18 -0500 Received: by mail-il1-x142.google.com with SMTP id a7so668142ild.6; Wed, 04 Dec 2019 11:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I5pUPHYbr0BueGJe7F25s/VFQXDl8+ZiGmqPzGqYpgY=; b=jlnALiCZ9Pzedb7XVTPCJGOgZDTsT2BpiWWDkywevUOm0ns/61Cq7WElbVpLPQeBZD IbszXua3FwaREiCZc/dsXkyxOhRi6mxozA1ODc4NK9RFpYX9hHn4Z/0JUgu6DJ17UE8S 7iLRPNrXfA861gA9oTEEKd46HQc1Dqdbn0jVHYqrJBsPXIDJQdG+H6j/effvSkxTmCyt Mmx7Fk9iRHxL4Q8YZL8lFvGSvsWxd/H/bmHdYb3eZAreKri0TRiZfc5fA2EUurbIkm7F SwztkkL6Cf1qdL1v7AA5JL5ZdEVdAKViuux9o0h+nCiOqhdfUp5y06FqtfzHqLZEqPTH PxyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I5pUPHYbr0BueGJe7F25s/VFQXDl8+ZiGmqPzGqYpgY=; b=CwxY4Z19/IzguWYRpqPGK+jECwm93Di3R+aPnv1gq5QLVDFrw+rs7AEUExcM0f/gqj 8r/NlSYc57LyrtTOi4XS/vUabxe8MXjghl8BkjTe/O8zckjvgJ9KkJVNGxAl1Y36/ave 1xlAUNpOb1s7PkmAZDH1qR4I3yxyoKVZ1Ln9gE5ecPMFhNpeMWTvToobF7aTja/1xXTV Ov6xZqvKLLVRNeyoNuU9p9HF7WI5FJ8whtE133CjVQ1nSnEU7B4lhBwNhyCmHWn7Efxe aRLc+2vaTdx/2pcgsjEzd5NGwj7Hl2WMvLw7uoSSrHm3qId+M35LyzxJvnxcp8WI5qmI i2zQ== X-Gm-Message-State: APjAAAWrX31ArnkW9QUuASJKrRSHU5xpP5pPDSSxSC1PY0uWTv14k8d+ mNbUr+fpwrWk98fT4Qz1lIifTKxKo4NWK91JgLU= X-Google-Smtp-Source: APXvYqygCgdlSpjPHk7b/9w2aYIoxaLOeIq2rzsSj+EihENrU1Utr8ED/QHXVqK0gs2vQY4esecXTUQOVytCgvW8xaE= X-Received: by 2002:a92:5a45:: with SMTP id o66mr4970679ilb.67.1575489017236; Wed, 04 Dec 2019 11:50:17 -0800 (PST) MIME-Version: 1.0 References: <20191202210947.3603-1-nieklinnenbank@gmail.com> <20191202210947.3603-3-nieklinnenbank@gmail.com> <239606dc-3545-c3f7-1e11-429f53994147@redhat.com> In-Reply-To: <239606dc-3545-c3f7-1e11-429f53994147@redhat.com> From: Niek Linnenbank Date: Wed, 4 Dec 2019 20:50:05 +0100 Message-ID: Subject: Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="0000000000003852570598e61f67" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::142 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: b.galvani@gmail.com, Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --0000000000003852570598e61f67 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 4, 2019 at 10:03 AM Philippe Mathieu-Daud=C3=A9 wrote: > On 12/3/19 8:33 PM, Niek Linnenbank wrote: > > Hello Philippe, > > > > Thanks for your quick review comments! > > I'll start working on a v2 of the patches and include the changes you > > suggested. > > Thanks, but I'd suggest to wait few more days to give time to others > reviewers. Else having multiple versions of a big series reviewed at the > same time is very confusing. > I have other minor comments on others patches, but need to find the time > to continue reviewing. > > OK Philippe, I will follow your advise and wait a few more days before submitting a new version. I'll wait at least until you had a chance to review all the patches. I'm new to the QEMU community, so I will need to learn the process along the way. Regards, Niek --=20 Niek Linnenbank --0000000000003852570598e61f67 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Dec 4, 2019 at 10:03 AM Phili= ppe Mathieu-Daud=C3=A9 <philmd@redh= at.com> wrote:
On 12/3/19 8:33 PM, Niek Linnenbank wrote:
> Hello Philippe,
>
> Thanks for your quick review comments!
> I'll start working on a v2 of the patches and include the changes = you
> suggested.

Thanks, but I'd suggest to wait few more days to give time to others reviewers. Else having multiple versions of a big series reviewed at the same time is very confusing.
I have other minor comments on others patches, but need to find the time to continue reviewing.


OK Philippe, I will follow your advi= se and wait a few more days before submitting a new version.
I= 9;ll wait at least until you had a chance to review all the patches. I'= m new to the QEMU
community, so I will need to learn the process = along the way.

Regards,
Niek





--
Niek Linnenbank<= br>
--0000000000003852570598e61f67--