From: Lucas Mateus Martins Araujo e Castro <lucas.araujo@eldorado.org.br>
To: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Bruno Piazera Larsen <bruno.larsen@eldorado.org.br>,
David Gibson <david@gibson.dropbear.id.au>
Subject: target/ppc: sPAPR invalid function calls when compiling without TCG
Date: Wed, 14 Apr 2021 18:28:26 +0000 [thread overview]
Message-ID: <RO1PR80MB56100E30B8B94BB4F733FB07CE4E9@RO1PR80MB5610.lamprd80.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]
Hi, I have been working on billionai's patch to enable the --disable-tcg option on PowerPC and one of the problems is that 5 files in hw/ppc use functions implemented in mmu-hash64.c which is not compiled with --disable-tcg, I'd like to know how to correct the spapr function call, should I
* change the calls to generic functions that should call the correct function based on if kvm is being used or not,
* should I just implement said functions independently of mmu-hash64.c and always call them,
* should I just implement said functions independently of mmu-hash64.c and only call it with --disable-tcg option turned on,
* find a way to not have said calls when compiling without TCG as they're not necessary,
* just create a stub
Here's when each function is called by each .c:
spapr.c:
function do_lpcr_sync call ppc_store_lpcr
spapr_hcall.c:
function h_enter call ppc_hash64_hpte_page_shift_noslb, ppc_hash64_map_hptes and ppc_hash64_unmap_hptes
function remove_hpte call ppc_hash64_map_hptes, ppc_hash64_unmap_hptes and ppc_hash64_tlb_flush_hpte
function h_protect call ppc_hash64_map_hptes, ppc_hash64_unmap_hptes and ppc_hash64_tlb_flush_hpte
function h_read call ppc_hash64_map_hptes and ppc_hash64_unmap_hptes
function rehash_hpte call ppc_hash64_hpte_page_shift_noslb
function rehash_hpt call ppc_hash64_map_hptes and ppc_hash64_unmap_hptes
spapr_rtas.c:
function rtas_start_cpu call ppc_store_lpcr
function rtas_stop_self call ppc_store_lpcr
spapr_spapr_cpu_core.c
function spapr_reset_vcpu call ppc_store_lpcr
function spapr_cpu_set_entry_state call ppc_store_lpcr
spapr_caps.c:
function cap_large_decr_cpu_apply call ppc_store_lpcr
function cap_hpt_maxpagesize_cpu_apply call ppc_hash64_filter_pagesizes
[-- Attachment #2: Type: text/html, Size: 4787 bytes --]
next reply other threads:[~2021-04-14 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 18:28 Lucas Mateus Martins Araujo e Castro [this message]
2021-04-19 5:17 ` target/ppc: sPAPR invalid function calls when compiling without TCG David Gibson
2021-04-19 19:04 Lucas Mateus Martins Araujo e Castro
2021-04-20 0:09 ` David Gibson
2021-04-20 18:27 Lucas Mateus Martins Araujo e Castro
2021-04-21 4:06 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=RO1PR80MB56100E30B8B94BB4F733FB07CE4E9@RO1PR80MB5610.lamprd80.prod.outlook.com \
--to=lucas.araujo@eldorado.org.br \
--cc=bruno.larsen@eldorado.org.br \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).