qemu repo lockdown message for a WHPX PR

qemu repo lockdown message for a WHPX PR

[Sunil Muthuswamy]

Hey Paolo,

Following your suggestion of creating PRs for WHPX changes, I tried creating a PR https://github.com/qemu/qemu/pull/95

But, I am getting repo-lockdown message. What do I need to do differently?

Thanks,
Sunil

RE: qemu repo lockdown message for a WHPX PR

[Sunil Muthuswamy]

Adding Peter Maydell as well.

> -----Original Message-----
> From: Sunil Muthuswamy
> Sent: Tuesday, July 28, 2020 12:20 PM
> To: Paolo Bonzini <bonzini@gnu.org>
> Cc: qemu-devel@nongnu.org
> Subject: qemu repo lockdown message for a WHPX PR
> 
> Hey Paolo,
> 
> Following your suggestion of creating PRs for WHPX changes, I tried creating a PR https://github.com/qemu/qemu/pull/95
> 
> But, I am getting repo-lockdown message. What do I need to do differently?
> 
> Thanks,
> Sunil

Re: qemu repo lockdown message for a WHPX PR

[Eric Blake]

On 7/29/20 3:05 PM, Sunil Muthuswamy wrote:
> Adding Peter Maydell as well.
> 
>> -----Original Message-----
>> From: Sunil Muthuswamy
>> Sent: Tuesday, July 28, 2020 12:20 PM
>> To: Paolo Bonzini <bonzini@gnu.org>
>> Cc: qemu-devel@nongnu.org
>> Subject: qemu repo lockdown message for a WHPX PR
>>
>> Hey Paolo,
>>
>> Following your suggestion of creating PRs for WHPX changes, I tried creating a PR https://github.com/qemu/qemu/pull/95
>>
>> But, I am getting repo-lockdown message. What do I need to do differently?

Are you trying to submit a patch?  If so, we prefer submissions to the 
mailing list rather than via github pull requests:

https://wiki.qemu.org/Contribute/SubmitAPatch

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

RE: [EXTERNAL] Re: qemu repo lockdown message for a WHPX PR

[Sunil Muthuswamy]

No, I am trying to submit a pull request as suggested by Paolo in this post:
https://patchwork.ozlabs.org/project/qemu-devel/patch/SN4PR2101MB08804D23439166E81FF151F7C0EA0@SN4PR2101MB0880.namprd21.prod.outlook.com/#2373829

> -----Original Message-----
> From: Eric Blake <eblake@redhat.com>
> Sent: Wednesday, July 29, 2020 1:19 PM
> To: Sunil Muthuswamy <sunilmut@microsoft.com>; Paolo Bonzini <bonzini@gnu.org>; Peter Maydell <peter.maydell@linaro.org>
> Cc: qemu-devel@nongnu.org
> Subject: [EXTERNAL] Re: qemu repo lockdown message for a WHPX PR
> 
> On 7/29/20 3:05 PM, Sunil Muthuswamy wrote:
> > Adding Peter Maydell as well.
> >
> >> -----Original Message-----
> >> From: Sunil Muthuswamy
> >> Sent: Tuesday, July 28, 2020 12:20 PM
> >> To: Paolo Bonzini <bonzini@gnu.org>
> >> Cc: qemu-devel@nongnu.org
> >> Subject: qemu repo lockdown message for a WHPX PR
> >>
> >> Hey Paolo,
> >>
> >> Following your suggestion of creating PRs for WHPX changes, I tried creating a PR
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fqemu%2Fqemu%2Fpull%2F95&amp;data=
> 02%7C01%7Csunilmut%40microsoft.com%7C3ece52c2861c48c5b2dc08d833fc9cfb%7C72f988bf86f141af91ab2d7cd011db47%7C
> 1%7C0%7C637316507344298308&amp;sdata=MDGK%2FX37j5Qh%2F%2FDoqMmmiiqZmPvXs34YHPkojrNyHRA%3D&amp;reserv
> ed=0
> >>
> >> But, I am getting repo-lockdown message. What do I need to do differently?
> 
> Are you trying to submit a patch?  If so, we prefer submissions to the
> mailing list rather than via github pull requests:
> 
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwiki.qemu.org%2FContribute%2FSubmitAPatch&amp;data
> =02%7C01%7Csunilmut%40microsoft.com%7C3ece52c2861c48c5b2dc08d833fc9cfb%7C72f988bf86f141af91ab2d7cd011db47%7
> C1%7C0%7C637316507344298308&amp;sdata=Wp0yfpcLH%2FF8%2F%2BGARQSwFb3ZxlYSuo5SVUMplmTBxfk%3D&amp;reserve
> d=0
> 
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org

Re: qemu repo lockdown message for a WHPX PR

[Paolo Bonzini]

On 28/07/20 21:19, Sunil Muthuswamy wrote:
> Hey Paolo,
> 
> Following your suggestion of creating PRs for WHPX changes, I tried creating a PR https://github.com/qemu/qemu/pull/95
> 
> But, I am getting repo-lockdown message. What do I need to do differently?

Hi,

I was not referring to github pull requests, but rather to a maintainer
pull request.  This is also sent to the mailing list.  There is no
QEMU-specific documentation since maintainers are generally experienced
enough to have observed how these are sent, but the Linux documentation
more or less applies:
https://www.kernel.org/doc/html/latest/maintainer/pull-requests.html

In any case, I suspect this misunderstanding is a sign that I should be
handling WHPX patches for some more time, which I will gladly do. :)

Thanks!

Paolo

Re: qemu repo lockdown message for a WHPX PR

[Peter Maydell]

On Wed, 29 Jul 2020 at 21:29, Paolo Bonzini <bonzini@gnu.org> wrote:
> I was not referring to github pull requests, but rather to a maintainer
> pull request.  This is also sent to the mailing list.  There is no
> QEMU-specific documentation since maintainers are generally experienced
> enough to have observed how these are sent

We do have some notes on the wiki:
https://wiki.qemu.org/Contribute/SubmitAPullRequest
but they're more in the nature of points to check assuming
you have a basic understanding of the workflow rather than
a complete tutorial.

thanks
-- PMM

RE: [EXTERNAL] Re: qemu repo lockdown message for a WHPX PR

[Sunil Muthuswamy]

> 
> I was not referring to github pull requests, but rather to a maintainer
> pull request.  This is also sent to the mailing list.  There is no
> QEMU-specific documentation since maintainers are generally experienced
> enough to have observed how these are sent, but the Linux documentation
> more or less applies:
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.kernel.org%2Fdoc%2Fhtml%2Flatest%2Fmaintainer%
> 2Fpull-
> requests.html&data=02%7C01%7Csunilmut%40microsoft.com%7Cf67d260b255a455cfa1c08d833fdf333%7C72f988bf86f141
> af91ab2d7cd011db47%7C1%7C0%7C637316513089781442&sdata=Kb4ZOLUxfq7kwrECGdyqKpeFX9SnIHSQcak64aVANYs%3
> D&reserved=0
> 
> In any case, I suspect this misunderstanding is a sign that I should be
> handling WHPX patches for some more time, which I will gladly do. :)
> 
> Thanks!
> 
> Paolo
Thanks for the links. I think I understand it. The idea is to host a public WHPX qemu branch in my qemu github fork, host
all the signed-off WHPX patches there and every now and then, generate a 'pull-request' to merge those patches back to upstream.
Does that align with the expectation here?