From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD75C2B9F4 for ; Tue, 22 Jun 2021 14:26:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DC83600D3 for ; Tue, 22 Jun 2021 14:26:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DC83600D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvhLv-0006Ua-Al for qemu-devel@archiver.kernel.org; Tue, 22 Jun 2021 10:26:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39634) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvhL4-0005mV-6p for qemu-devel@nongnu.org; Tue, 22 Jun 2021 10:25:18 -0400 Received: from de-smtp-delivery-102.mimecast.com ([194.104.111.102]:56281) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvhL1-0002pv-91 for qemu-devel@nongnu.org; Tue, 22 Jun 2021 10:25:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1624371913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WqFqGx3HL6tKDw3tOobwkuzu46F0fPAJWd0h9nRMIGI=; b=Ws8Zr3Ai1Ma2ihaANYxGgkBRJo1R8rWEPLZGq4pNXyyGfD5jClbxY+Z4tCt9wl2+myghbt HugEwLr5+fd/Abd9UUqbBMGM3ykOiOhkZkZ48PqHspMqy3vX6UxZx/h82UoZuai6UqJv8g FdN5/q7hkawaT+A66sn0aG5pJKJWC+E= Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-18-s1CGybPRM9mqfaMo37iVvA-2; Tue, 22 Jun 2021 16:25:12 +0200 X-MC-Unique: s1CGybPRM9mqfaMo37iVvA-2 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lbOGBBXtZF4to3Mr4LWp+pDO2JQiiLIWFjXydOCypBtnjIRxOTKL9BZEB6BNf5z2qQiAcliZazj2nhgBKT1FSmip+tM528SaU1a37P4ezYvHJZrLjfAUWXkTw+StrtJWprIUPguxBnOhg0X9LuSDsMChSQ7UAlifJFeJFKf0A8HlXwhOXHizVEKxWnQ3Ov9MM2MaQs8TfO6LlHXGZ6BOAfQZO10lk27YOV69wm1+vkOn1VffN6lq9bdwuQnyDJbMN/2TjD38+CJHnWNSIx6zFJKKfpwI/vwfc35UGGSo0HF+qEW0WGRFOSemIePEgk+1PE0owr3J+rfgMGU2AGYegQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WqFqGx3HL6tKDw3tOobwkuzu46F0fPAJWd0h9nRMIGI=; b=cgYGasDJk/oojjOMoXhcqLR/bogToqr6i9MhAcb68MMLqJ7l208MRbJiKrwrM/zmnuO9+UI8s9GSl6yTTpc56IwZKM+yjAKNKLHwjNLMfzECxU3ZkcHXx7DbTsmpetgR8ZQ5u6ZX3Qd/IMyhECVxFgrM8fpw2N0s2WWYBfV09KMDcRKH3hkWBu+9ck2cGAPQ95qRaEbUPDWV3DTCnDMhUjfDSKrOx5SDs9zNT4dxi12T2juqigAB5hvPL3THq5izE9q9MNZn/rBw/oVjV15HX8Sgo08sGmwQd0LXO7FfJph9+Ty49LHevHuZNrflp4gyGzVnaz0ALoKNvjlyiHi+DA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VI1PR0402MB3744.eurprd04.prod.outlook.com (2603:10a6:803:16::25) by VI1PR04MB6319.eurprd04.prod.outlook.com (2603:10a6:803:f5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.22; Tue, 22 Jun 2021 14:25:07 +0000 Received: from VI1PR0402MB3744.eurprd04.prod.outlook.com ([fe80::28dc:6111:d2dd:4777]) by VI1PR0402MB3744.eurprd04.prod.outlook.com ([fe80::28dc:6111:d2dd:4777%3]) with mapi id 15.20.4242.023; Tue, 22 Jun 2021 14:25:07 +0000 From: Al Cho To: Cornelia Huck , "qemu-devel@nongnu.org" , "qemu-s390x@nongnu.org" CC: Claudio Fontana Subject: Re: [RFC v5 09/13] target/s390x: make helper.c sysemu-only Thread-Topic: [RFC v5 09/13] target/s390x: make helper.c sysemu-only Thread-Index: AQHXZ0/8V4AtPUsDkUWbElf6hG59o6sf6LYAgAAq+h4= Date: Tue, 22 Jun 2021 14:25:07 +0000 Message-ID: References: <20210622101726.20860-1-acho@suse.com> <20210622101726.20860-10-acho@suse.com>,<87a6ninn1b.fsf@redhat.com> In-Reply-To: <87a6ninn1b.fsf@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=suse.com; x-originating-ip: [1.169.30.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 357af9e5-6262-4b00-6cc9-08d9358988cd x-ms-traffictypediagnostic: VI1PR04MB6319: x-ld-processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1417; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EEaUQ0zTIwfCA4gnV/t8xfnqX0cjVDed0W5PDSFC/3NCg+u9r99X3xxAqKTgsRSXaYBEJiORbclK5teHBjzfzJEQWRZzaaursUtR1jKrpst2ZjrUKkbrHzdtx3zMtbBEae74i2EF1OEkh6o8zoqFSCPmv7ZCjEaiJp4Fr9mcBEkU2zwsktNN1aEjlFXXkCvTIDN/pRdNr+QipMW9o18Xwjqojuw9CQYBGNYY06iG8KswWpeq7gLJRxIeEqdjAeptuHiZVjlS9uKzbdvl/v0A3c1nSWZPMF6TysmP9+DNrduq9fCvSvWbUsGmLztjoXRdH2mLXEtif6dI+EEyqOWEUmHMjtx7JfqjAca/0ITJqeilhnVIXDYgO1Ult3ryOxpdEZUAP33zm2x9v4ZiQlVU3Nc6Uc/7A+4yuR7IacZAfNnvq+ajrqZdpMr3N/75wbK82KK7UwYmiLl6SoufAXBZ0ZraW1dwMB48wmLK+LdTtvwJB14RENqewY5Ub5qRx+HugkzCjpgYC3g/mIIVMOwyTkfzU8We1jHdAKsaqedZroMfJkD8iWnm50kc9JHXjEP0ohawFjPMzSFT4a3ByhyAhdkLqBbJYwpT/uch1gR3LW4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3744.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(39850400004)(136003)(376002)(346002)(366004)(396003)(2906002)(19627405001)(86362001)(8936002)(110136005)(7696005)(26005)(38100700002)(316002)(186003)(53546011)(4326008)(8676002)(55016002)(122000001)(64756008)(6506007)(33656002)(9686003)(107886003)(478600001)(5660300002)(66446008)(83380400001)(66476007)(66556008)(91956017)(76116006)(71200400001)(52536014)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YRFh/NP+bLNuFUKK4MtI/aeo12OUBj/bFABPetpUmEEBLJKNQ+Z3vBE4YuIA?= =?us-ascii?Q?8EvLtiJAum+0AO2sOgH510dGWSshQr1PpNFP8UrIyH4CUTbqanhR2tA/+I8A?= =?us-ascii?Q?Ghhf9zNwwHND4YnnAqhPnKeqkNJlDNMrb4lgOa6aC+MhrFbICp0Ts5MTncZT?= =?us-ascii?Q?408RzH+8mI+qNkEVbollNaK1nV+THk434/I3lBHOjvJqCofOh4+XGUqb4u1o?= =?us-ascii?Q?9vLnVy5RaqqnNBr5HW779mheWbulZKNtaLzC1Pn1iVogVU8DUH83oNr7hcZf?= =?us-ascii?Q?nm8TN+r9/cLjY07DiXN3FHvcEKTyQ5AWW1s4QawaZ4ENDet+6JIj2gQaFQYv?= =?us-ascii?Q?/ReSNOo6ONWic5FMYmL6UIDlCouvRyk0KkDoQi+2MxHZ5l/aWe6uFbTYtM9q?= =?us-ascii?Q?ykLJRq8c6O8UsGbhQBc5adtmr4Tq0D0ZsFNrD9XpzgX9OnHh4Rjj4fVR9AU3?= =?us-ascii?Q?6QbyXL60ZmcvOsCTZtQ1+Fr9R/C9qz03hUqtz8sbtGCilicXVOUrKRFcBVdf?= =?us-ascii?Q?Lq3X1L2lhrWQPlQ6oejBxlNGZnsm5nx2TWZ0F/yIhtlUs13/fE8bjNTMuanF?= =?us-ascii?Q?p63Ho6QysPcRlN7mrTQHiVyr+j1Ose4s0fsoUKuakjXoaPzwh7tIbuh/b1Iq?= =?us-ascii?Q?726ZOTz1lAAhzxegjfnQfh76ZIxMMxLDLlzqK1PnEyKnuu1/N84k6M8Vb+y4?= =?us-ascii?Q?tdXM0gtqqcdtMVVb2UqZAUi6EZ/cWwiQrZsQP59Oa/chJcTWp7dTnzplgtz1?= =?us-ascii?Q?cGW3ClZu7vWO9cNWFeSOVxeMDQc/i4veEF5RltAIKlfQb2nQihNN0O3vS03V?= =?us-ascii?Q?ABLj4KMCJF1NLfiVIHF5DIbPpEUogNnuN1NJGNTyelHDSzMAiPQHF8NfpH8H?= =?us-ascii?Q?I8vKuuCvDQIh4d4YT02BSig1UHLXH4zYD80dX5JoJ6HISZP/YCI51A0L1xvi?= =?us-ascii?Q?4DL2GOQ9z7YQrC8nUC3XZoTVLORCanw/4Z98h1Dc+SLpd/E18o5L3Dmo4038?= =?us-ascii?Q?kixmE3TAWn9wo39cY7YtgqFmvgaOYMO1SFBjoho3YxIwP2EsycXU8/czyzqG?= =?us-ascii?Q?GQRfUkEAqZTEGgwQOJPe0h7/1TNkRP60jRHaE8QPVILdgN1dNoloC/FBdn6F?= =?us-ascii?Q?wdQlKmAhhpaHb/KS7jCjfAM4WdmFPAjnS8fWVCSumPaYocq2mma3PD8SxjDN?= =?us-ascii?Q?b0uQg1zTAfKDoQsOaYVHx4m+vmDHxwSdSVE0HUI/IZC+RvkzPIe+/oLiwIBa?= =?us-ascii?Q?xzqSvUaAr/O1+jARpr8AL0j/oJWJe5qORWpJrK2thIGwUlPWWprbM0mZZCP+?= =?us-ascii?Q?PQI=3D?= Content-Type: multipart/alternative; boundary="_000_VI1PR0402MB3744FB77876CACA6EADDE4BAA0099VI1PR0402MB3744_" MIME-Version: 1.0 X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3744.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 357af9e5-6262-4b00-6cc9-08d9358988cd X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2021 14:25:07.0702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ER95gsClHT4oFcmX5RFnbYZ7Ea5lZTcn1rl/yjTwm6gn1m2IVePzmTSOOUNs2UHV X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6319 Received-SPF: pass client-ip=194.104.111.102; envelope-from=acho@suse.com; helo=de-smtp-delivery-102.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --_000_VI1PR0402MB3744FB77876CACA6EADDE4BAA0099VI1PR0402MB3744_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, it should be "sysemu", it's a typo. ________________________________ From: Cornelia Huck Sent: Tuesday, June 22, 2021 7:42 PM To: Al Cho ; qemu-devel@nongnu.org ; = qemu-s390x@nongnu.org Cc: Claudio Fontana ; Al Cho ; Cla= udio Fontana Subject: Re: [RFC v5 09/13] target/s390x: make helper.c sysemu-only On Tue, Jun 22 2021, "Cho, Yu-Chen" wrote: > Now that we have moved cpu-dump functionality out of helper.c, > we can make the module sysemu-only. > > Signed-off-by: Claudio Fontana > Signed-off-by: Cho, Yu-Chen > Acked-by: Cornelia Huck > --- > target/s390x/helper.c | 6 +----- > target/s390x/meson.build | 2 +- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/target/s390x/helper.c b/target/s390x/helper.c > index 41ccc83d11..b9d18325bc 100644 > --- a/target/s390x/helper.c > +++ b/target/s390x/helper.c > @@ -1,5 +1,5 @@ > /* > - * S/390 helpers > + * S/390 helpers - systemu only Typo -- you probably meant "sysemu"? (Although I'd probably spell it out as "system emulation".) > * > * Copyright (c) 2009 Ulrich Hecht > * Copyright (c) 2011 Alexander Graf --_000_VI1PR0402MB3744FB77876CACA6EADDE4BAA0099VI1PR0402MB3744_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Yes, it should be "sysemu", it's a typo.
From: Cornelia Huck <coh= uck@redhat.com>
Sent: Tuesday, June 22, 2021 7:42 PM
To: Al Cho <ACho@suse.com>; qemu-devel@nongnu.org <qemu-dev= el@nongnu.org>; qemu-s390x@nongnu.org <qemu-s390x@nongnu.org>
Cc: Claudio Fontana <Claudio.Fontana@suse.com>; Al Cho <ACh= o@suse.com>; Claudio Fontana <cfontana@suse.de>
Subject: Re: [RFC v5 09/13] target/s390x: make helper.c sysemu-only<= /font>
 
On Tue, Jun 22 2021, "Cho, Yu-Chen" <= acho@suse.com> wrote:

> Now that we have moved cpu-dump functionality out of helper.c,
> we can make the module sysemu-only.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Signed-off-by: Cho, Yu-Chen <acho@suse.com>
> Acked-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  target/s390x/helper.c    | 6 +-----
>  target/s390x/meson.build | 2 +-
>  2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/target/s390x/helper.c b/target/s390x/helper.c
> index 41ccc83d11..b9d18325bc 100644
> --- a/target/s390x/helper.c
> +++ b/target/s390x/helper.c
> @@ -1,5 +1,5 @@
>  /*
> - *  S/390 helpers
> + *  S/390 helpers - systemu only

Typo -- you probably meant "sysemu"? (Although I'd probably spell= it out
as "system emulation".)

>   *
>   *  Copyright (c) 2009 Ulrich Hecht
>   *  Copyright (c) 2011 Alexander Graf

--_000_VI1PR0402MB3744FB77876CACA6EADDE4BAA0099VI1PR0402MB3744_--