From: Klaus Jensen <its@irrelevant.dk>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
mreitz@redhat.com, kbusch@kernel.org, philmd@redhat.com
Subject: Re: [PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning
Date: Thu, 14 Jan 2021 09:23:38 +0100 [thread overview]
Message-ID: <X///ilbA0MgGVa7/@apples.localdomain> (raw)
In-Reply-To: <20210114072251.334304-5-pizhenwei@bytedance.com>
[-- Attachment #1: Type: text/plain, Size: 3938 bytes --]
On Jan 14 15:22, zhenwei pi wrote:
> During smart critical warning injection by setting property from QMP
> command, also try to trigger asynchronous event.
>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> hw/block/nvme.c | 47 ++++++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 40 insertions(+), 7 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index ce9a9c9023..1feb603471 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -847,6 +847,36 @@ static void nvme_enqueue_event(NvmeCtrl *n, uint8_t event_type,
> nvme_process_aers(n);
> }
>
> +static void nvme_enqueue_smart_event(NvmeCtrl *n, uint8_t event)
Maybe rename to just nvme_smart_event, since it is conditional if it
enqueues anything.
> +{
> + uint8_t aer_info;
> +
> + if (!(NVME_AEC_SMART(n->features.async_config) & event)) {
> + return;
> + }
> +
> + /* Ref SPEC <Asynchronous Event Information ??? SMART / Health Status> */
> + switch (event) {
> + case NVME_SMART_SPARE:
> + aer_info = NVME_AER_INFO_SMART_SPARE_THRESH;
> + break;
> + case NVME_SMART_TEMPERATURE:
> + aer_info = NVME_AER_INFO_SMART_TEMP_THRESH;
> + break;
> + case NVME_SMART_RELIABILITY:
> + case NVME_SMART_MEDIA_READ_ONLY:
> + case NVME_SMART_FAILED_VOLATILE_MEDIA:
> + aer_info = NVME_AER_INFO_SMART_RELIABILITY;
> + break;
> + case NVME_SMART_PMR_UNRELIABLE:
> + /* TODO if NVME_SMART_PMR_UNRELIABLE is defined in future */
Doesn't NVME_SMART_PMR_UNRELIABLE fall under the
NVME_AER_INFO_SMART_RELIABILITY SMART/Health information group? The spec
says that the PMR becoming unreliable can cause an AEN, so I think that
is the only group that is usable.
> + default:
> + return;
> + }
> +
> + nvme_enqueue_event(n, NVME_AER_TYPE_SMART, aer_info, NVME_LOG_SMART_INFO);
> +}
> +
> static void nvme_clear_events(NvmeCtrl *n, uint8_t event_type)
> {
> n->aer_mask &= ~(1 << event_type);
> @@ -1824,12 +1854,9 @@ static uint16_t nvme_set_feature(NvmeCtrl *n, NvmeRequest *req)
> return NVME_INVALID_FIELD | NVME_DNR;
> }
>
> - if (((n->temperature >= n->features.temp_thresh_hi) ||
> - (n->temperature <= n->features.temp_thresh_low)) &&
> - NVME_AEC_SMART(n->features.async_config) & NVME_SMART_TEMPERATURE) {
> - nvme_enqueue_event(n, NVME_AER_TYPE_SMART,
> - NVME_AER_INFO_SMART_TEMP_THRESH,
> - NVME_LOG_SMART_INFO);
> + if ((n->temperature >= n->features.temp_thresh_hi) ||
> + (n->temperature <= n->features.temp_thresh_low)) {
> + nvme_enqueue_smart_event(n, NVME_AER_INFO_SMART_TEMP_THRESH);
> }
>
> break;
> @@ -2841,7 +2868,7 @@ static void nvme_set_smart_warning(Object *obj, Visitor *v, const char *name,
> void *opaque, Error **errp)
> {
> NvmeCtrl *s = NVME(obj);
> - uint8_t value, cap = 0;
> + uint8_t value, cap = 0, event;
> uint64_t pmr_cap = CAP_PMR_MASK;
>
> if (!visit_type_uint8(v, name, &value, errp)) {
> @@ -2860,6 +2887,12 @@ static void nvme_set_smart_warning(Object *obj, Visitor *v, const char *name,
> }
>
> s->smart_critical_warning = value;
> +
> + /* test each bit of uint8_t for smart.critical_warning */
> + for (event = 0; event < 8; event++) {
> + if (value & (1 << event))
> + nvme_enqueue_smart_event(s, 1 << event);
> + }
I suggest you add a NVME_SMART_WARN_MAX to the NvmeSmartWarn enum with
value '6' and use that instead of the literal '8'.
> }
>
> static const VMStateDescription nvme_vmstate = {
> --
> 2.25.1
>
>
--
One of us - No more doubt, silence or taboo about mental illness.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-14 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 7:22 [PATCH v3 0/4] support NVMe smart critial warning injection zhenwei pi
2021-01-14 7:22 ` [PATCH v3 1/4] block/nvme: introduce bit 5 for critical warning zhenwei pi
2021-01-14 7:22 ` [PATCH v3 2/4] hw/block/nvme: fix overwritten bar.cap zhenwei pi
2021-01-14 8:24 ` Klaus Jensen
2021-01-14 7:22 ` [PATCH v3 3/4] hw/block/nvme: add smart_critical_warning property zhenwei pi
2021-01-14 8:29 ` Klaus Jensen
2021-01-14 15:55 ` Philippe Mathieu-Daudé
2021-01-14 22:23 ` Keith Busch
2021-01-14 7:22 ` [PATCH v3 4/4] hw/blocl/nvme: trigger async event during injecting smart warning zhenwei pi
2021-01-14 8:23 ` Klaus Jensen [this message]
2021-01-14 15:57 ` Philippe Mathieu-Daudé
2021-01-14 22:29 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X///ilbA0MgGVa7/@apples.localdomain \
--to=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).