On Mon, Feb 15, 2021 at 04:06:45PM -0300, Willian Rampazzo wrote: > On Wed, Feb 3, 2021 at 2:24 PM Cleber Rosa wrote: > > > > This is basically the infrastructure around "boot_linux.py" tests, but > > now made into a base class for general use. > > > > Signed-off-by: Cleber Rosa > > --- > > tests/acceptance/avocado_qemu/__init__.py | 87 +++++++++++++++++++++ > > tests/acceptance/boot_linux.py | 94 ++--------------------- > > tests/acceptance/virtiofs_submounts.py | 6 +- > > 3 files changed, 94 insertions(+), 93 deletions(-) > > > > diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py > > index bf54e419da..b06692a59d 100644 > > --- a/tests/acceptance/avocado_qemu/__init__.py > > +++ b/tests/acceptance/avocado_qemu/__init__.py > > I found it not so intuitive to have the base class defined here. I see > the number of base classes for the tests growing in the future. A > common place for base classes for tests would be better, just like the > `qemu.utils` you are defining somewhere else. Anyway, this is a design > decision that can be changed later, so > Hi Willian, I tend to agree, and my medium/long term vision is similar. What I expect to be able to do soon (this is connected to John's work) is to have "avocado_qemu" as something like "qemu.testing.functional" which describe its Avocado (and other) dependencies. A "qemu.test.other" could describe its own dependencies (which may not include Avocado). > Reviewed-by: Willian Rampazzo > > Thanks for the review, - Cleber.