From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A42FC433E0 for ; Tue, 16 Feb 2021 03:22:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EC8364DB1 for ; Tue, 16 Feb 2021 03:22:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EC8364DB1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lBqwZ-0004H3-IB for qemu-devel@archiver.kernel.org; Mon, 15 Feb 2021 22:22:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lBqve-0003q6-JG for qemu-devel@nongnu.org; Mon, 15 Feb 2021 22:21:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:49492) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lBqvd-0005sb-0O for qemu-devel@nongnu.org; Mon, 15 Feb 2021 22:21:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613445690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/pfYHT+3QnW1z7fKX6VJRZaDsnldOn6YcPQlaB6VDFY=; b=R6HzSubN7AG/g8y98BqXaiHSCW9x8piy/D6UTh3UFgfu/XYrJuI2v3lA5Fuc9yq2tNn1hE BWv4vWmVV7+V8mdPLaPKU4Z39t7PuFjq/RIWUexweMzBtoaehbPhpk7PGJq1TIDq2l2/a8 WZU35VvjgUPw8kZvEvpmh+VDd0clPXg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-rqtFXjZ1OVmerl8UoZL_nw-1; Mon, 15 Feb 2021 22:21:27 -0500 X-MC-Unique: rqtFXjZ1OVmerl8UoZL_nw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B5931E561; Tue, 16 Feb 2021 03:21:26 +0000 (UTC) Received: from localhost.localdomain (ovpn-2-24.rdu2.redhat.com [10.22.2.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 503431F0; Tue, 16 Feb 2021 03:21:18 +0000 (UTC) Date: Mon, 15 Feb 2021 22:21:16 -0500 From: Cleber Rosa To: Willian Rampazzo Subject: Re: [PATCH 14/22] Acceptance Tests: introduce LinuxTest base class Message-ID: References: <20210203172357.1422425-1-crosa@redhat.com> <20210203172357.1422425-15-crosa@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=crosa@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q6QDgBNaCibT2IEG" Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=crosa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Aleksandar Rikalo , Beraldo Leal , John Snow , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , qemu-devel , Wainer dos Santos Moschetta , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Eric Auger , Thomas Huth , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Max Reitz , Alex =?iso-8859-1?Q?Benn=E9e?= , Aurelien Jarno , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --q6QDgBNaCibT2IEG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 15, 2021 at 04:06:45PM -0300, Willian Rampazzo wrote: > On Wed, Feb 3, 2021 at 2:24 PM Cleber Rosa wrote: > > > > This is basically the infrastructure around "boot_linux.py" tests, but > > now made into a base class for general use. > > > > Signed-off-by: Cleber Rosa > > --- > > tests/acceptance/avocado_qemu/__init__.py | 87 +++++++++++++++++++++ > > tests/acceptance/boot_linux.py | 94 ++--------------------- > > tests/acceptance/virtiofs_submounts.py | 6 +- > > 3 files changed, 94 insertions(+), 93 deletions(-) > > > > diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptan= ce/avocado_qemu/__init__.py > > index bf54e419da..b06692a59d 100644 > > --- a/tests/acceptance/avocado_qemu/__init__.py > > +++ b/tests/acceptance/avocado_qemu/__init__.py >=20 > I found it not so intuitive to have the base class defined here. I see > the number of base classes for the tests growing in the future. A > common place for base classes for tests would be better, just like the > `qemu.utils` you are defining somewhere else. Anyway, this is a design > decision that can be changed later, so > Hi Willian, I tend to agree, and my medium/long term vision is similar. What I expect to be able to do soon (this is connected to John's work) is to have "avocado_qemu" as something like "qemu.testing.functional" which describe its Avocado (and other) dependencies. A "qemu.test.other" could describe its own dependencies (which may not include Avocado). > Reviewed-by: Willian Rampazzo >=20 >=20 Thanks for the review, - Cleber. --q6QDgBNaCibT2IEG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEeruW64tGuU1eD+m7ZX6NM6XyCfMFAmArOikACgkQZX6NM6Xy CfOakQ/+PHo1D1FOr3f520aIqVzW/h78P9kitXa6mr53TuMhhJwKx6u8Rdgbt0KF oTmvmV9pUadAvEi3ggh6C4AJAzQMx9OLdIv4Q0I7YR+lBNNmwXD4cq0dMFY56W7Y o+1Wkg8QPD8NpCfSxmQHKholZCirXqKKr3zuIqmDChcC00/Ka0Kep4qoU0CoMquX HMq/lCyq3wg80si/doniGaw9c3oztzoquDxrjXbjw591/hhDUxyophOtQ5rQLsBH gw3dkaDDjb+SObdaeWySSYRXTVfSTWqa4B4qrvVYgATzU3inBOMJqwVHUERiXvnb gLQtfcVUiLXiJSIjQy93DjSrKob8rXLWNR+smUzn9FN5bLvQv9XIbuUCSlio2fik f4EWczjyDKRW8AXGL91ZDwX/oyDtxu23XIAlGWAy+k/wvi27xFmXkGyFjVGHf1P0 dV3MmF2zMQihrWL0+hweddg4MuzyH8yb+pt6yAVRlN0AeydSxD/V7FHmwC5jPM9f unoYU3feBhgHtmhc8yv+oPHwX7dGTJXXe7J3mATZLjMgbfs2w46uRy02o5UTEZ6j B/u3R9LDOIe4i/JNc3JrdJkeu6/eFhGuSQ2DGeT1n0radEjFCsmSDx9CcpPZvY4M ix16IA7AT1ekrqYsPknZzce/yjNmueWRXVzLYooRApXl0BWzO8M= =4XHU -----END PGP SIGNATURE----- --q6QDgBNaCibT2IEG--