From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 194ACC433E0 for ; Mon, 22 Feb 2021 15:41:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A87064DAF for ; Mon, 22 Feb 2021 15:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A87064DAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEDLK-0008J8-JB for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 10:41:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEDIx-00062T-Eo for qemu-devel@nongnu.org; Mon, 22 Feb 2021 10:39:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:38908) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEDIv-0004KS-Ec for qemu-devel@nongnu.org; Mon, 22 Feb 2021 10:39:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614008360; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=9j62aM5H5BJGL+SjVw/6zScYbqYmc9RTg+zQdyK2LGA=; b=DdfyLOH9BcAnonzQgkzNDBXCH3uywkdUX7fJRjhbm8rvG7OEppWKj/JQxbOlDR3NFIoW3l E8sMqpEoP2xstU9Uu/eSCpUPAfhQnJqKhJWg/k0sWSoOHKJ2lT4gIoypm1KNIa4H1h0rIZ rEx/IOO/S5SGaCl67MVAYaHnLMBAXeg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-334-H_HoZS1kPgmFjTSuoKajIw-1; Mon, 22 Feb 2021 10:39:18 -0500 X-MC-Unique: H_HoZS1kPgmFjTSuoKajIw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F9D6107ACF4; Mon, 22 Feb 2021 15:39:17 +0000 (UTC) Received: from redhat.com (ovpn-115-70.ams2.redhat.com [10.36.115.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FFF360C17; Mon, 22 Feb 2021 15:39:10 +0000 (UTC) Date: Mon, 22 Feb 2021 15:39:06 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Kevin Wolf Subject: Re: Interactive launch over QMP socket? Message-ID: References: <47b15088-514a-8174-029d-8d9c4571960a@redhat.com> <20210222114007.GB6866@merkur.fritz.box> MIME-Version: 1.0 In-Reply-To: <20210222114007.GB6866@merkur.fritz.box> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Connor Kuehl , jejb@linux.ibm.com, npmccallum@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Feb 22, 2021 at 12:40:07PM +0100, Kevin Wolf wrote: > Am 10.02.2021 um 19:01 hat Connor Kuehl geschrieben: > > Hello, > > > > Does QEMU have an internal API which would allow VM construction to wait at > > a *very specific point* until specific data/QMP message(s) are supplied via > > the QMP socket? > > > > For some additional context: QEMU supports launching AMD SEV-protected > > guests; in short: encrypted virtual machines. Guest owners may participate > > in attestation to cryptographically verify their assumptions about the > > guest's initial state, the host's platform, and the host platform owner's > > identity. If the guest owner is satisfied with the attestation process, a > > secret can be safely injected into the guest's address space over a secure > > channel. > > > > Attestation is an unavoidably interactive process. > > > > It appears that QEMU already exposes most of the API required to perform > > this attestation remotely with a guest owner over QMP, with only one > > exception: starting the attestation session. It looks like the session > > components (policy, session-file, and dh-cert-file) are supplied via command > > line arguments to QEMU and don't have a message type in the QMP spec: > > > > -object sev-guest,id=sev0,cbitpos=47,reduced-phys-bits=1,policy=0x1,session-file=blah.session,dh-cert-file=guest_owner.cert > > > > I would like to add a message type to QMP which allows guest owners to > > supply this data over a socket and _not_ require these components a priori > > via command line arguments. > > I don't think you need a new QMP command for this. If you would use > -object on the command line, you can use QMP object-add at runtime. If the object were standalone that'd true, but 'sev-guest' object you create needs to be given to the '-machine' arg's 'memory-encryption' parameter. So there's a dependancy that means 'sev-guest' can only be used with -object in reality and not QMP object-add. This will eventually be solved when we make it possible to fully configure QEMU exclusively via QMP. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|