From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: fam@euphon.net, "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org, f4bug@amsat.org,
"Willian Rampazzo" <willianr@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
stefanha@redhat.com, crosa@redhat.com,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
aurelien@aurel32.net
Subject: Re: Probing Meson for build configurations (was: [PATCH v2 3/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test)
Date: Mon, 22 Feb 2021 16:05:01 +0000 [thread overview]
Message-ID: <YDPWLXWjjVA8VS2h@redhat.com> (raw)
In-Reply-To: <71dc4eca-d52e-3650-3b23-a96950ecc05e@redhat.com>
On Mon, Feb 22, 2021 at 12:44:37PM -0300, Wainer dos Santos Moschetta wrote:
> Hi Paolo,
>
> Last week I was chatting with Cleber about probing configured features so
> that tests could be skipped (just like on this case). He has a
> implementation which never landed in, and is based on the old build system.
> Now with Meson, I am wondering if it has some sort of API for probing, or
> parsing the JSON files in build/meson-info/ is the proper way to inspect the
> build configuration.
Probing build configuration is the wrong approach.
We need to be querying the QEMU binary to ask if it has the logical
feature we need. In this case
{
"execute": "device-list-properties",
"arguments": {
"typename": "virtio-gpu-pci"
},
}
the response will include "virgl" property, if QEMU was compiled
with VirGL. This is how libvirt detects VirGL support in QEMU
today.
> On 2/22/21 7:14 AM, Alex Bennée wrote:
> > This is a band-aid with a TODO for cases when QEMU doesn't start due
> > to missing VirGL. Longer term we could do with some proper feature
> > probing.
> >
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> > Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> > Message-Id: <20210217121932.19986-7-alex.bennee@linaro.org>
> > ---
> > tests/acceptance/virtio-gpu.py | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-gpu.py
> > index ab1a4c1a71..ab18cddbb7 100644
> > --- a/tests/acceptance/virtio-gpu.py
> > +++ b/tests/acceptance/virtio-gpu.py
> > @@ -85,7 +85,12 @@ def test_virtio_vga_virgl(self):
> > "-append",
> > kernel_command_line,
> > )
> > - self.vm.launch()
> > + try:
> > + self.vm.launch()
> > + except:
> > + # TODO: probably fails because we are missing the VirGL features
> > + self.cancel("VirGL not enabled?")
> > +
> > self.wait_for_console_pattern("as init process")
> > exec_command_and_wait_for_pattern(
> > self, "/usr/sbin/modprobe virtio_gpu", ""
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-02-22 16:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 10:14 [PATCH v2 0/6] testing/next (meson check-tcg, fedora bump, docs) Alex Bennée
2021-02-22 10:14 ` [PATCH v2 1/6] meson.build: expose TCG cross compiler information in summary Alex Bennée
2021-02-22 10:14 ` [PATCH v2 2/6] docker: Bump Fedora images to release 33 Alex Bennée
2021-02-22 10:14 ` [PATCH v2 3/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test Alex Bennée
2021-02-22 15:44 ` Probing Meson for build configurations (was: [PATCH v2 3/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test) Wainer dos Santos Moschetta
2021-02-22 16:05 ` Daniel P. Berrangé [this message]
2021-02-22 10:14 ` [PATCH v2 4/6] docs/devel: expand on use of containers to build tests Alex Bennée
2021-02-22 11:39 ` Thomas Huth
2021-02-22 10:14 ` [PATCH v2 5/6] docs/devel: update the container based tests Alex Bennée
2021-02-22 11:46 ` Thomas Huth
2021-02-22 12:14 ` Alex Bennée
2021-02-22 12:15 ` Thomas Huth
2021-02-22 10:14 ` [PATCH v2 6/6] docs/devel: add forward reference to check-tcg Alex Bennée
2021-02-22 11:36 ` Philippe Mathieu-Daudé
2021-02-22 12:16 ` Thomas Huth
2021-02-24 3:33 ` [PATCH v2 0/6] testing/next (meson check-tcg, fedora bump, docs) Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDPWLXWjjVA8VS2h@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).