From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A10F8C433E0 for ; Tue, 23 Feb 2021 03:11:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C7C861493 for ; Tue, 23 Feb 2021 03:11:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C7C861493 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50588 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEO6K-0002Dd-35 for qemu-devel@archiver.kernel.org; Mon, 22 Feb 2021 22:11:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:58666) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEO38-0006EX-7p; Mon, 22 Feb 2021 22:07:46 -0500 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:38667 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEO35-0003Da-UI; Mon, 22 Feb 2021 22:07:45 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 4Dl3rS5NJnz9sTD; Tue, 23 Feb 2021 14:07:36 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1614049656; bh=lB2qhVhVvCNwKnLEP9cyVRt4kgQq0RQXnIPlpk7dq2g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KFOWhcID0dtdiNAomEpDaPts1jSJ82Ytxndpt+d2goQHThz6ePo193JIsAGJiwYUo P86LbDcu1xNkh2QLXqPt/+rGLma2RlyYfZGg3c2dZ4Rw4FNWTs8HtM/WMOo8D/0hW2 WkZKKs7NJTNCZUbJTm/cdhZcKb3yIEEd5MCTIJEI= Date: Tue, 23 Feb 2021 10:37:01 +1100 From: David Gibson To: Cornelia Huck Subject: Re: [PATCH v2 01/11] accel/kvm: Check MachineClass kvm_type() return value Message-ID: References: <20210219173847.2054123-1-philmd@redhat.com> <20210219173847.2054123-2-philmd@redhat.com> <20210222182405.3e6e9a6f.cohuck@redhat.com> <20210222185044.23fccecc.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iHciYgIJJ+RNzZ6R" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, Paul Durrant , David Hildenbrand , qemu-devel@nongnu.org, "Edgar E. Iglesias" , Stefano Stabellini , "Michael S. Tsirkin" , Huacai Chen , Halil Pasic , Christian Borntraeger , =?iso-8859-1?Q?Herv=E9?= Poussineau , Anthony Perard , xen-devel@lists.xenproject.org, Leif Lindholm , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Thomas Huth , Eduardo Habkost , Mark Cave-Ayland , Alistair Francis , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Radoslaw Biernacki , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --iHciYgIJJ+RNzZ6R Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 23, 2021 at 10:33:55AM +1100, David Gibson wrote: > On Mon, Feb 22, 2021 at 06:50:44PM +0100, Cornelia Huck wrote: > > On Mon, 22 Feb 2021 18:41:07 +0100 > > Philippe Mathieu-Daud=E9 wrote: > >=20 > > > On 2/22/21 6:24 PM, Cornelia Huck wrote: > > > > On Fri, 19 Feb 2021 18:38:37 +0100 > > > > Philippe Mathieu-Daud=E9 wrote: > > > > =20 > > > >> MachineClass::kvm_type() can return -1 on failure. > > > >> Document it, and add a check in kvm_init(). > > > >> > > > >> Signed-off-by: Philippe Mathieu-Daud=E9 > > > >> --- > > > >> include/hw/boards.h | 3 ++- > > > >> accel/kvm/kvm-all.c | 6 ++++++ > > > >> 2 files changed, 8 insertions(+), 1 deletion(-) > > > >> > > > >> diff --git a/include/hw/boards.h b/include/hw/boards.h > > > >> index a46dfe5d1a6..68d3d10f6b0 100644 > > > >> --- a/include/hw/boards.h > > > >> +++ b/include/hw/boards.h > > > >> @@ -127,7 +127,8 @@ typedef struct { > > > >> * implement and a stub device is required. > > > >> * @kvm_type: > > > >> * Return the type of KVM corresponding to the kvm-type string= option or > > > >> - * computed based on other criteria such as the host kernel ca= pabilities. > > > >> + * computed based on other criteria such as the host kernel ca= pabilities > > > >> + * (which can't be negative), or -1 on error. > > > >> * @numa_mem_supported: > > > >> * true if '--numa node.mem' option is supported and false oth= erwise > > > >> * @smp_parse: > > > >> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c > > > >> index 84c943fcdb2..b069938d881 100644 > > > >> --- a/accel/kvm/kvm-all.c > > > >> +++ b/accel/kvm/kvm-all.c > > > >> @@ -2057,6 +2057,12 @@ static int kvm_init(MachineState *ms) > > > >> "kvm-= type", > > > >> &erro= r_abort); > > > >> type =3D mc->kvm_type(ms, kvm_type); > > > >> + if (type < 0) { > > > >> + ret =3D -EINVAL; > > > >> + fprintf(stderr, "Failed to detect kvm-type for machin= e '%s'\n", > > > >> + mc->name); > > > >> + goto err; > > > >> + } > > > >> } > > > >> =20 > > > >> do { =20 > > > >=20 > > > > No objection to this patch; but I'm wondering why some non-pseries > > > > machines implement the kvm_type callback, when I see the kvm-type > > > > property only for pseries? Am I holding my git grep wrong? =20 > > >=20 > > > Can it be what David commented here? > > > https://www.mail-archive.com/qemu-devel@nongnu.org/msg784508.html > > >=20 > >=20 > > Ok, I might be confused about the other ppc machines; but I'm wondering > > about the kvm_type callback for mips and arm/virt. Maybe I'm just > > confused by the whole mechanism? >=20 > For ppc at least, not sure about in general, pseries is the only > machine type that can possibly work under more than one KVM flavour > (HV or PR). So, it's the only one where it's actually useful to be > able to configure this. Wait... I'm not sure that's true. At least theoretically, some of the Book3E platforms could work with either PR or the Book3E specific KVM. Not sure if KVM PR supports all the BookE instructions it would need to in practice. Possibly pseries is just the platform where there's been enough people interested in setting the KVM flavour so far. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --iHciYgIJJ+RNzZ6R Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmA0QB0ACgkQbDjKyiDZ s5JQqBAA2HMmkpdhk4iK7XRStsDCbxBXZysxhFDBM0qLWfKEbOKqcRzv9BiIFbRb Ioh4AG1Vvt/cxatFBRkKOOIML8ICtAm/hhBBo3A/6gwi5ogzlRO54Jkr+GIWiRSH 0iY9VKPGnsjTaf6SrE7GKxdYiPdGTR+6+2snq/f0EUjcz15LsWujsrB2Vyr/F/Oe KEYH+S+Pwot39s3mGSOIR0QYHsfN4+oYLPajZXdmcrGjBsTNM6s7+fDGb6oAC7Yg 7cvOCbL6EAOJ1P3wmYySwu1rVM/vU6IFW7LUfZcP33JynhPYWWh7J84zCTBwNgJF IQvlIEQU3Qta+SieLJma+ZTwALAiYSDKSJ1n4vIEWQ21FoQLSbzP4oxqDMiTZha+ LW5mzqPTQuF/MZg+B+dZtpCKWiLhkG7SWVB7Gb8hq7wat+AZONUJU/BaqQq2QVdN a7YiR95k/6rsUFyN0I8NYsrIIMbR6IlI+ivVCukvurwo3iP9m+4/UyM/gM3XRBNc ekYjyglLGj9pztFIC0JVBPodTG/8OSkAuvVDh2fVaefjfj0nckXJ9oxJDc1D6LH2 vocCjxis9Dv2YgQgzem8pUAQ//Z1WGIiiyWD1gPDt/A3EDbvjxHPZK0w7ZOxKLYR cagHb4ijSlK6htqbMaqOJ3zM7FOgPwHvc0xLzUttBEolVXQia1E= =kPBL -----END PGP SIGNATURE----- --iHciYgIJJ+RNzZ6R--