From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5045C433DB for ; Mon, 1 Mar 2021 11:27:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61B6160238 for ; Mon, 1 Mar 2021 11:27:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61B6160238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51796 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGghc-0007lv-Dt for qemu-devel@archiver.kernel.org; Mon, 01 Mar 2021 06:27:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGgf2-0006eh-Iy for qemu-devel@nongnu.org; Mon, 01 Mar 2021 06:24:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:51020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lGgez-0006Oz-Hp for qemu-devel@nongnu.org; Mon, 01 Mar 2021 06:24:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614597860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+GgYK4ixDan5pmx5gm9c+eM//WfHQDV7uWEEMEL9mUY=; b=dqLobaIxPKNRA6p45eDlbXXmFbZiH4wugSNRZN9WedsgC5+AfTX9IxzTVaF94ewc8ZiqX6 K216sDxBJXe1aBdpDmP9FRq0u6tSmH8YHg+kCf5wcRvZgOHp5xqn8TFBOQdtgURGs8QYZL gpjHwQFZw+RqmDFl/yXYJnIHqXpwcfU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-418-EwFfX5wZM_-tm0NDY2Eptg-1; Mon, 01 Mar 2021 06:24:15 -0500 X-MC-Unique: EwFfX5wZM_-tm0NDY2Eptg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E62C107ACE8; Mon, 1 Mar 2021 11:24:14 +0000 (UTC) Received: from localhost (ovpn-115-54.ams2.redhat.com [10.36.115.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id A15FF5D9FC; Mon, 1 Mar 2021 11:24:12 +0000 (UTC) Date: Mon, 1 Mar 2021 11:24:11 +0000 From: Stefan Hajnoczi To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH] multiprocess: move feature to meson_options.txt Message-ID: References: <20210224122306.451764-1-pbonzini@redhat.com> <72fc7d76-f8e3-2c0f-e890-99509bb6230d@redhat.com> <08381101-fde1-dc5c-8156-32e90b21fee3@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bw8L+pDKk61UkxQD" Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.248, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elena Ufimtseva , John Johnson , Thomas Huth , Jag Raman , "qemu-devel@nongnu.org" , Markus Armbruster , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --bw8L+pDKk61UkxQD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 26, 2021 at 09:50:59AM +0100, Philippe Mathieu-Daud=C3=A9 wrote= : > On 2/26/21 8:48 AM, Paolo Bonzini wrote: > > On 26/02/21 00:16, Philippe Mathieu-Daud=C3=A9 wrote: > >>> I personally don=E2=80=99t have any preference for the name. > >> Great. > >> > >> So with the summary/description updated as: > >> > >> summary_info +=3D {'Multiprocess QEMU (vfio-user device backends)': > >> multiprocess_allowed} > >> > >> option('multiprocess', type: 'feature', value: 'auto', > >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 description: 'Multiprocess = QEMU (vfio-user device backends) > >> support') > >> > >> Reviewed-by: Philippe Mathieu-Daud=C3=A9 > >> > >=20 > > It's not yet vfio-user.=C2=A0 For now I can put "out of process device > > emulation"; >=20 > OK. >=20 > > however, if the protocol is going to change, I wonder if it > > should be disabled by default. >=20 > Sounds safer indeed. We need to add --enable-multiprocess in CI to > keep testing the feature. Package maintainers tend to disable optional features explicitly, while developers and CIs may not notice new features that are disabled by default. In the interest of preventing bitrot and catching failures early (before CI!), I suggest leaving it enabled for maximum build coverage. Stefan --bw8L+pDKk61UkxQD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmA8ztsACgkQnKSrs4Gr c8j0XAgAjvMJ/uiedh4wVD0t+DjNVZBWBLjINV87DkWeT/inpzCIIMO/axWmfs74 KyJQSyiI9V6Nk7nmsoKDr3eC1Wj3R5w3j049VHtmcPTQX0sGGWm4mk4BDli9Drfp vFSZTv1bSednqJPOebO60XEZgKdwtuTiOROT1U9ZlOKjc+7RIJyAQ0ZNoZx0VPYR iGkbW38WHg5FHp6nqFZpMdfHLgOhp7zgat2BHObXGXbXs+1LXjKBguxCMDaXbpkn f9K6VjRY10BSJoRg8uuyrSk1qm6D23vSir4zgH5lA6ZsmLG0YdsbE8se+JZ5EI06 /jf6FoBH6VncmuguVfo6eAdpM+Mi/w== =U33y -----END PGP SIGNATURE----- --bw8L+pDKk61UkxQD--