qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <fam@euphon.net>,
	Qemu-block <qemu-block@nongnu.org>,
	Klaus Jensen <k.jensen@samsung.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Keith Busch <kbusch@kernel.org>
Subject: Re: [PULL for-6.0 v2 00/10] emulated nvme fixes for -rc3
Date: Wed, 7 Apr 2021 10:45:04 +0200	[thread overview]
Message-ID: <YG1xEH2BWGAAxQuT@apples.localdomain> (raw)
In-Reply-To: <CAFEAcA9HsqCJOUsL9HwNHqr5MEkRfCw4i6fc1T2hkN7t4QgpdQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2375 bytes --]

On Apr  7 08:03, Peter Maydell wrote:
>On Wed, 7 Apr 2021 at 06:51, Klaus Jensen <its@irrelevant.dk> wrote:
>>
>> From: Klaus Jensen <k.jensen@samsung.com>
>>
>> Hi Peter,
>>
>> My apologies that these didn't make it for -rc2!
>>
>> I botched v1, so please pull this v2 instead.
>>
>>
>> The following changes since commit d0d3dd401b70168a353450e031727affee828527:
>>
>>   Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100)
>>
>> are available in the Git repository at:
>>
>>   git://git.infradead.org/qemu-nvme.git tags/nvme-fixes-2021-04-07-pull-request
>>
>> for you to fetch changes up to 5dd79300df47f07d0e9d6a7bda43b23ff26001dc:
>>
>>   hw/block/nvme: fix out-of-bounds read in nvme_subsys_ctrl (2021-04-07 07:27:09 +0200)
>>
>> ----------------------------------------------------------------
>> emulated nvme fixes for -rc3
>>
>> v2:
>>   - added missing patches
>>
>> ----------------------------------------------------------------
>
>Hi; this semes to generate a bunch of new warnings during 'make check'
>(not sure exactly which test is producing these, due to the usual
>interleaving when using -j8):
>
>qemu-system-i386: -device nvme,addr=04.0,drive=drv0,serial=foo:
>warning: drive property is deprecated; please use an nvme-ns device
>instead
>qemu-system-i386: -device
>nvme,addr=04.0,drive=drv0,serial=foo,cmb_size_mb=2: warning: drive
>property is deprecated; please use an nvme-ns device instead
>qemu-system-ppc64: -device nvme,addr=04.0,drive=drv0,serial=foo:
>warning: drive property is deprecated; please use an nvme-ns device
>instead
>qemu-system-ppc64: -device
>nvme,addr=04.0,drive=drv0,serial=foo,cmb_size_mb=2: warning: drive
>property is deprecated; please use an nvme-ns device instead
>qemu-system-x86_64: -device nvme,addr=04.0,drive=drv0,serial=foo:
>warning: drive property is deprecated; please use an nvme-ns device
>instead
>qemu-system-x86_64: -device
>nvme,addr=04.0,drive=drv0,serial=foo,cmb_size_mb=2: warning: drive
>property is deprecated; please use an nvme-ns device instead
>
>thanks
>-- PMM
>

Hi Peter,

tests/qtest/nvme-test.c is generating these warnings.

We didn't deprecate this formally, so I will remove the warning for now. 
The device works just fine with both "legacy" and "new-style" nvme-ns 
namespace definitions.

I'll do a v3.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2021-04-07  8:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-07  5:46 Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 01/10] hw/block/nvme: fix pi constraint check Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 02/10] hw/block/nvme: fix missing string representation for ns attachment Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 03/10] hw/block/nvme: fix the nsid 'invalid' value Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 04/10] hw/block/nvme: fix warning about legacy namespace configuration Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 05/10] hw/block/nvme: update dmsrl limit on namespace detachment Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 06/10] hw/block/nvme: fix handling of private namespaces Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 07/10] hw/block/nvme: add missing copyright headers Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 08/10] hw/block/nvme: fix ns attachment out-of-bounds read Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 09/10] hw/block/nvme: fix assert crash in nvme_subsys_ns Klaus Jensen
2021-04-07  5:46 ` [PULL for-6.0 v2 10/10] hw/block/nvme: fix out-of-bounds read in nvme_subsys_ctrl Klaus Jensen
2021-04-07  8:03 ` [PULL for-6.0 v2 00/10] emulated nvme fixes for -rc3 Peter Maydell
2021-04-07  8:45   ` Klaus Jensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YG1xEH2BWGAAxQuT@apples.localdomain \
    --to=its@irrelevant.dk \
    --cc=fam@euphon.net \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --subject='Re: [PULL for-6.0 v2 00/10] emulated nvme fixes for -rc3' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox