From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D4E9C433ED for ; Wed, 7 Apr 2021 15:56:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B308261262 for ; Wed, 7 Apr 2021 15:56:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B308261262 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=NetBSD.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUAXQ-0000dI-Ic for qemu-devel@archiver.kernel.org; Wed, 07 Apr 2021 11:56:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUARp-0007OU-7l for qemu-devel@nongnu.org; Wed, 07 Apr 2021 11:50:30 -0400 Received: from 13thmonkey.org ([80.100.255.32]:65437 helo=gorilla.13thmonkey.org) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUARm-0005Uw-DB for qemu-devel@nongnu.org; Wed, 07 Apr 2021 11:50:27 -0400 Received: by gorilla.13thmonkey.org (Postfix, from userid 103) id 2AEEC2FF078C; Wed, 7 Apr 2021 15:50:20 +0000 (UTC) Date: Wed, 7 Apr 2021 15:50:20 +0000 From: Reinoud Zandijk To: Richard Henderson Subject: Re: [PATCH v7 2/4] Add NVMM accelerator: x86 CPU support Message-ID: References: <20210402202535.11550-1-reinoud@NetBSD.org> <20210402202535.11550-3-reinoud@NetBSD.org> <604abe90-5eda-bbbd-fd5a-5fb9c5c4cf9e@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <604abe90-5eda-bbbd-fd5a-5fb9c5c4cf9e@linaro.org> Received-SPF: none client-ip=80.100.255.32; envelope-from=reinoud@gorilla.13thmonkey.org; helo=gorilla.13thmonkey.org X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-devel@nongnu.org, Kamil Rytarowski , Reinoud Zandijk , Paolo Bonzini , Ryo ONODERA Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Apr 02, 2021 at 02:51:41PM -0700, Richard Henderson wrote: > On 4/2/21 1:25 PM, Reinoud Zandijk wrote: > > +i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: > > + declare_dependency(link_args: ['-lnvmm']) > > +) > > You shouldn't be playing with link flags directly. > > In patch 1, you found the nvmm library, and assigned it to the variable > 'nvmm'. You should just add the library as a dependency and let meson > figure out what to do. > > So I think this should just be > > i386_softmmu_ss.add(when: 'CONFIG_NVMM', if_true: nvmm) Thanks for the patch :) I will incorporate it! Reinoud