From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9F0C433B4 for ; Thu, 8 Apr 2021 10:52:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DE4A6113A for ; Thu, 8 Apr 2021 10:52:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DE4A6113A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38406 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUSGh-0000jo-8D for qemu-devel@archiver.kernel.org; Thu, 08 Apr 2021 06:52:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47880) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUSFD-0007lj-DZ for qemu-devel@nongnu.org; Thu, 08 Apr 2021 06:50:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31710) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUSFA-00054I-0C for qemu-devel@nongnu.org; Thu, 08 Apr 2021 06:50:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617879032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ME36SdcykL+/N1hGt42DdWfn/dFnFTUSs9a3syHhAmg=; b=PdhVs4uUAiaDrejDU9TD9ZdPf1WKGiOMNHrHasUZOQjYSVRJC3BG+Aui8Kw5mTgzwTAMOk ndnAg28LeKfptsZwGdEe85zQ/vZ2dDWj/bI7FCoY12Un5u1pZdyKRL/PyIbdcu3vjLTYpN U06XGrOzUuHS8UKPLPLozRtcX8LuzGA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-503-TpweFRctMiGnge-olEgEZw-1; Thu, 08 Apr 2021 06:50:30 -0400 X-MC-Unique: TpweFRctMiGnge-olEgEZw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24E0283DD20; Thu, 8 Apr 2021 10:50:29 +0000 (UTC) Received: from work-vm (ovpn-115-38.ams2.redhat.com [10.36.115.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 368805D9CC; Thu, 8 Apr 2021 10:50:25 +0000 (UTC) Date: Thu, 8 Apr 2021 11:50:22 +0100 From: "Dr. David Alan Gilbert" To: Andrey Gruzdev Subject: Re: [PULL 0/6] migration + virtiofsd queue Message-ID: References: <20210407102021.95225-1-dgilbert@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.6 (2021-03-06) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , huangy81@chinatelecom.cn, QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Andrey Gruzdev (andrey.gruzdev@virtuozzo.com) wrote: > On 07.04.2021 19:50, Dr. David Alan Gilbert wrote: > > * Peter Maydell (peter.maydell@linaro.org) wrote: > > > On Wed, 7 Apr 2021 at 11:22, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan Gilbert" > > > > > > > > The following changes since commit d0d3dd401b70168a353450e031727affee828527: > > > > > > > > Update version for v6.0.0-rc2 release (2021-04-06 18:34:34 +0100) > > > > > > > > are available in the Git repository at: > > > > > > > > git://github.com/dagrh/qemu.git tags/pull-migration-20210407a > > > > > > > > for you to fetch changes up to c4e232bb57aca19ca60f692ee830023a76eca78e: > > > > > > > > tests/migration: fix parameter of auto-converge migration (2021-04-06 18:56:02 +0100) > > > > > > > > ---------------------------------------------------------------- > > > > migration+virtiofs fixes pull 2021-04-07 > > > > > > > > A seg fix in virtiofsd, a bunch of fixes for background snapshots, and > > > > a migration test fix. > > > > > > > > Signed-off-by: Dr. David Alan Gilbert > > > > > > > > ---------------------------------------------------------------- > > > Fails to link on non-Linux hosts: > > > > > > Undefined symbols for architecture x86_64: > > > "_ram_write_tracking_prepare", referenced from: > > > _bg_migration_thread in migration_migration.c.o > > > ld: symbol(s) not found for architecture x86_64 > > > > > > The definition of ram_write_tracking_prepare() is inside an > > > #if defined(__linux__), but the callsite is not, I think. > > OK, reproduced here. Let me see. > > > > Dave > > > Seems that non-linux stub is missing, I'll respin. I posted a v2 pull with an extra ifdef, lets get that in, and we can tidy the stub in later. Dave > > > thanks > > > -- PMM > > > > > > -- > Andrey Gruzdev, Principal Engineer > Virtuozzo GmbH +7-903-247-6397 > virtuzzo.com > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK