From: Roman Kagan <rvkagan@yandex-team.ru>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com
Subject: Re: [PATCH v2 08/10] block/nbd: rename NBDConnectThread to NBDClientConnection
Date: Thu, 8 Apr 2021 19:54:16 +0300 [thread overview]
Message-ID: <YG81OIVRe19zZ6ec@rvkaganb.lan> (raw)
In-Reply-To: <20210408140827.332915-9-vsementsov@virtuozzo.com>
On Thu, Apr 08, 2021 at 05:08:25PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> We are going to move connection code to own file and want clear names
> and APIs.
>
> The structure is shared between user and (possibly) several runs of
> connect-thread. So it's wrong to call it "thread". Let's rename to
> something more generic.
>
> Appropriately rename connect_thread and thr variables to conn.
>
> connect_thread_state_unref() function gets new appropriate name too
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> block/nbd.c | 127 ++++++++++++++++++++++++++--------------------------
> 1 file changed, 63 insertions(+), 64 deletions(-)
[To other reviewers: in addition to renaming there's one blank line
removed, hence the difference between (+) and (-)]
Reviewed-by: Roman Kagan <rvkagan@yandex-team.ru>
next prev parent reply other threads:[~2021-04-08 16:56 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 14:08 [PATCH v2 00/10] block/nbd: move connection code to separate file Vladimir Sementsov-Ogievskiy
2021-04-08 14:08 ` [PATCH v2 01/10] block/nbd: introduce NBDConnectThread reference counter Vladimir Sementsov-Ogievskiy
2021-04-08 15:31 ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 02/10] block/nbd: BDRVNBDState: drop unused connect_err and connect_status Vladimir Sementsov-Ogievskiy
2021-04-08 15:33 ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 03/10] util/async: aio_co_enter(): do aio_co_schedule in general case Vladimir Sementsov-Ogievskiy
2021-04-08 15:54 ` Roman Kagan
2021-04-09 14:38 ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 04/10] block/nbd: simplify waking of nbd_co_establish_connection() Vladimir Sementsov-Ogievskiy
2021-04-08 16:10 ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 05/10] block/nbd: drop thr->state Vladimir Sementsov-Ogievskiy
2021-04-08 16:36 ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 06/10] block/nbd: bs-independent interface for nbd_co_establish_connection() Vladimir Sementsov-Ogievskiy
2021-04-08 16:45 ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 07/10] block/nbd: make nbd_co_establish_connection_cancel() bs-independent Vladimir Sementsov-Ogievskiy
2021-04-08 16:50 ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 08/10] block/nbd: rename NBDConnectThread to NBDClientConnection Vladimir Sementsov-Ogievskiy
2021-04-08 16:54 ` Roman Kagan [this message]
2021-04-08 14:08 ` [PATCH v2 09/10] block/nbd: introduce nbd_client_connection_new() Vladimir Sementsov-Ogievskiy
2021-04-08 16:57 ` Roman Kagan
2021-04-08 14:08 ` [PATCH v2 10/10] nbd: move connection code from block/nbd to nbd/client-connection Vladimir Sementsov-Ogievskiy
2021-04-08 17:04 ` Roman Kagan
2021-04-08 17:07 ` Vladimir Sementsov-Ogievskiy
2021-06-02 21:32 ` Eric Blake
2021-04-08 17:16 ` [PATCH v2 00/10] block/nbd: move connection code to separate file Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG81OIVRe19zZ6ec@rvkaganb.lan \
--to=rvkagan@yandex-team.ru \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).