From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F77FC433C1 for ; Tue, 30 Mar 2021 10:18:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA7D1619AB for ; Tue, 30 Mar 2021 10:18:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA7D1619AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRBSB-0006pP-Qj for qemu-devel@archiver.kernel.org; Tue, 30 Mar 2021 06:18:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45784) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRBQn-0005sw-99 for qemu-devel@nongnu.org; Tue, 30 Mar 2021 06:17:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49249) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRBQk-00045J-Vh for qemu-devel@nongnu.org; Tue, 30 Mar 2021 06:17:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617099422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XUevlfeZL6g2QypEVTNzaGibK7UlagCPIRS7tuTrcgA=; b=O/ejcVaQ7hhy7iMrRnTI+DqKZw2cUkK9X0HlQeSAcS/MH6CtFlKImYpAquyov0mmib0BBg GBMuVrNH9IqF/EHd0Cql8KPBiJeaehR409TvotV2wxWXXHE/ZsTZIGW1+cYsOxJp50QSWV tQS6faeDYVjp0JA9KrL164MktI//6Ok= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-vGfyygEnN1iDa1WcSSw__Q-1; Tue, 30 Mar 2021 06:16:57 -0400 X-MC-Unique: vGfyygEnN1iDa1WcSSw__Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA8FD801814; Tue, 30 Mar 2021 10:16:55 +0000 (UTC) Received: from localhost (ovpn-115-22.ams2.redhat.com [10.36.115.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id BFE661A266; Tue, 30 Mar 2021 10:16:51 +0000 (UTC) Date: Tue, 30 Mar 2021 11:16:50 +0100 From: Stefan Hajnoczi To: Greg Kurz Subject: Re: [RFC 1/8] memory: Allow eventfd add/del without starting a transaction Message-ID: References: <20210325150735.1098387-1-groug@kaod.org> <20210325150735.1098387-2-groug@kaod.org> <20210330094749.577da616@bahia.lan> MIME-Version: 1.0 In-Reply-To: <20210330094749.577da616@bahia.lan> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="beLrDWuReVJJKljS" Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Max Reitz , Paolo Bonzini , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --beLrDWuReVJJKljS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 30, 2021 at 09:47:49AM +0200, Greg Kurz wrote: > On Mon, 29 Mar 2021 18:03:49 +0100 > Stefan Hajnoczi wrote: >=20 > > On Thu, Mar 25, 2021 at 04:07:28PM +0100, Greg Kurz wrote: > > > diff --git a/include/exec/memory.h b/include/exec/memory.h > > > index 5728a681b27d..98ed552e001c 100644 > > > --- a/include/exec/memory.h > > > +++ b/include/exec/memory.h > > > @@ -1848,13 +1848,25 @@ void memory_region_clear_flush_coalesced(Memo= ryRegion *mr); > > > * @match_data: whether to match against @data, instead of just @add= r > > > * @data: the data to match against the guest write > > > * @e: event notifier to be triggered when @addr, @size, and @data a= ll match. > > > + * @transaction: whether to start a transaction for the change > >=20 > > "start" is unclear. Does it begin a transaction and return with the > > transaction unfinished? I think instead the function performs the > > eventfd addition within a transaction. It would be nice to clarify this= . > >=20 >=20 > What about:=20 >=20 > * @transaction: if true, the eventfd is added within a nested transactio= n, > * if false, it is up to the caller to ensure this is calle= d > * within a transaction. Sounds good, thanks! Stefan --beLrDWuReVJJKljS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmBi+pIACgkQnKSrs4Gr c8i6wQf/Yc7izhm6jb3f0PMRWS7mHK536gPDDlwbbfzuqnYwDOlJCiCj8bCgegK0 7/QB3yJ134BVP0jiB+PAebScXu2OvMhNtaWOkkRkjNNYXKkN5HwZQlfseTLbsdYS /bp2KihrdnvJe/WwGNdZI+CQKORYZY7G4G+2bOGBX5ukAFxkr7FHl4j8tXKwGwUM oJh0Q2AIMzkkKDzm1kG+Gi8jjDI4kjWO2RJhcth7nD4dt5P54G28pZsgjXAjnxSh uj8J8w7K9rLqPQEFVvpMdTTjWWvLzEwZLpYcj8DHPu0H3ayB11FBLxUZxf2Cna7h LC24KzP4wZllNCbudpaXZwtWtySQVQ== =uXZ7 -----END PGP SIGNATURE----- --beLrDWuReVJJKljS--